Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c8d61171-225f-ca1c-db9e-7ed3f91365b8@somainline.org>
Date:   Mon, 27 Sep 2021 00:58:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: [PATCH] arm64: dts: qcom: Drop vdd-supply from qusb2-phy devices
Content-Language: en-US
To:     Shawn Guo <shawn.guo@linaro.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Rajendra Nayak <rnayak@codeaurora.org>,
        Rob Clark <robdclark@chromium.org>,
        Douglas Anderson <dianders@chromium.org>,
        Caleb Connolly <caleb@connolly.tech>,
        Amit Pundir <amit.pundir@linaro.org>,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210926075951.28034-1-shawn.guo@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@somainline.org>
In-Reply-To: <20210926075951.28034-1-shawn.guo@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 26.09.2021 09:59, Shawn Guo wrote:
> Looking at qcom,qusb2-phy.yaml bindings and qusb2_phy_vreg_names[] in
> qusb2-phy driver, vdd-supply is not a supported/valid property.  Drop it
> from qusb2-phy devices on various boards.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

Why not add it to the regulators list instead? It's a valid regulator for this hw.


Konrad