Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: saiprakash.ranjan=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 27 Sep 2021 09:56:38 +0530
From:   Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To:     Tao Zhang <quic_taozha@quicinc.com>
Cc:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
        Tingwei Zhang <quic_tingweiz@quicinc.com>,
        Mao Jinlong <quic_jinlmao@quicinc.com>,
        Yuanfang Zhang <quic_yuanfang@quicinc.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sm8250: Add Coresight support
In-Reply-To: <1632710581-11896-1-git-send-email-quic_taozha@quicinc.com>
References: <1632710581-11896-1-git-send-email-quic_taozha@quicinc.com>
Message-ID: <8ff1838f88670cc401a35dc43cc43feb@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

Hi Tao,

On 2021-09-27 08:13, Tao Zhang wrote:
> Add the basic coresight components found on Qualcomm SM8250 Soc. The
> basic coresight components include ETF, ETMs,STM and the related
> funnels.
> ETM verification and use of Coresight components need Coresight
> support in this device tree. Since the ETR sink needs SMMU support,
> and SMMU has not been enabled on RB5. ETR is not added to this patch,
> and it will be added once SMMU is enabled on RB5. ETF sink has been
> added to the device tree for RB5.
> 

RB5 board is based on SM8250 SoC and coresight is a SoC level IP (won't
change per board, although can be disabled per board) and as such these
coresight dt nodes should be in sm8250.dtsi (please look at other 
examples
in SM8150/SC7180/SC7280).

Similarly SMMU support is not per board (RB5), it's already supported
for SM8250 long time back (check for apps_smmu in sm8250.dtsi), so you
can add ETR support when you post v3 (note this patch which you have
posted should have been v3 as v2 was your previous version). You can 
just
post one patch with the coresight dt entries as the ETM driver patch is
already queued by Suzuki in coresight tree. You can use the following 
qcom
tree [1] when posting DT for QCOM devices (branch: for-next), also 
please
remember to *sort the nodes by address*.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/?h=for-next

Thanks,
Sai

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation