Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Aditya Garg <gargaditya08@live.com>
To:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Urgent bug fix causing Apple SSDs to not work.
Thread-Topic: [PATCH] Urgent bug fix causing Apple SSDs to not work.
Thread-Index: AQHXscFVd2R2aGQVnEGbLlhqpJsHVKu1F/kAgAASzICAAAs0gIAAkgX1gAAtJVaAAAzqAIABTFoD
Date:   Mon, 27 Sep 2021 04:35:00 +0000
Message-ID: <PNZPR01MB4415FE077EAA0C094A8EE6DAB8A79@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
References: <PNZPR01MB4415600ACD3C8D9944F15058B8A59@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
 <CAHk-=wgML11x9afCvmg9yhVm9wi5mvnjBvmX+i7OfMA0Vd4FWA@mail.gmail.com>
 <20210925195425.GB116968@dhcp-10-100-145-180.wdc.com>
 <7e75e292-3073-f1f9-287a-badf92c8e4e8@grimberg.me>
 <PNZPR01MB4415F5304CAA1A83442549DBB8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
 <PNZPR01MB4415986CC44AACC100AD1189B8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
 <4dae80c3-034c-617b-c766-1858d6ee1220@protonmail.com>
In-Reply-To: <4dae80c3-034c-617b-c766-1858d6ee1220@protonmail.com>
Accept-Language: en-US
Content-Language: en-US
suggested_attachment_session_id: a8fcd596-a001-7bba-5080-2901fe6cd60a
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:  [qRa2i8BM1YvaLAWtVn5nrYrRLdGgG9v3k84wa1OwM4Snu4ZzVR/J+oOonpPKPyOn]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d02ea87e-d08f-492c-62f1-08d981702aa3
x-ms-traffictypediagnostic: PNZPR01MB5197:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: m0/uq2NS81jT1pvJdKpq1VSZ48RLTpJIwx8Bf8gIrr4wSyiPhRkigFe6EC0G3GTjvGMUZAoh1z8xbSKh9NTIkFaVz/Xjy/Qjk+ki2Hzgm2zl1BPe1/ySacRDaTIPrSBqY0RpdSIkOrqpQgPSf7hvD7dUR3at6JtdNoUvR81rsIYt2kYiliAPMAbODJ5APpnpyhzo4YoepyqxMj2ILQzS1f+6m3svRTGpyFo3y5SmCxfuZD5Tqgg6Kd0QrR3KeISjq3UBJ8iQvmq5OGyRIEIEE23f76jBzHSEehL0tGa/LI3LJqOsnrCKeOphIEfCCyVMFdlpfzd7LL/b3c2wn4HWKlDvYpuY1WMIoHYhbDEMdYLvzZj5l6uL447bsajkompqnTl68aO9C2onZLkvgRfL6lNGyDARdG6T+U+UYhmd7ccnoSc8/0XCn015p25ao1N4ivIGFaxnPPXlNU+qzSzKPu4Vg+ZBREfA9NPQ7kXfdNs=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: wC/iNhaAXYtt7F4HiBo28zWAG1arno4MiZf7GZqj59EOWetqiLh7fwH/YJgU71j4to7AXetkwlksiQ9UVK1TDtQSdHWPLgbEox/+q1RPpAmzYvsISEuevjwHJ64avt61/zGGbykpvgrh7BHusgDOirpUJzrQD7TDhO/4bXbUmSuuqo5f+/7YSj47YyUW8Kk7Q3XOG7p/e+vVJGO1ZsIaXg==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-a1a1a.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: d02ea87e-d08f-492c-62f1-08d981702aa3
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2021 04:35:00.0878
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNZPR01MB5197
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I tried Orlando Chamberlain's patch on 5.14.7 but still the SSD is not bein=
g recognised.

________________________________________
From: Orlando Chamberlain <redecorating@protonmail.com>
Sent: Sunday, September 26, 2021 8:44 AM
To: Aditya Garg; sagi@grimberg.me; kbusch@kernel.org
Cc: torvalds@linux-foundation.org; axboe@fb.com; hch@lst.de; linux-nvme@lis=
ts.infradead.org; james.smart@broadcom.com; chaitanya.kulkarni@wdc.com; akp=
m@linux-foundation.org; linux-kernel@vger.kernel.org; trivial@kernel.org
Subject: Re: [PATCH] Urgent bug fix causing Apple SSDs to not work.

On 26/9/21 18:07, Aditya Garg wrote:
> I checked out the proposal sent by Orlando Chamberlain to replace
> NVME_QUIRK_SHARED_TAGS , by NVME_QUIRK_SHARED_TAGS | given in the patch o=
n
> http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.htm=
l
> <http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.ht=
ml>.
> The , still causes panics to the T2 as described before. In the case of |=
, the
> kernel boots correctly without panicking the T2, but in case we are havin=
g Linux
> on an External Drive, which is my case, then the internal SSD doesn't see=
m to be
> recognised at all. I've tested the patch on 5.14.7. A screenshot of the G=
NOME
> Disks utility has been attached along with this mail.

I had some issues with the patch not applying automatically as I mixed up t=
abs and spaces,
(due to me copying stuff directly out of vim), so I had issues with getting=
 patches to apply
automatically. I've checked that this file https://github.com/Redecorating/=
mbp-16.1-linux-wifi/blob/anbox-bt/1001-apple-t2-disable-nvme-gen-counter-qu=
irk.patch
applies correctly for me (and github ci), so can you see if it still doesn'=
t work with that?