Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp3706264pxb; Mon, 27 Sep 2021 00:18:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx90FV8GC3LthrqUdqlqG9pVVYMa9fyd/yhS/QZfLLu4yzWEINjVVv7otKRQ/HTda/Gy647 X-Received: by 2002:a62:1dc5:0:b0:43e:f8a4:49a7 with SMTP id d188-20020a621dc5000000b0043ef8a449a7mr22176373pfd.26.1632727129254; Mon, 27 Sep 2021 00:18:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632727129; cv=none; d=google.com; s=arc-20160816; b=s3SAyrKVX7YU37vn5o93lZmNcLNI3+iBdxNJzikleH9PU7/Wau2GAIZl+EawVXnlT3 +stBUU4UIz6K+PylltcP4AOy/gJwmbHxzRCKnYHO/89ljsDp4tehGyiGWNDVX3vRD3Er up4VHxl6OHVS1OxNtYKGgZlICZWPiryCqGWFrkGZphRLMidrzEPZWv9SXwP22Q/Mn2uL qAVE1AlWypqpt+cYAdqzfdO+12JRrmYlV87wJGDdBROc7bSrbmfLL9fqXj7oNbyVWUd2 A7Pc/Ifn7fRqXPcUQ3RtCATPC5MqaJtySnAw6JH1EL3beLaTjYYtSNR9aozovUIl6jFp aw/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=tuPT9UMjnSF9/x2VxZzbMJbiT3SxCc7RjnbYKdMUOXk=; b=j80MEyiJv+IEJ6yiCmuOHBnM5EH9Vcsv9wIOpiqVtUjsqrUlTmG9AnDN1l3zLyksUm k80kKhMvi93H/fH3pr5pqfZHwbnvdFYOhNVwp3kgYj2RHWKMz24fW9FKiJxS65nEnmz4 pvcLgtUz6hsS/p4mQ8QsM9QaIg3o2ZdRwOzS7ywiyzmKlWG13ekeU12PNlOOf/PpV8cK bOnMIezNE8JCs3JYUXOUwRm0I8LQdNLyjub6aXKmpevHp/hxj7UifR0hFKCgigzLS7Vp MYlpnidXZec73bqdGeMjGeWAqIh2DVr2FeJko3zq00dXIDFO7iUo6IYiYVjAhkYuV6Dk rugw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=NpIOiC9J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g9si18262278pjp.51.2021.09.27.00.18.37; Mon, 27 Sep 2021 00:18:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=NpIOiC9J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233203AbhI0HTO (ORCPT + 99 others); Mon, 27 Sep 2021 03:19:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233175AbhI0HTK (ORCPT ); Mon, 27 Sep 2021 03:19:10 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 595B5C061570 for ; Mon, 27 Sep 2021 00:17:33 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id t10so73036826lfd.8 for ; Mon, 27 Sep 2021 00:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tuPT9UMjnSF9/x2VxZzbMJbiT3SxCc7RjnbYKdMUOXk=; b=NpIOiC9JGVYQ+YGJXTh0LGscT4eTT3N3WB0MpB+nmp0e3RAkiFa2U+CmaWuVoqhtFB F4roQ/o1rqwAxesyKp5TXE9xgLRngmIpg3EjrhOt/gtJUwL3ikK+DfcjscR5NvdsGYnR 5pO8pRUAAMSth27MjzOIJQ1hl4F0G9pW3gxD4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tuPT9UMjnSF9/x2VxZzbMJbiT3SxCc7RjnbYKdMUOXk=; b=Uvn5F5tsFp05uJU0d+uDx/s374lEvt7gFLtDYGEtIdzj/pLSmqZ+laEUUCbbwZJCID m0BLDXpVH2E8yTrz9XgCXH6oR1rMTtp6UlWOa06R0H7N+EiL3TMVRTC88ZdyP82Sq02S 3tfJlJpsaIfUmPLAZLdDtwSAZPgjb8c7E7gciie4bxz6tRqi1gFG0/wncJq9G1tNALe7 7IxTiGSbsRAC4Q1DsCutFhxmLSyo8ny/Ce8KPbUKwTbNEIDXhBsqFZhb/mtLTL1WY+hf fuD0xzBPOIZ/b34ouJ8IZARarpvhBM2Equn6kh5m3r399fBddQwpToOMOR/Kwk2DF6Vg 23PQ== X-Gm-Message-State: AOAM532UP3Z+DNCPaB2DWEArQO8WrYHcrMIjgA7ZEWDlJAVdQ5dieDbz BdmUrYVrCp4FXQ+K4p2vjHoVwF9dKUN3+oeUMdrFR3CI5Qc= X-Received: by 2002:a19:c3d3:: with SMTP id t202mr23208923lff.678.1632727050548; Mon, 27 Sep 2021 00:17:30 -0700 (PDT) MIME-Version: 1.0 References: <20210924162321.1.Ic2904d37f30013a7f3d8476203ad3733c186827e@changeid> <20210924162321.2.Ie8ceefb51ab6065a1151869b6fcda41a467d4d2c@changeid> In-Reply-To: <20210924162321.2.Ie8ceefb51ab6065a1151869b6fcda41a467d4d2c@changeid> From: Chen-Yu Tsai Date: Mon, 27 Sep 2021 15:17:19 +0800 Message-ID: Subject: Re: [PATCH 2/2] drm/rockchip: dsi: Fix unbalanced clock on probe error To: Brian Norris Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , dri-devel , LKML , Sandy Huang , "open list:ARM/Rockchip SoC..." , Thomas Hebb Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 25, 2021 at 7:24 AM Brian Norris wrote: > > Our probe() function never enabled this clock, so we shouldn't disable > it if we fail to probe the bridge. > > Noted by inspection. > > Fixes: 2d4f7bdafd70 ("drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver") > Signed-off-by: Brian Norris Reviewed-by: Chen-Yu Tsai