Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210924164530.1754128-1-anders.roxell@linaro.org>
 <c3bdc145-70e7-b504-0437-f451a3e1c5a8@infradead.org> <DM6PR04MB6575F2F6841B0573560E10ADFCA49@DM6PR04MB6575.namprd04.prod.outlook.com>
 <5dab9890-6142-3ac3-424a-1fc169734464@infradead.org>
In-Reply-To: <5dab9890-6142-3ac3-424a-1fc169734464@infradead.org>
From:   Anders Roxell <anders.roxell@linaro.org>
Date:   Mon, 27 Sep 2021 10:45:11 +0200
Message-ID: <CADYN=9K=DsJh+ozL1pJyPScSyZvKDTMgZa_aamEU4YRvWYsC9w@mail.gmail.com>
Subject: Re: [PATCH] scsi: ufs: Kconfig: SCSI_UFS_HWMON depens on HWMON=y
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Avri Altman <Avri.Altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "jdelvare@suse.com" <jdelvare@suse.com>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 24 Sept 2021 at 21:53, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 9/24/21 11:59 AM, Avri Altman wrote:
> >>> Since fragment 'SCSI_UFS_HWMON' can't be build as a module,
> >>> 'SCSI_UFS_HWMON' has to depend on 'HWMON=y'.
> >>>
> >>> Fixes: e88e2d32200a ("scsi: ufs: core: Probe for temperature
> >>> notification support")
> >>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> >>> ---
> >>>    drivers/scsi/ufs/Kconfig | 2 +-
> >>>    1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index
> >>> 565e8aa6319d..30c6edb53be9 100644
> >>> --- a/drivers/scsi/ufs/Kconfig
> >>> +++ b/drivers/scsi/ufs/Kconfig
> >>> @@ -202,7 +202,7 @@ config SCSI_UFS_FAULT_INJECTION
> >>>
> >>>    config SCSI_UFS_HWMON
> >>>        bool "UFS  Temperature Notification"
> >>> -     depends on SCSI_UFSHCD && HWMON
> >>> +     depends on SCSI_UFSHCD && HWMON=y
> >>>        help
> >>>          This provides support for UFS hardware monitoring. If enabled,
> >>>          a hardware monitoring device will be created for the UFS device.
>
> Thinking about this, it should be possible to do it like this
> so that both SCSI_UFSHCD=m ad SCSI_HFS_HWMON=m would also work.
> I.e., this would allow more combinations of Kconfig settings to
> work. It only excludes SCSI_UFSH_HWMON=y and HWMON=m
>
> +       depends on SCSI_UFSHCD=HWMON || HWMON=y
>
> OK, I have verified that this works (builds) in all allowed
> combinations.  Anders, would you please resubmit the patch?

Yeah, I'll send the patch.

Cheers,
Anders