Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] locking/mutex: remove rcu_read_lock/unlock as we
 already disabled preemption
To:     Waiman Long <llong@redhat.com>, peterz@infradead.org,
        mingo@redhat.com, will@kernel.org, boqun.feng@gmail.com
Cc:     linux-kernel@vger.kernel.org
References: <20210926101624.2460704-1-yanfei.xu@windriver.com>
 <9569eee4-266f-d83b-2af6-194a1a8b165c@redhat.com>
 <70424003-1b4a-bb92-1123-7820d6321717@redhat.com>
From:   "Xu, Yanfei" <yanfei.xu@windriver.com>
Message-ID: <0222bc32-9807-8bd4-bd76-dbc62f512435@windriver.com>
Date:   Mon, 27 Sep 2021 17:28:47 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <70424003-1b4a-bb92-1123-7820d6321717@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nnl0MWc2ZE9zdCt2eUlrclQ4c2dNd3QxaEo0YVkrL3IzRWJsQUJCVk5ESExC?=
 =?utf-8?B?VEVmdnBRQ2I2YVNQS1VhTTl5ZXIrcUFLR0xUSDlYeHhYQk1LL3VLdFQ0ZkhS?=
 =?utf-8?B?TGUrS0JCclZYaC9mYk5zeFlqa1hyZlBUS0YwbGNSTG9VdFhzKzEzcGFTR1dT?=
 =?utf-8?B?WmtpSXY2ek9MQ3FpcG5PMFZmS0lIL2pOQ2pxV3RZUU5DeUhLVmZCL0dJdkxJ?=
 =?utf-8?B?N0dtcEsray9KbUFHbmhnSzBRaTZ6aUVaR3M5OWtIV01VelJXbzFwUjdZSUZJ?=
 =?utf-8?B?NSsrVFhCbEtwNjYvR2V6dDdwNmN2RVlCWkFCQUpST3N2RkRtbFpUanZHbHk3?=
 =?utf-8?B?RkdlMEJURFNzNVRPSThWUksraVNMUHRzVjloYTd2eVJmQ29PU29LNVkwNzJV?=
 =?utf-8?B?cmE1VnB5cEFMS0gxL3NXZzl5MVgvMFVhZHFMYTZXOUpvN2Z1djlMMDR0WUNi?=
 =?utf-8?B?eWh0cHVBZXpieUY1dkhyanNJM0RQMkpEZzY1cFI0R2ZxOUtvQTdEZlZvczA3?=
 =?utf-8?B?TU9BVG0zbmJGRGRnR2xjcWorQXlHQTlmWjI4OWNZRHpjQ1hRQ1JIdHNVdUJ6?=
 =?utf-8?B?NGpiTUxPVDB6TldQaTN2K3V1Wm91QkNUTXpZUStLMDNZYlRQbHFxaFp3MVZt?=
 =?utf-8?B?OGZjbTIvWHdRbHBQRDhqM3BrN3BzWDI3bnpha0NVMW1MYnVKV0hhRlk0Sy9Y?=
 =?utf-8?B?VjZyWGVFNUppNlovb3dTa1grWXVQY1FmbXM2WithSkRReG1JNDk2RkZSVnpa?=
 =?utf-8?B?UTZnU1BFYnp3c0VsMWRnSDA0VHRVR2ordGthcjZNWlgxSHRUU21id3ozWmZS?=
 =?utf-8?B?WFkwNnZYVzFvaVVFdllCL3RxYllOVXBBRllNcEZ5NkZLeWlWVEt6ajh6WGhN?=
 =?utf-8?B?aGQ5NmpEam5ISkYvM2M0ZHFyYmhMR0JtRDZ1WTdGNWladmlra3ZXeFNrTEZ2?=
 =?utf-8?B?dUt2cHlTSndHeXA4TGtIQ2hrYkMwMGwvSU5xcUR1VWRsRHgzTkR0NGdtN1pj?=
 =?utf-8?B?eWNiNFZhMjJERzkrd1hEWlpWcWxiL1JRQWJtdlBRdkpCZ3NGM2Rzd3YyNUJk?=
 =?utf-8?B?MUFwSTZsSG9ZWkdJOGdkYUJ1NktXMHlZQzREY2lQUTEvR1dacTE1d2JCU1B5?=
 =?utf-8?B?WDVodFl0QkVpbkZBZXRGTkZXYXhPanJtSFFsWEthWEpxdm9MQ0QxbThUREVL?=
 =?utf-8?B?NWFGeXZ3UUh3eXM5WkRsVFNrU091MU9IVDVpRkt4bXNVVmlDenBKSVhxTlQy?=
 =?utf-8?B?UEE2ZVYxYzBnT0pJcjJmMVdzQUlsaG8vL1l5TDZYdWZvc0NZWWtyVW9EQXVt?=
 =?utf-8?B?VnN4c0xqZjUxL3NEOFU3R2tuOUw4ZHBoSG9sTG5sa0ErSjN0aFlCanMvVExu?=
 =?utf-8?B?eHdmOUhQeURWK3gvM0ZQNWhvOVhvcGRYMm9RcE45bmdIUVUvUDRTY25rR0Nt?=
 =?utf-8?B?YUtieUtjWFZ5YmZxTjV4cWIwR0pRRVJCcGdJVDR0dEdpTERsTjJvNmowL0xj?=
 =?utf-8?B?eWNMakxmVVJ5S0ZhdnVFMDdFamdwb2NqTE1NdzJSZnZpT20rdktMM1JxNDF0?=
 =?utf-8?B?K1BwUFVwTGU5SVZJYmxtQStTNDVqZ0RIK2FYZm5wVk5XRVc0OHBXdkV3Y2kw?=
 =?utf-8?B?aXZLY2NQVGhyQkY5K24rdUtIMER1VTJ1b1pKYWJjT1huUWlRRXpZWFlIU0tW?=
 =?utf-8?B?YzZKOU1qd2hWVU9ZMEUxUmR5dzQ1V1pLS1duVytjRmlWbmF4YU1PVWxuZ1lG?=
 =?utf-8?Q?39K4sn7jiEocyrbSXsEUEDUmyfin0vP8x47EpMF?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 539ca0d7-c74c-42c7-81b1-08d981993c1a
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 09:28:59.0484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ie5x8NC67tYstsOHlI4rVmSyoDyrNZPLciYYjWrLIeIWt+p3q1xB51DiA5Gu/OSdQkvSOb3U055GCLN8Gifiug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2809
X-Proofpoint-GUID: QEP-zk0Z0daUsT0qTzXy2QqObD71ld_O
X-Proofpoint-ORIG-GUID: QEP-zk0Z0daUsT0qTzXy2QqObD71ld_O
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-09-27_03,2021-09-24_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0
 priorityscore=1501 suspectscore=0 mlxlogscore=999 malwarescore=0
 adultscore=0 impostorscore=0 phishscore=0 clxscore=1015 mlxscore=0
 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2109230001 definitions=main-2109270065
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/27/21 8:46 AM, Waiman Long wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> On 9/26/21 3:16 PM, Waiman Long wrote:
>> On 9/26/21 6:16 AM, Yanfei Xu wrote:
>>> preempt_disable/enable() is equal to RCU read-side crital section,
>>> and the mutex lock slowpath disable the preemption throughout the
>>> entire slowpath. Let's remove the rcu_read_lock/unlock for saving
>>> some cycles in hot codes.
>>
>> The description is wrong. Preemption is disabled only in the
>> optimistic spinning code which is not the complete slowpath. Even
>> though it may sound reasonable that disable preemption is likely to
>> prevent reaching quiescent state, but I am not totally sure that will
>> always be the case as there are different RCU favors.
> 
> It does look like that disable preemption can serve as a substitute for
> rcu_read_lock(). However, I will suggest that you also insert a comment
> saying so and the task structure won't go away during the spinning period.
> 

Will send v2, thanks.

Yanfei

> Cheers,
> Longman
>