Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 12/13] blk-mq: Use shared tags for shared sbitmap
 support
To:     Ming Lei <ming.lei@redhat.com>
CC:     <axboe@kernel.dk>, <linux-block@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
        <hare@suse.de>
References: <1632472110-244938-1-git-send-email-john.garry@huawei.com>
 <1632472110-244938-13-git-send-email-john.garry@huawei.com>
 <YU/oIu2uQ420ol8F@T590> <6f52adfd-6904-6efb-adfc-f5f20eb5c1cf@huawei.com>
 <YVGORkQuf2FQmxwN@T590>
From:   John Garry <john.garry@huawei.com>
Message-ID: <a89ae671-c455-1b05-d140-82d4a90507f6@huawei.com>
Date:   Mon, 27 Sep 2021 10:41:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <YVGORkQuf2FQmxwN@T590>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/09/2021 10:26, Ming Lei wrote:
>>>> -	struct sbitmap_queue	sched_bitmap_tags;
>>>> -	struct sbitmap_queue	sched_breserved_tags;
>>>> +	struct blk_mq_tags	*shared_sbitmap_tags;
>>> Maybe better with shared_sched_sbitmap_tags or sched_sbitmap_tags?
>> Yeah, I suppose I should add "sched" to the name, as before.
>>
>> BTW, Do you think that I should just change shared_sbitmap -> shared_tags
>> naming now globally? I'm thinking now that I should...
> Yeah, I think so, but seems you preferred to the name of shared sbitmap, so I
> did't mention that,:-)

OK, I can clear up any references in a follow on patch to try to keep 
this one as small as possible.

Thanks,
John