Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210926055817.24352-1-rdunlap@infradead.org>
In-Reply-To: <20210926055817.24352-1-rdunlap@infradead.org>
From:   Greentime Hu <green.hu@gmail.com>
Date:   Mon, 27 Sep 2021 18:06:11 +0800
Message-ID: <CAEbi=3dmw4nTkU1cF4atXDE6Go-tujqseRKjdX7rmPaid_3D3w@mail.gmail.com>
Subject: Re: [PATCH] NDS32: perf_event_cpu: fix 2 build errors
To:     Randy Dunlap <rdunlap@infradead.org>,
        Alan Kao <alankao@andestech.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Nickhu <nickhu@andestech.com>,
        Vincent Chen <deanbo422@gmail.com>, kclin@andestech.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Randy Dunlap <rdunlap@infradead.org> =E6=96=BC 2021=E5=B9=B49=E6=9C=8826=E6=
=97=A5 =E9=80=B1=E6=97=A5 =E4=B8=8B=E5=8D=881:58=E5=AF=AB=E9=81=93=EF=BC=9A
>
> ../arch/nds32/kernel/perf_event_cpu.c: In function 'unwind_frame_kernel':
> ../arch/nds32/include/asm/current.h:10:13: error: '$r25' undeclared (firs=
t use in this function)
>    10 | #define tsk $r25
> ../arch/nds32/kernel/perf_event_cpu.c:1255:50: note: in expansion of macr=
o 'tsk'
>  1255 |                                                 (tsk, &graph, fra=
me->lp, NULL);
>
> ../arch/nds32/kernel/perf_event_cpu.c:1257:27: error: assignment to 'long=
 unsigned int' from 'long unsigned int *' makes integer from pointer withou=
t a cast [-Werror=3Dint-conversion]
>  1257 |                 frame->sp =3D ((unsigned long *)frame->sp) + 1;
>
> For $r25, use the register function for current() instead.
>
> Fixes: c8b34461705e ("nds32: Add perf call-graph support.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Nickhu <nickhu@andestech.com>
> Cc: Greentime Hu <green.hu@gmail.com>
> Cc: Vincent Chen <deanbo422@gmail.com>
> ---
> Please check the frame->sp cast/arithmetic.
>
>  arch/nds32/kernel/perf_event_cpu.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20210917.orig/arch/nds32/kernel/perf_event_cpu.c
> +++ linux-next-20210917/arch/nds32/kernel/perf_event_cpu.c
> @@ -1252,9 +1252,9 @@ static int unwind_frame_kernel(struct st
>                  */
>                 if (__kernel_text_address(frame->lp))
>                         frame->lp =3D ftrace_graph_ret_addr
> -                                               (tsk, &graph, frame->lp, =
NULL);
> +                                       (current, &graph, frame->lp, NULL=
);
>
> -               frame->sp =3D ((unsigned long *)frame->sp) + 1;
> +               frame->sp =3D (unsigned long)(((unsigned long *)frame->sp=
)) + 1;
>
>                 return 0;
>         } else {

Loop in Alan and KC.