Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp3866770pxb; Mon, 27 Sep 2021 04:34:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRWa3j5JAB9gxPimgbtxPRL3gc5FMUJeYSQy9jC8Z5IYHme30+vTOHpKQ1D5kHsyC8pNsZ X-Received: by 2002:a62:1ad6:0:b0:440:3aef:46b7 with SMTP id a205-20020a621ad6000000b004403aef46b7mr23009244pfa.86.1632742485232; Mon, 27 Sep 2021 04:34:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632742485; cv=none; d=google.com; s=arc-20160816; b=bJ8gvIEfzLPhAIbTWrCawxKewwLjbiR9wTYQGJ8PIEqC0cEgOiExUrX/e6hC+3Ybbo DE8Sjc2RJBQGR+yPmLzZ0IQ27wIdIevJ6ypzDEdORwr9U1oi03gag5qbsHk/AKS8O6Wz HhiAPC/ndyrcZST5u8nMMFBXPYrQbPqCwvcFn7H6Xb8NYJ6uBU9jVH2jcsbiYMwD5rbX wT6VssBqOHi3sCqVUZQYhnZ+TPeqWghpMwoyyEKfgEqaMvkCpBwEITD3x7BxfbMfgLkh KfDb/YqsgJ0+DkGn2twZ26FQhzs91VPpzG2KzjhylP+Q6s11S/XkH+zMySHaVwGUSjkZ AhMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=Zh4ocPd5zq01wbH2VJDNCfT88s0EYVFeCQkN48p09Rc=; b=i2jjvNEq9ONk05JUH17ZDytR0m4cZYuzhwdwuZEgOAp82DQl9VIFuUdiKeTl6ojJwf pa6ZGdnJye1jvNqlLFKC9CBZEPTKKJWXe2nCrIyV+3wSyR68084eJlebYKRFNzkz0WoU 4n6qYovkQEQKo2mCI0jjZNQL0U/aNtqjmWvcNiUmBg95x+4Ehc/57k/Ne2qlz6/1eRH7 c4lGrxtYxdJ2psJFrVwW5vYi6TrdwYgChAaiLxfhUQSC7V3jw9GarI6DJjHcpSWkw/eF +POP/6bASVonb/YnT7Pv/72J8NtF4WLRLrZZmUJXB1Xzis2HOUqOuRrX2JLSx2C3ZTjb 1Lng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=HFxbLZtA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q8si5844180plb.351.2021.09.27.04.34.31; Mon, 27 Sep 2021 04:34:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=HFxbLZtA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234069AbhI0LfO (ORCPT + 99 others); Mon, 27 Sep 2021 07:35:14 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45416 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233948AbhI0LfO (ORCPT ); Mon, 27 Sep 2021 07:35:14 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18RBQov0027164; Mon, 27 Sep 2021 07:33:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=Zh4ocPd5zq01wbH2VJDNCfT88s0EYVFeCQkN48p09Rc=; b=HFxbLZtALlzLcIV513Gw+sxVwvyBy56n2YzyuwSn5PhVx+r78j+XpSTou4uCQxcVZnoE ORBmrmCvRSJjDV+Ccv2/aAl0E0LKSqjtC7pEVYkcfhGs2gARhJrtNmpcMZLACj1l3H9e wiOzzrnbeakRimBQKGiZG/vgljuMDfDH40vFu6QUIrDqxXQm0raGWFyPpAM+xNskL32L cit9eG4DTS9wNpPPnwq/OiGUy3QfNwVJL1bvIFM7kz7dvrsv4WGOaJ2SSB2cnUlgVe2w xizeUAt1Oo/0G6wIHGgXQzOY2Vejlh581H5hmUOcXLZvcVfbDeJx89csV2wfHViBPvSe YA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bagv81unu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Sep 2021 07:33:18 -0400 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18RBQVOH012751; Mon, 27 Sep 2021 07:33:18 -0400 Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bagv81umx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Sep 2021 07:33:17 -0400 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18RBVJoX026969; Mon, 27 Sep 2021 11:33:15 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma01fra.de.ibm.com with ESMTP id 3b9ud9b7y5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Sep 2021 11:33:15 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18RBXBwa2294488 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Sep 2021 11:33:11 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2EF8442094; Mon, 27 Sep 2021 11:33:11 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7804D4205C; Mon, 27 Sep 2021 11:33:10 +0000 (GMT) Received: from sig-9-145-45-184.uk.ibm.com (unknown [9.145.45.184]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 27 Sep 2021 11:33:10 +0000 (GMT) Message-ID: Subject: Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data From: Ilya Leoshkevich To: Tiezhu Yang , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh Cc: Yauheni Kaliuta , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li Date: Mon, 27 Sep 2021 13:33:10 +0200 In-Reply-To: <1632726374-7154-1-git-send-email-yangtiezhu@loongson.cn> References: <1632726374-7154-1-git-send-email-yangtiezhu@loongson.cn> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: giYAHGJqTgpQ3DQJ2HWE-ISyvY6pZDkS X-Proofpoint-ORIG-GUID: hgcrE1P2X7C_h_hUHBTq5OFZJdaEnIUq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-27_04,2021-09-24_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=944 malwarescore=0 phishscore=0 adultscore=0 spamscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2109270079 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-09-27 at 15:06 +0800, Tiezhu Yang wrote: > Make sure to free jit_data through kfree() in the error path. > > Fixes: 1c8f9b91c456 ("bpf: s390: add JIT support for multi-function > programs") > Signed-off-by: Tiezhu Yang > --- > > RESEND due to the following reason: > [Can not connect to recipient's server because of unstable > network or firewall filter. rcpt handle timeout, last handle > info: Can not connect to vger.kernel.org] > >  arch/s390/net/bpf_jit_comp.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) Nice catch, thanks! Acked-by: Ilya Leoshkevich