Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp3881574pxb; Mon, 27 Sep 2021 04:55:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXI5XIPaJyY8WHY1zydE0+mmxCUg6U3pGoDBl7QEDy59bfgkUANlcHfItDLbvdWaBZ91aE X-Received: by 2002:a50:d8c5:: with SMTP id y5mr22756131edj.370.1632743727018; Mon, 27 Sep 2021 04:55:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632743727; cv=none; d=google.com; s=arc-20160816; b=lNQbgLBO5JcIJPdXK2n4dDDPdIQzNYZlfKxSSVTyCY1bLUx6GfmXc4zSgSOEe/cSrC dU7ovznuKpsz2DuTA7nOB0jHJr7++dexkLA3k7pDP0w4IqqaBH7WwLKdtgBV/f7L4YGL IfyA3c/pR8A3C5X1c7n+2Uu8J2zVfoaoD4J4q7h1TRX21MQYeNUR7KRGAHxDOf4Aes9W WpsYjnjP6CoIpdfcTgJzNz6OSFSZ5y2c4fqg6vCxQRlu3njNxjflwngBbPeARnn4+kaR Y582BXSlfyA2uRLJKjAKwRCWjpm5k+qL2ibWTqCi/tdayGyLqZtF2Z6pEO5BMEInh+S+ KCQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ztc9RE1ukeuFf+6GPK909lOEa77Wu1lkQu5UfLc60PY=; b=MFlQwZIR8N8gLml0g48TcHI9HVj8jhM7BhijH60xpHS6JY2o9BVF5lKgMVMfFeBqWL B6WcRnIf9pMICV0lhd/lHep2afJO0SGZ//TMOcmHkWdltDdlUECbuVQkdOU4plK5yhDi AZOie2qBwONxJ57rW+5/w/LC/r+7FCXn1ecxIRgWAWIZMSCr0/sVMzspgL4q43eUM8OB jPJneaLZ4/lCM1NHD0XhH0J0NIxeP2bfdKnSFbGCgeKhStMB+2pyH1oFwQLMN0nMEErk JlknY2qHAhvVDoDua3dDkZPB3zYv9792UuqUzrdWKf1dgrwUhe/3Z/W7ufiZKIQhYtss DHeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L5kgPclR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ch16si17991533edb.168.2021.09.27.04.55.03; Mon, 27 Sep 2021 04:55:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L5kgPclR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234130AbhI0LwI (ORCPT + 99 others); Mon, 27 Sep 2021 07:52:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:53478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234053AbhI0LwI (ORCPT ); Mon, 27 Sep 2021 07:52:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0008260F6D; Mon, 27 Sep 2021 11:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632743430; bh=+6STobOuOlzOXWTxDK/LtFOOOoG8G2+aHSnbuBCAJho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L5kgPclRUtZE9bpW9xN3xybcRvXEmbvbUAmGAMvdgoF9VFvVYaaRswEKGEuhlf/ns N8d3HyPVxp9QgAJBk67VgjLOz7I9a3Hhydet3ZKctnRrVgPhnpfuqxRpRy0FENtv0I AFfssP2NovJslPPq8RFHnIukWyN2sbsJRQZZ2iyd/X0CopRnPsM7vFv1+iXtCBicaK cOFenmlJsr2bbuMz+JVAh94sb6rm1aG2d6nZK4LB+69Toqf+X8CMa7APpMMfbBLwJC BwEmT24eo+SJi3SOmWfTMhUST/1KOnCOVkSQC2/GEO1/obr35tNXFMNvIxWP1j1yap m9wARgw1tkyCw== Date: Mon, 27 Sep 2021 12:49:42 +0100 From: Mark Brown To: Vitaly Rodionov Cc: James Schulman , David Rhodes , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Richard Fitzgerald Subject: Re: [PATCH] ASoC: cs42l42: Add HP Volume Scale control Message-ID: <20210927114942.GC4199@sirena.org.uk> References: <20210927111244.17906-1-vitalyr@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="da4uJneut+ArUgXk" Content-Disposition: inline In-Reply-To: <20210927111244.17906-1-vitalyr@opensource.cirrus.com> X-Cookie: 98% lean. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --da4uJneut+ArUgXk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 27, 2021 at 12:12:44PM +0100, Vitaly Rodionov wrote: > +static const char * const cs42l42_full_scale_vol_text[] = { > + "0dB", "-6dB" > +}; > + > +static SOC_ENUM_SINGLE_DECL(cs42l42_full_scale_vol_enum, CS42L42_HP_CTL, > + CS42L42_HP_FULL_SCALE_VOL_SHIFT, > + cs42l42_full_scale_vol_text); This looks like it's just a regular volume control that adds/removes an extra 6dB so I'd expect it to be a normal Volume with TLV info. --da4uJneut+ArUgXk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFRr9UACgkQJNaLcl1U h9CZOgf/f3f0pV80Z4P705daQFFWTtqcIqeFI3iyFeVm6ZdU+3nOGW4QGICifIEd OZDcitqkMNsdjJ0nY8eAlWwsLIvN+BRddOhWNC5Olb4eDRm8akI8I+9JApOU3QC7 5hyUMRleFuTCH4Nwfyt1p56xVC8/lrDfX9Fy1mEMMyHdhbe/KvQ2Ae8oPe4tD2+6 BxCLruymgeuVMo2GeQUvmSLIvApHyXEgm98lH6DGoRjIwsb3yO4kafedXufsK/sW 2GQcI2SW+AICehFbhkxeN0ixZQVR+FJ6bkyE1JUib+EWWiN7xCOmpdgW/M3hQdMq TUbrujHVtMXt3NTvKix1s6myspABCw== =yWuI -----END PGP SIGNATURE----- --da4uJneut+ArUgXk--