Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Sep 2021 16:02:53 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Hans de Goede <hdegoede@redhat.com>,
        Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
        linux-sparse@vger.kernel.org
Cc:     Arnd Bergmann <arnd@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Arnd Bergmann <arnd@arndb.de>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] vboxsf: fix old signature detection
Message-ID: <20210927130253.GH2083@kadam>
References: <20210927094123.576521-1-arnd@kernel.org>
 <40217483-1b8d-28ec-bbfc-8f979773b166@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <40217483-1b8d-28ec-bbfc-8f979773b166@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D0e04gkMfq4O+rNmMUeANG3av2BxCvCjCoJXXhQPTe/6zRidvvHmzNernLfN?=
 =?us-ascii?Q?EUpC4z1o9P+IQEZb7ZIQSNG1eQXLOZ32WhCRq9pPK0bhwwuNTjDVDSRXfdYv?=
 =?us-ascii?Q?tpyu7Wlx4ySQNqUt6hkguToRUP1eOKYFqlIiretTsU1clEIcowKCG2ycYNPo?=
 =?us-ascii?Q?vq67gnbzzYTT/1nLOjqIYwCO7EA421FlSA9Jkua7/3nxaYRhZqPGroOTVsTT?=
 =?us-ascii?Q?c3djZV/yPH1Y7DVLNZDhHpi4DEpTpW2urHaKQCjIcwCtXkrFdcgxe6OfwTOi?=
 =?us-ascii?Q?/BViatfkozIVPtvJDxkZA8nP2/IFs4APR/tNzdUtWbY3yLAFS7onUaPZmuW7?=
 =?us-ascii?Q?xhwGj8gWtWuDGf9dzzrZADHR4Lr7l8okvsOWEXb0b8m33XOKyu3+/4OrkOJ0?=
 =?us-ascii?Q?crhuYD+aoM0P98a9vDt/pVlCeYnxqSR1F9iRFrU0bdgxvQs5i64m1HYQnw53?=
 =?us-ascii?Q?DuYK2z7UJYcOtkDuyKwca5JjrPmvo/JlO1FU6jpR5s03QkOjrRS9GEtFoPyw?=
 =?us-ascii?Q?J0dlS1b+j7oK1QfDHbDhFyfBZ6AEH4cc8wki7gsfyEKUYCbi9YBOGBDEZtJG?=
 =?us-ascii?Q?ULKWlsySQGAWWwWrWV+0pBLu6W8i+rPvgpyZDu2wh6XGQwNXTsZa9Yx1zioB?=
 =?us-ascii?Q?07MyL5Hps6l7Al47s7zu5x3FPNhhlqLmMlXymqII7Y0VgFWrkasWKs+o8OA1?=
 =?us-ascii?Q?vq1b/Zl54ufXBBQEh4yM+a0LBpYi23Rm/iaGvNOfZc4+1ulJ9v0Qlzp4tvzF?=
 =?us-ascii?Q?9tvxzJZ4uU/B+8+1PUu58KGUsCBQ1KJPh4oLFLEIaz2PWJ64YlYr6sj3JEJ5?=
 =?us-ascii?Q?phSDyvLX+LLWtxt71FJM2sQsH2qK/XrPubxZ+9d52IPEdNqj5fKgq1yCdP26?=
 =?us-ascii?Q?S6lnxcUBhu8Iutw1yDLAXy+4Vq3qWOJdN06c62anpI/6LrxHplWkC/2TlHIZ?=
 =?us-ascii?Q?iz4Sneb9ri7gV6YI1VvxU0//zojH5VfeEo3SU5DoVuEyuza95GwNv4o9txRn?=
 =?us-ascii?Q?Yk1fvMK2kbMnsfO72528M13HiFnVT15pu8svunTT4uQj3oRRgOrWsvGtshVQ?=
 =?us-ascii?Q?+IRT0iaPXdQHN4sv5FD84Ua6UbpmHVA2RFM+ZMfMbhRNUMvkiDZzfIHPALSF?=
 =?us-ascii?Q?cukIlK3dVTeCL1FVVBl1MGChAbTfrPeekbcga3iPxZGlP3Np7cx4wXtq4WB0?=
 =?us-ascii?Q?L3EmfuUOTHbKoEa2xE5OeYZRR8MzJBAIlTqty2qyVimygTGFBf44UA17xf4h?=
 =?us-ascii?Q?vjz9StPEA2kHU532NlbgeC9d2DvbaqNu+m4LqElzht7f1A+VSmRagNwiBm3R?=
 =?us-ascii?Q?x1x728HJ+EMDpy36xOQvQ6PU?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 957f6063-5805-47d9-ec27-08d981b72c93
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 13:03:17.8304
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E6KLcDBY6V0YuXklpY0fAwNWoqa/er8MxPsgBSM7kAwQ/J74HnV0NDOnEv1B6h1Y49ECz1lIxaAYJUk5L6QA3ShGXOhlSu1ycDlW3BRmZGI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1246
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10119 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0
 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 mlxscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2109270090
X-Proofpoint-ORIG-GUID: toiYraUUfyGe8NP3ymQyLMsN6nwYjHXR
X-Proofpoint-GUID: toiYraUUfyGe8NP3ymQyLMsN6nwYjHXR
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

GCC handles it the same way as Clang.  '\377' is -1 but in Sparse it's
255.  I've added the Sparse mailing list to the CC.

regards,
dan carpenter

On Mon, Sep 27, 2021 at 12:09:01PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 9/27/21 11:40 AM, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > The constant-out-of-range check in clang found an actual bug in
> > vboxsf, which leads to the detection of old mount signatures always
> > failing:
> > 
> > fs/vboxsf/super.c:394:21: error: result of comparison of constant -3 with expression of type 'unsigned char' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
> >                        options[3] == VBSF_MOUNT_SIGNATURE_BYTE_3) {
> >                        ~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> This actually seems to be a clang bug though, or at least a weird
> interpretation (and different from gcc) of the C spec.
> 
> VBSF_MOUNT_SIGNATURE_BYTE_3 is defined as:
> 
> #define VBSF_MOUNT_SIGNATURE_BYTE_3 ('\375')
> 
> The C-spec:
> 
> http://port70.net/~nsz/c/c11/n1570.html#6.4.4.4p5 
> 
> Says the following:
> 
> "The octal digits that follow the backslash in an octal escape sequence are taken to be part of the construction of a single character for an integer character constant or of a single wide character for a wide character constant. The numerical value of the octal integer so formed specifies the value of the desired character or wide character."
> 
> Character constants have a type of int, so 0375
> clearly fits in the range of that.
> 
> I guess the problem is that gcc sees this as
> 
> const int VBSF_MOUNT_SIGNATURE_BYTE_3 = 0375;
> 
> Where as clang sees this as:
> 
> const int VBSF_MOUNT_SIGNATURE_BYTE_3 = (char)0375;
> 
> Which is a nice subtle incompatibility between the 2 :|
> 
> 
> With that said, the patch is fine and I have no objections
> against it:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> Although maybe it is better to actually remove any
> ambiguity and just replace the defines with:
> 
> static const u8 VBSF_MOUNT_SIGNATURE_BYTE_0 = 0000;
> static const u8 VBSF_MOUNT_SIGNATURE_BYTE_1 = 0377;
> static const u8 VBSF_MOUNT_SIGNATURE_BYTE_2 = 0376;
> static const u8 VBSF_MOUNT_SIGNATURE_BYTE_3 = 0375;
> 
> ?
> 
> Regards,
> 
> Hans
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> > fs/vboxsf/super.c:393:21: error: result of comparison of constant -2 with expression of type 'unsigned char' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
> >                        options[2] == VBSF_MOUNT_SIGNATURE_BYTE_2 &&
> >                        ~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > fs/vboxsf/super.c:392:21: error: result of comparison of constant -1 with expression of type 'unsigned char' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
> >                        options[1] == VBSF_MOUNT_SIGNATURE_BYTE_1 &&
> >                        ~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > The problem is that the pointer is of type 'unsigned char' but the
> > constant is a 'char'. My first idea was to change the type of the
> > pointer to 'char *', but I noticed that this was the original code
> > and it got changed after 'smatch' complained about this.
> > 
> > I don't know if there is a bug in smatch here, but it sounds to me
> > that clang's warning is correct. Forcing the constants to an unsigned
> > type should make the code behave consistently and avoid the warning
> > on both.
> > 
> > Fixes: 9d682ea6bcc7 ("vboxsf: Fix the check for the old binary mount-arguments struct")
> > Cc: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  fs/vboxsf/super.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c
> > index 4f5e59f06284..84e2236021de 100644
> > --- a/fs/vboxsf/super.c
> > +++ b/fs/vboxsf/super.c
> > @@ -21,10 +21,10 @@
> >  
> >  #define VBOXSF_SUPER_MAGIC 0x786f4256 /* 'VBox' little endian */
> >  
> > -#define VBSF_MOUNT_SIGNATURE_BYTE_0 ('\000')
> > -#define VBSF_MOUNT_SIGNATURE_BYTE_1 ('\377')
> > -#define VBSF_MOUNT_SIGNATURE_BYTE_2 ('\376')
> > -#define VBSF_MOUNT_SIGNATURE_BYTE_3 ('\375')
> > +#define VBSF_MOUNT_SIGNATURE_BYTE_0 (u8)('\000')
> > +#define VBSF_MOUNT_SIGNATURE_BYTE_1 (u8)('\377')
> > +#define VBSF_MOUNT_SIGNATURE_BYTE_2 (u8)('\376')
> > +#define VBSF_MOUNT_SIGNATURE_BYTE_3 (u8)('\375')
> >  
> >  static int follow_symlinks;
> >  module_param(follow_symlinks, int, 0444);
> >