Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
To:     jbhayana@google.com, jic23@kernel.org
Cc:     lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, Vasyl.Vavrychuk@opensynergy.com,
        andriy.tryshnivskyy@opensynergy.com
Subject: [PATCH v2 1/1] iio/scmi: Add reading "raw" attribute.
Date:   Mon, 27 Sep 2021 16:22:02 +0300
Message-Id: <20210927132202.17335-2-andriy.tryshnivskyy@opensynergy.com>
In-Reply-To: <20210927132202.17335-1-andriy.tryshnivskyy@opensynergy.com>
References: <20210927132202.17335-1-andriy.tryshnivskyy@opensynergy.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?f+Pv264OctAw/XLcS2VTQxsfqB5bB0HgvtzqXWgy8VhyfSEnim55lKFFCsXT?=
 =?us-ascii?Q?dMzW1xj9Pmzy5nNGNZEeXBxjNWrWbuNaR+930crznhJxwySs2+YmjmhFHYBy?=
 =?us-ascii?Q?g6SJM/Inpceg0X/KCvaNtmcE04pE1b3E2d2/M6hXMyzAOl4Z4EN1bFTKZwLk?=
 =?us-ascii?Q?J+3xmryMKUstRDtCS2i7BThx4nq9j2EouWVtNXyx/3b00b32Ftd1GCXKPSd2?=
 =?us-ascii?Q?KtddnlHCOSzCexOVKHxlKh2dPfqewxNBR2tG77kUi1r6O8ClTofDML7Rqoju?=
 =?us-ascii?Q?Drr6kNR8tTQ26tlv7pK4HGyYbbA+IiFpewjPPFMaI4Js5Pn82WhxBs5tT182?=
 =?us-ascii?Q?VRNqWtgdkAJ0nvMrfICDY9/QlT7IYcSpkbnAbDL6/AdJAk3aQnuSvOTL6Krq?=
 =?us-ascii?Q?PnGinBHN9vieGG0bR32C+4RnI7vuyaAHiQ5Tns9KRuUlqcM01sCJF0cy2vmr?=
 =?us-ascii?Q?AevlpNnFDHejzDMAQsv8maMvjY2yluqKUu+3qLbRoEtxA1aC4TeE9BeEa39N?=
 =?us-ascii?Q?4gnM+4cxrC+FeL30UtxV/S8FbwXTp4wx+K506iy7WwwfaLm3yMma0fqHec5K?=
 =?us-ascii?Q?Sr5+iPBcLZUoINssN8Vfl8/f3St6LVDS+m8XYJzNhlfT6mKUIFmIHIm4G20F?=
 =?us-ascii?Q?LtJ6UIMgujEZkZpEb5Olco0Og9xvl+DqJAWYPrk9CasTshdhR3vj/6uFiZL/?=
 =?us-ascii?Q?IAqPLFhEwWfRtkY1sCIdVuJe2A6Y+9oTA9uGqAuL6L+Gsf4HTvl2Biu3wwYR?=
 =?us-ascii?Q?dkssyXDo8zxQYffKyWJA9/tX5LE9jLQthCjdKLG4zadcZYkZjxaegbGoJieY?=
 =?us-ascii?Q?ANkiHJq0uoPwljETuNzbvTo4XmTRXms3wHnhpsjUccQZ4igq52z58M9wqQxw?=
 =?us-ascii?Q?LoiHxIG2lnnVX6N1XUe4cos9Nz0G5WK+YbTBJlcSkrRgi42Sio9CF1+cPCUd?=
 =?us-ascii?Q?RQCvYiMFUWO4WHe5Gk1BppZ0thqomOUO0GrxQIDtC5GA+hAscWPpy4/HYVtH?=
 =?us-ascii?Q?viECwZwzlihFRQxPcD3aba0xLSLBGWbKFuMGnO3Z5jaoukscnohZiRqmA0i5?=
 =?us-ascii?Q?KEQWcKUhRkaGD09BM8w+h32lotcukfoMRoLMmwaaZGOQZY63UbjHlp6VbEI8?=
 =?us-ascii?Q?CoG4sJprJFswPxIr0PQk4AIAYKItoKt+KdplkN4lL73FyCyuYScRKtEJnZLW?=
 =?us-ascii?Q?CiuuU33QAAgHmu85r4WOPieVGWzwJbyPeY+07gUHoT7rcsZnWaiXipxaX8cK?=
 =?us-ascii?Q?+YH/Otcdx87CliKDyScldii1Q62DwdBdrUmDqagAMZxWIhEdXFXnU9893VIU?=
 =?us-ascii?Q?1Ek1VWiQ8gkYPy+NSGpfuuil?=
X-OriginatorOrg: opensynergy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57bc57a2-4c2b-467e-f977-08d981b9d336
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6359.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 13:22:16.3633
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZPT/sszgA3lwBgzSo1loM9++vX2kBpK7fyZcYAjYxvErsl2hEM0C49sEj3y+j7HZojGzqTYR7ZxTpp83IFYlCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6950
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add IIO_CHAN_INFO_RAW to the mask and implement corresponding
reading "raw" attribute in scmi_iio_read_raw.

Signed-off-by: Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
---
 drivers/iio/common/scmi_sensors/scmi_iio.c | 45 +++++++++++++++++++++-
 1 file changed, 44 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/common/scmi_sensors/scmi_iio.c b/drivers/iio/common/scmi_sensors/scmi_iio.c
index 7cf2bf282cef..c6a9dc6ad140 100644
--- a/drivers/iio/common/scmi_sensors/scmi_iio.c
+++ b/drivers/iio/common/scmi_sensors/scmi_iio.c
@@ -286,6 +286,9 @@ static int scmi_iio_read_raw(struct iio_dev *iio_dev,
 	struct scmi_iio_priv *sensor = iio_priv(iio_dev);
 	s8 scale;
 	int ret;
+	int err;
+	u32 sensor_config;
+	struct scmi_sensor_reading readings[SCMI_IIO_NUM_OF_AXIS];
 
 	switch (mask) {
 	case IIO_CHAN_INFO_SCALE:
@@ -300,6 +303,45 @@ static int scmi_iio_read_raw(struct iio_dev *iio_dev,
 	case IIO_CHAN_INFO_SAMP_FREQ:
 		ret = scmi_iio_get_odr_val(iio_dev, val, val2);
 		return ret ? ret : IIO_VAL_INT_PLUS_MICRO;
+	case IIO_CHAN_INFO_RAW:
+		sensor_config = FIELD_PREP(SCMI_SENS_CFG_SENSOR_ENABLED_MASK,
+					   SCMI_SENS_CFG_SENSOR_ENABLE);
+		err = sensor->handle->sensor_ops->config_set(
+			sensor->handle, sensor->sensor_info->id, sensor_config);
+		if (err) {
+			dev_err(&iio_dev->dev,
+				"Error in enabling sensor %s err %d",
+				sensor->sensor_info->name, err);
+			return err;
+		}
+
+		err = sensor->handle->sensor_ops->reading_get_timestamped(
+			sensor->handle, sensor->sensor_info->id,
+			sensor->sensor_info->num_axis, readings);
+		if (err) {
+			dev_err(&iio_dev->dev,
+				"Error in reading raw attribute for sensor %s err %d",
+				sensor->sensor_info->name, err);
+			return err;
+		}
+
+		sensor_config = FIELD_PREP(SCMI_SENS_CFG_SENSOR_ENABLED_MASK,
+					   SCMI_SENS_CFG_SENSOR_DISABLE);
+		err = sensor->handle->sensor_ops->config_set(
+			sensor->handle, sensor->sensor_info->id, sensor_config);
+		if (err) {
+			dev_err(&iio_dev->dev,
+				"Error in enabling sensor %s err %d",
+				sensor->sensor_info->name, err);
+			return err;
+		}
+		/* Check if raw value fits 32 bits */
+		if (readings[ch->scan_index].value < INT_MIN ||
+		    readings[ch->scan_index].value > INT_MAX)
+			return -ERANGE;
+		/* Use 32-bit value, since practically there is no need in 64 bits */
+		*val = (int)readings[ch->scan_index].value;
+		return IIO_VAL_INT;
 	default:
 		return -EINVAL;
 	}
@@ -381,7 +423,8 @@ static void scmi_iio_set_data_channel(struct iio_chan_spec *iio_chan,
 	iio_chan->type = type;
 	iio_chan->modified = 1;
 	iio_chan->channel2 = mod;
-	iio_chan->info_mask_separate = BIT(IIO_CHAN_INFO_SCALE);
+	iio_chan->info_mask_separate =
+		BIT(IIO_CHAN_INFO_SCALE) | BIT(IIO_CHAN_INFO_RAW);
 	iio_chan->info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SAMP_FREQ);
 	iio_chan->info_mask_shared_by_type_available =
 		BIT(IIO_CHAN_INFO_SAMP_FREQ);
-- 
2.17.1