Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4014327pxb; Mon, 27 Sep 2021 07:38:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLoIHOV2xQItDft8p0YuW2qoX+I2IRuupPW+9W3ste1ylt7tt+3JF3mRNTnWR/wmTFs+kx X-Received: by 2002:a50:d945:: with SMTP id u5mr242932edj.136.1632753496789; Mon, 27 Sep 2021 07:38:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632753496; cv=none; d=google.com; s=arc-20160816; b=yvOcJe4pJflO4twq2EYWiEQJ7ADWWjUXh7X6lAn1mhWha3onoZpWclLp4F0Xv5k+7c qrZ5X0OHYeSrBL7ubn96SIcXonhE/qkm2pjhTmnxFs6Ec8Zo14oex0AL1Dat+NOKTivn Uj8aHSFowQbFqx14SY7bAQx2e08nORqtyLpF0Ew03SRrQq1O1z3kCpUQE43VYZqw24VL rEskWDtyK1Cfgplz4KwsPghnrtys9N9YtgTVEaSjllRhRNz3YrA7Pmh/u+7sQdmbglJp LuV9FppJlm50p1KFqD8oMJui5Os7r1/TeZrRxd2ypH0qJ7ZefvFNsrN0HfRjaHYY8frV h6kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=p/ihu8msFz+EyYA+lzoyRImdv9Ww85GzPMhVGKFYUOY=; b=qeY1fcFUmso25oJZhR73Af/naBUBYz189lHTqwPO7RL0yCPvzhn/kLZqioUnzjKF56 4BLD+XWESSGiAjyX/k1O/FkvMG8Iu0qT+2gkThl9wFYCD1iRr8aJ9CiH3hUCcjFNqODW /oEtMcjeQIhZFTprskoUC/OOgzgE1PWhid97ldpquAvugtgII/xQhjTw6EaVfSpasrMP 6I7g+IqxdV238ZcsKbQwK+n6/mM3GTfAVTY+m3HPZBeUFJ78bAXEwwx2hi0+zPmUZNt6 6WTQ35b/ZeRXlEzzrH33eGbE4/iByC8n1auazoJ4JErnmkBTiPh4Edod6CJkOthydZ9w djAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codesynthesis.com header.s=mail1 header.b=kjKFhs7Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d16si17762992edz.500.2021.09.27.07.37.53; Mon, 27 Sep 2021 07:38:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@codesynthesis.com header.s=mail1 header.b=kjKFhs7Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234891AbhI0OgK (ORCPT + 99 others); Mon, 27 Sep 2021 10:36:10 -0400 Received: from codesynthesis.com ([188.40.148.39]:48670 "EHLO codesynthesis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234816AbhI0OgG (ORCPT ); Mon, 27 Sep 2021 10:36:06 -0400 Received: from brak.codesynthesis.com (197-255-152-207.static.adept.co.za [197.255.152.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by codesynthesis.com (Postfix) with ESMTPSA id 52D8660394; Mon, 27 Sep 2021 14:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codesynthesis.com; s=mail1; t=1632753267; bh=p/ihu8msFz+EyYA+lzoyRImdv9Ww85GzPMhVGKFYUOY=; h=Date:From:To:Subject:Message-ID:MIME-Version:From; b=kjKFhs7ZGVIogd7UMSNjynLfZALTbKfroTp7SWwYsTPudidXwUZ6ttURTYlD1DY+z EMppxwZCdWTfoYWvVWmb1cmIW11Zk8u8vDjHtcdBIaet2XqSJvyYAO2gOR47eD/BxB 1kJKAnCPbMoBMmh0pYveKFGXrHMcD8MAik3ZoTBsvQjIWj7VBC0Z5eUFM02WnpYm19 PzfxiGzQNv5Knx5woXm8ColX8BD6wvRpgnJNpdHJwDmUt+h11m0TQOVbtXtYp8Z9kz 9J0XQKikP9DV8FtAid9pYcoB1tpt7MA1NycChg+PpIIa/XMJIiEOMCGKKVQiGY7Deq grZuS9skcJy3A== Received: by brak.codesynthesis.com (Postfix, from userid 1000) id B40DE1A800C4; Mon, 27 Sep 2021 16:34:22 +0200 (SAST) Date: Mon, 27 Sep 2021 16:34:22 +0200 From: Boris Kolpackov To: Richard Weinberger Cc: masahiroy , linux-kernel , linux-kbuild Subject: Re: [PATCH 2/2] kconfig: Deny command substitution in string values Message-ID: References: <20210920213957.1064-1-richard@nod.at> <20210920213957.1064-2-richard@nod.at> <1402570794.96583.1632295660867.JavaMail.zimbra@nod.at> <1942256037.97524.1632327460626.JavaMail.zimbra@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1942256037.97524.1632327460626.JavaMail.zimbra@nod.at> Organization: Code Synthesis User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Richard Weinberger writes: > Yes. auto.conf is .config post processed. > This is exactly where my mitigation takes place. No, sym_escape_string_value() is called by conf_write_symbol() which in turn is called from conf_write() and conf_write_defconfig() (used to write .config files) besides conf_write_autoconf() (used to write auto.conf).