Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4056061pxb; Mon, 27 Sep 2021 08:29:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgMOzTi3voTep03lJyzShOsnhdeIe8kluEYQSbX2yAE6hiFYccvSpE2mn8Iun8R8jBK1PB X-Received: by 2002:a17:902:c789:b0:13c:a112:6383 with SMTP id w9-20020a170902c78900b0013ca1126383mr496397pla.42.1632756595987; Mon, 27 Sep 2021 08:29:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632756595; cv=none; d=google.com; s=arc-20160816; b=CEGImkmLDwidMvrRYhsWGpX8e9twb9q/BUtZHUrTSdyfwKpJ6z/54NHn3w3zpC7aa3 0ZpjBgWgEU1NzPDN74VQhMY1LgyTuVX7Pp3AooBtf+b9JwzdSmvViaAvxsTkTUcWX8Wj 2FMkoyVpkzLIaBGO8aqnehmvvuOotEG5cbgk/8TxL5iFeDDb16sYUJJVxGad0WheJ2Ff 6lsk0BwJNtm6ZMg+imqBWjl0Vs5J5ifOkzaHeXvt0TCm1Yq7B73uFmN5LEpdOVBIkVWU R90R1A8zUCYtpWqPwaQp4xjCwonFC8ENRoy/8cgwT7+LQlS+l9KD4/CWP2FAoyh+D8Ni SD1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=Cnx+3RCHSHIUw9wDzr7lgI5tPz3eJ7pKJPEA6FPXOms=; b=VJ8Do4IlfJk8BglF/0yBCTca/mz8oJUZtK79D8zqSxlprqddxGvG52MMKIh5HVqrGO WvR11mB7Meiux542tMEDvjc1vvGOKXvNDln01xMWtfiVbunKn3S5Q1fLsFoB1iPSCtV7 wjzRIRta5YKTZkIwBGJGee/LaN0NRMUxLJ3sSO7xQe8mIRKQCx5K35ad3OGUTzqvhhwo dNC9yleDkdcwD02QgAv48nPM17u9eKFvomZbkgpbh+r9mHLAf4Q4JIKOaxzqXAwwElko WEti07ZWv0EsThvIKcHGKoDr8AomMQJ23K8YDAtuR7h5NKXsO8RJxNktGKdgn3qusLNf xvcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i12si22128010plb.369.2021.09.27.08.29.39; Mon, 27 Sep 2021 08:29:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235246AbhI0P3O (ORCPT + 99 others); Mon, 27 Sep 2021 11:29:14 -0400 Received: from www62.your-server.de ([213.133.104.62]:39748 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235163AbhI0P2Q (ORCPT ); Mon, 27 Sep 2021 11:28:16 -0400 Received: from sslproxy03.your-server.de ([88.198.220.132]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mUsWR-000FdL-9B; Mon, 27 Sep 2021 17:26:27 +0200 Received: from [85.1.206.226] (helo=linux.home) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUsWQ-000R5W-Se; Mon, 27 Sep 2021 17:26:26 +0200 Subject: Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data To: Ilya Leoshkevich , Tiezhu Yang , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexei Starovoitov , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh Cc: Yauheni Kaliuta , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li References: <1632726374-7154-1-git-send-email-yangtiezhu@loongson.cn> From: Daniel Borkmann Message-ID: Date: Mon, 27 Sep 2021 17:26:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.3/26305/Mon Sep 27 11:04:42 2021) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/27/21 1:33 PM, Ilya Leoshkevich wrote: > On Mon, 2021-09-27 at 15:06 +0800, Tiezhu Yang wrote: >> Make sure to free jit_data through kfree() in the error path. >> >> Fixes: 1c8f9b91c456 ("bpf: s390: add JIT support for multi-function >> programs") >> Signed-off-by: Tiezhu Yang >> --- >> >> RESEND due to the following reason: >> [Can not connect to recipient's server because of unstable >> network or firewall filter. rcpt handle timeout, last handle >> info: Can not connect to vger.kernel.org] >> >>  arch/s390/net/bpf_jit_comp.c | 2 +- >>  1 file changed, 1 insertion(+), 1 deletion(-) > > Nice catch, thanks! > > Acked-by: Ilya Leoshkevich Given s390, I presume this would be routed to Linus via Heiko/Vasily? Thanks, Daniel