Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6151E490.4020403@gmail.com>
Date:   Mon, 27 Sep 2021 18:34:40 +0300
From:   Eli Billauer <eli.billauer@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7
MIME-Version: 1.0
To:     Arnd Bergmann <arnd@arndb.de>
CC:     gregkh <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] char: xillybus: Eliminate redundant wrappers to DMA related
 calls
References: <20210926072925.27845-1-eli.billauer@gmail.com> <CAK8P3a3C+a9-hg4nbFFHR4i6e5HmchD4ZgmijJLs5RLBaCBsBQ@mail.gmail.com>
In-Reply-To: <CAK8P3a3C+a9-hg4nbFFHR4i6e5HmchD4ZgmijJLs5RLBaCBsBQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/09/21 10:47, Arnd Bergmann wrote:
>> +static void xilly_sync_for_device(struct xilly_endpoint *ep,
>> >  +                                 dma_addr_t dma_handle,
>> >  +                                 size_t size,
>> >  +                                 int direction)
>> >  +{
>> >  +       if (ep->make_sync_calls)
>> >  +               dma_sync_single_for_device(ep->dev, dma_handle,
>> >  +                                          size, direction);
>> >  +}
>>
> These wrappers should not even be needed. When the device is
> marked as coherent in DT, the dma_sync_*() calls are supposed
> to do nothing, in a relatively efficient way. I would not expect
> the extra conditional to give you any measurable performance
> benefit over what you get normally, and it should not make a
> functional difference either.
>
> Can you remove the inlines and the ->make_sync_calls flag?
>
>
Thanks, I had no idea that the sync functions neutralize themselves this 
way. That is, since commit 591c1ee465ce ("of: configure the platform 
device dma parameters") from back in April 2014.

So indeed, I shall remove the the @make_sync_calls entry and related 
wrapper functions, and resubmit an second version of this patch.

Thanks again,
    Eli