Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about
 jit_data
To:     Daniel Borkmann <daniel@iogearbox.net>,
        Ilya Leoshkevich <iii@linux.ibm.com>,
        Tiezhu Yang <yangtiezhu@loongson.cn>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc:     Yauheni Kaliuta <yauheni.kaliuta@redhat.com>,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xuefeng Li <lixuefeng@loongson.cn>
References: <1632726374-7154-1-git-send-email-yangtiezhu@loongson.cn>
 <e9665315bc2f244d50d026863476e72e3d9b8067.camel@linux.ibm.com>
 <c02febfc-03e6-848a-8fb0-5bd6802c1869@iogearbox.net>
From:   Christian Borntraeger <borntraeger@de.ibm.com>
Message-ID: <0cc48f4d-f6c0-ab11-64b0-bc219fbfe777@de.ibm.com>
Date:   Mon, 27 Sep 2021 17:58:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <c02febfc-03e6-848a-8fb0-5bd6802c1869@iogearbox.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


Am 27.09.21 um 17:26 schrieb Daniel Borkmann:
> On 9/27/21 1:33 PM, Ilya Leoshkevich wrote:
>> On Mon, 2021-09-27 at 15:06 +0800, Tiezhu Yang wrote:
>>> Make sure to free jit_data through kfree() in the error path.
>>>
>>> Fixes: 1c8f9b91c456 ("bpf: s390: add JIT support for multi-function
>>> programs")
>>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>>> ---
>>>
>>> RESEND due to the following reason:
>>> [Can not connect to recipient's server because of unstable
>>> network or firewall filter. rcpt handle timeout, last handle
>>> info: Can not connect to vger.kernel.org]
>>>
>>>   arch/s390/net/bpf_jit_comp.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Nice catch, thanks!
>>
>> Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>

Makes sense.
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>

> 
> Given s390, I presume this would be routed to Linus via Heiko/Vasily?

Yes, applied to the s390 tree.

Interestingly enough b4 cannot find the patch email on lore.
Looks like Tiezhu Yang has indeed connection issues with vger.
CC Konstantin, in case he knows something.