Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <L9900R.05DOH2MOR3V93@crapouillou.net>
Date:   Mon, 27 Sep 2021 18:18:25 +0200
Cc:     Paul Boddie <paul@boddie.org.uk>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        linux-mips <linux-mips@vger.kernel.org>, list@opendingux.net,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <044C92DA-EF88-4738-BF60-885906588408@goldelico.com>
References: <20210922205555.496871-1-paul@crapouillou.net>
 <4366739.KZ8Jxz7LyS@jason> <EKJXZQ.6VJ0UDHV3T3W@crapouillou.net>
 <2094991.ScV2v2meXk@jason> <HU700R.NAHL5IU3NRE81@crapouillou.net>
 <96585ED9-B707-4AF1-8417-E03DE6414965@goldelico.com>
 <L9900R.05DOH2MOR3V93@crapouillou.net>
To:     Paul Cercueil <paul@crapouillou.net>
Precedence: bulk

Hi Paul,

> Am 25.09.2021 um 21:39 schrieb Paul Cercueil <paul@crapouillou.net>:
>=20
>=20
>=20
> Le sam., sept. 25 2021 at 21:26:42 +0200, H. Nikolaus Schaller =
<hns@goldelico.com> a =C3=A9crit :
>> Hi Paul,
>>> Am 25.09.2021 um 21:08 schrieb Paul Cercueil <paul@crapouillou.net>:
>>> Hi Paul & Nikolaus,
>>> If you spent some time debugging the issue
>> we did ...
>=20
> By saying that you didn't debug,

We did - but sometimes you don't see the wood for the trees.

> (null) means you're printing a NULL pointer. So I could see that =
hdmi->next_bridge was NULL.

I remember we did find this, but did not understand that it should be =
initialized by dw-hdmi.
And because we though that dw-hdmi has it its own connector, it is ok =
that way.

> The place that sets it is dw_hdmi_parse_dt, which will return early =
with code 0, before next_bridge is set, if plat_data->output_port =3D=3D =
0, which was your case.

Well, we were still at 5.14 when we did these initial attempts to use =
hdmi-connector with synopsys.
Back then, there was no dw_hdmi_parse_dt and no output_port.

IAW: we did not even have a chance to make it work on top of 5.14 the =
hdmi-connector way. And were sucessful.

I just noticed this when trying to backport the last puzzle piece...

Well, it is always difficult to hit a moving target.

> Since your hdmi-connector is wired at port #1, then .output_port =
should be 1 as well.

Anyways it works now for 5.14.8 (our internal test) and 5.15-rc3.

And v4 of the jz4780 hdmi stuff will follow.

BR and thanks,
Nikolaus