Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4116670pxb; Mon, 27 Sep 2021 09:43:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrhlUJ4nFkzwIm6aKc1ctecfOEVdjHVIxUyv6GLuuVn6WQfbm3C9qgbOAwCxsEReCctl2/ X-Received: by 2002:a17:906:f15:: with SMTP id z21mr1061098eji.177.1632760990074; Mon, 27 Sep 2021 09:43:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632760990; cv=none; d=google.com; s=arc-20160816; b=ZI90tOnQg9TGxCQk3GaBDU45kJsOFtjkviRVQUNzcoF8m7+ddAJNvkpQWK/ommuUa5 sfvkmyrqLByajutnFYuXhv0FKcezMuR9UkuxMg3605N3Gvcxu8k3vmQXqLzgCKVEOJaK zrR2lMp3tHvGSLaAgDf4EI7Zqtsx9Y8wdHNCSlQCsLWjeBl+PePEPoT1TbMC0xKuUYMb 2rpwDkC4o9H66BjJPjUqKm3MvepPPXYPA/4WU05O/IWWFiCR5nZ2T6A3uPWeKSpsVXgA zB7VIFLOAlwytxaGvMvgCvtfaGRU3tkvnAuAcFN9DbvmyhFYQf4Q1iPAcnem3a0Q7NOe 1uDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4KirTB7VY9SdAqVf3vHSLLAh3zhrPlo2Qk48uTXZukk=; b=DDsKWowjVTlXDncmP6Ybr8mpln+W4ZnxV+7zVJbpBjHBe4ZxX64TZIiY2VBKolWpwW Eqphl1vEE0Je0sLJDTj+wUPSucAQS9yLPTVVLcZaWFIL1q49vgmOpEWSss8NCSRzJlnD zNpzNi+KKBbASrE8Ik3qCWUds8QLPdltvCybfmdPLt8hSZmYrbyhZpvFUyIxcBoNMAfD ohKWu4iDTQewZ0VCcOJq9+opDbnKUZv6iVP/dQEYGVvrUXPF69OoHT+dCQ/yhFwegVVW gaPgGE2gULvjuFDkyg5c7ic2GKlG6eYWMMtRO0tEoNsfEenD11o2baDFnIv6e6FAmEYG y/CA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=nstZx9H3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a11si7646806edv.67.2021.09.27.09.42.46; Mon, 27 Sep 2021 09:43:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=nstZx9H3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235765AbhI0Qk2 (ORCPT + 99 others); Mon, 27 Sep 2021 12:40:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235673AbhI0QkC (ORCPT ); Mon, 27 Sep 2021 12:40:02 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08E9AC061575; Mon, 27 Sep 2021 09:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=4KirTB7VY9SdAqVf3vHSLLAh3zhrPlo2Qk48uTXZukk=; b=nstZx9H3ZfJEiJdzZJzzserJt0 yan/MIjMY9/u3dwvJFJZf0WfcoxpZRpNDFpTShmLkF4XLJpJ3b++tAk2vCHBIx+8OlZnjzWioulLT yKcIowgZgKx/FSuyxUKEkG+30ufftWHhrApL8+E1KOdf7lcYIleqR6KEw89VNd+xkAHa8pLhm9icr QBUASh+a+F2I0YmhKNS1lxGf+LMt0UKRXiBk02y2LdQW7AdoKd+jwoLIMjca1gYGpfrM1bIgzU3ke I8ZL7dI+RmHNUR5kt+uScy53jWHrLsBA0CH0Rm//UE+Qr5nEAoLLHhG8akU5ZBBSx9QP50ahV1qgB YJzUOjSQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUtdm-003OSP-To; Mon, 27 Sep 2021 16:38:06 +0000 From: Luis Chamberlain To: tj@kernel.org, gregkh@linuxfoundation.org, akpm@linux-foundation.org, minchan@kernel.org, jeyu@kernel.org, shuah@kernel.org Cc: bvanassche@acm.org, dan.j.williams@intel.com, joe@perches.com, tglx@linutronix.de, mcgrof@kernel.org, keescook@chromium.org, rostedt@goodmis.org, linux-spdx@vger.kernel.org, linux-doc@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 07/12] fs/kernfs/symlink.c: replace S_IRWXUGO with 0777 on kernfs_create_link() Date: Mon, 27 Sep 2021 09:38:00 -0700 Message-Id: <20210927163805.808907-8-mcgrof@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210927163805.808907-1-mcgrof@kernel.org> References: <20210927163805.808907-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If one ends up extending this line checkpatch will complain about the use of S_IRWXUGO suggesting it is not preferred and that 0777 should be used instead. Take the tip from checkpatch and do that change before we do our subsequent changes. This makes no functional changes. Signed-off-by: Luis Chamberlain --- fs/kernfs/symlink.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/kernfs/symlink.c b/fs/kernfs/symlink.c index c8f8e41b8411..19a6c71c6ff5 100644 --- a/fs/kernfs/symlink.c +++ b/fs/kernfs/symlink.c @@ -36,8 +36,7 @@ struct kernfs_node *kernfs_create_link(struct kernfs_node *parent, gid = target->iattr->ia_gid; } - kn = kernfs_new_node(parent, name, S_IFLNK|S_IRWXUGO, uid, gid, - KERNFS_LINK); + kn = kernfs_new_node(parent, name, S_IFLNK|0777, uid, gid, KERNFS_LINK); if (!kn) return ERR_PTR(-ENOMEM); -- 2.30.2