Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] locking/rwsem: Use rcu_read_lock_sched to simplify
 codes
To:     Waiman Long <llong@redhat.com>, peterz@infradead.org,
        mingo@redhat.com, will@kernel.org, boqun.feng@gmail.com
Cc:     linux-kernel@vger.kernel.org
References: <20210926101624.2460704-1-yanfei.xu@windriver.com>
 <20210926101624.2460704-2-yanfei.xu@windriver.com>
 <4e4c9adf-5444-e331-fefa-0d72aea8ba57@redhat.com>
From:   "Xu, Yanfei" <yanfei.xu@windriver.com>
Message-ID: <0c9507f6-a28c-44db-ea80-6b31847b2504@windriver.com>
Date:   Tue, 28 Sep 2021 00:41:14 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <4e4c9adf-5444-e331-fefa-0d72aea8ba57@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGs4MnppalhqLy81Y2JjSDBieTllREtlTEsvYUJHZnlYL1RSVXdqaGQ1Znpi?=
 =?utf-8?B?TjNBMzFrSFVTN3VwcTIySEkzS081RHFIcVJaOHJwV1dPcU5LQnQzcTdPbjdS?=
 =?utf-8?B?cDZvUUc0dzIwZGFEQ0xzSU9vRmJXcDFBK2xXSlFuVm16Z1ZVdlJQSGlQSmpv?=
 =?utf-8?B?TTJFbVYyOCsrSGFaZDkzRGVqWlA3N1pTU092NkZ1N2xZUmZMT2ljcTlPcGpv?=
 =?utf-8?B?V2RFOTZZNk9sVldGTWJCQXpJdGNidnBBUmR4bWNja2lDNHM0aGZPeWVCZDRq?=
 =?utf-8?B?R2h3TUNhRUdWcURWRXcvVnlnSnVmRDRtRFM1V0NtdkQ5WlZOeklRUFp0NWRt?=
 =?utf-8?B?V3ZySGpKSWlNYzljNE5vSk5VM0lyT2tYVld3djhFd2hkcUw1bFpmNS9EQm9l?=
 =?utf-8?B?RDNuSFY4TTMrQU9yZVd2bjhjaDMvZ28xWW9QQ0p1Y2d6RTZYV3dtckxPWDNR?=
 =?utf-8?B?L2hqK0tMemN2UzFiNHNwR2I0SjNwVWtUR3YxWTBiVGhVSWNTaUdBSWh3YzBE?=
 =?utf-8?B?cFRidmZxTmRqZnM5QVlmQzZNdkR4UWJVOEg2a1gyTjhyMnJpTkU0eFdQOHZr?=
 =?utf-8?B?bGtBcDlLV0NnYTRrY3pvKzdqWEhLVjRDVXdpNUJVREtVUkFGbndmQlNvTm5t?=
 =?utf-8?B?ZEF6REJwYWRqL1pZTGRHVURxdnlsWjBWRWQrcHkvOW1Hc043Y1huMThabWNO?=
 =?utf-8?B?NE1lWnFtdTc0T212VHZOOTFvWEVoQlRyNmNzUWcrdW1OL05IYWFlSFZPbFJI?=
 =?utf-8?B?MnZ5dThDdnE1N1dndkszNzhnclBPMDE0dVJudmJQdWpLUGlVeWYwWm9VcnpJ?=
 =?utf-8?B?eDZwS2pLUVNqNUYrSXQ4aFo0MkxFOWdlaytBd2dBMk0vTFZuTEVjMUYwaGZq?=
 =?utf-8?B?S0s0eVUzQ040SzZhQ0h1dDRNRFNrNVQ3OE5OamVkREg2NHRrcXpKc1JNdTUv?=
 =?utf-8?B?dmsrYmNZMHBiRlJkVWFjclFiRWFCLzdINVZhM1BYdVJvSlZLMFFWWmhHV3pH?=
 =?utf-8?B?amFZN01XMGc0UmFhR0M4amIrMUtZYmMwcmdCQWpGNUo3dlJnNU5KVHdOYUd6?=
 =?utf-8?B?RWRGVFNVTFZUOEdRN043Z0VSUkc2MEYwcmYxNDhmU0FEcEJuRkVRNVFxcWg5?=
 =?utf-8?B?VENiZG8xNjNhZmFFaXEzM09NREtmako1eURoUkhDRktHU2VRWXJYZHJxZk1j?=
 =?utf-8?B?WnNDcHA4TGJNdDBoYjhuSW1XOGIrTit2MmFZaHE4SjdZQ1hDb1NSU08yVW9Y?=
 =?utf-8?B?cFlvQnQ0T3QyM0EraW9HS3hLU3VYclM3dW5EbFhZdnBiT1dBV2VPcldXcVJx?=
 =?utf-8?B?RnUzWHFrZzJxb1BsUWtUd25EMld2eXZVd29VVzAvdk1IdytFZnBjVXhxbFli?=
 =?utf-8?B?VWt3V3dhS0t3ZDV2VytHQ2VNaFpWWUV0eE9tZzNmN2Ewa3N0M2NKZkRIQnNr?=
 =?utf-8?B?Q3hlS0crK0tjdHlQdCtEQkwxZzdkVldVVkxkcGVlNlU4MWRPR2p3OEFZYWJF?=
 =?utf-8?B?RWNiWTU5a2tkYm9aTTcxa21uK1JPUENaL2FjUi8xNWg1TG5WY0FhZXp0SlpE?=
 =?utf-8?B?akRLeFNSUWkvVWxSTGdZQkswd1ZYTVNrQzBxRmhIT1QyMlJNWUZlWGZhVlpM?=
 =?utf-8?B?ejJLaExyUjArMDJCYmpwMERyNXc0YmczbXQ0Zyt4Q0QrdHRmR3JPbzhqSmRD?=
 =?utf-8?B?WHl4dStZdkRKMno0cGlNeHUxRUFjaTFLUWkrc3l5K3ZicldON0lQLzlBRlBE?=
 =?utf-8?Q?AdSossZMegsrv+cm+oJRjzrHl4yqAFd9BxQmh+B?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4f86827-2241-425a-30db-08d981d5a427
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 16:41:23.4064
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KO6ZsYpnv6T7MtMMMHiIbvxPrYiUuw5nfgmD5aFXwMYscQpOtNW/2eHjM9ZG9vIRcNBOtnyXbiDlYUqaxY84ow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4721
X-Proofpoint-ORIG-GUID: 06TCNvpLC25atjudk0XKjFQ_ZZQENQe1
X-Proofpoint-GUID: 06TCNvpLC25atjudk0XKjFQ_ZZQENQe1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-09-27_06,2021-09-24_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 mlxlogscore=999 clxscore=1015 suspectscore=0 mlxscore=0 bulkscore=0
 priorityscore=1501 phishscore=0 spamscore=0 impostorscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2109270113
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/27/21 3:22 AM, Waiman Long wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> On 9/26/21 6:16 AM, Yanfei Xu wrote:
>> Use rcu_read_lock_sched to simplify the codes, and it also saves
>> some cycles of handling rcu nesting counter.
>>
>> Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
>> ---
>>   kernel/locking/rwsem.c | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c
>> index 000e8d5a2884..7afadfe02286 100644
>> --- a/kernel/locking/rwsem.c
>> +++ b/kernel/locking/rwsem.c
>> @@ -616,8 +616,7 @@ static inline bool rwsem_can_spin_on_owner(struct 
>> rw_semaphore *sem)
>>               return false;
>>       }
>>
>> -     preempt_disable();
>> -     rcu_read_lock();
>> +     rcu_read_lock_sched();
>>       owner = rwsem_owner_flags(sem, &flags);
>>       /*
>>        * Don't check the read-owner as the entry may be stale.
>> @@ -625,8 +624,7 @@ static inline bool rwsem_can_spin_on_owner(struct 
>> rw_semaphore *sem)
>>       if ((flags & RWSEM_NONSPINNABLE) ||
>>           (owner && !(flags & RWSEM_READER_OWNED) && 
>> !owner_on_cpu(owner)))
>>               ret = false;
>> -     rcu_read_unlock();
>> -     preempt_enable();
>> +     rcu_read_unlock_sched();
>>
>>       lockevent_cond_inc(rwsem_opt_fail, !ret);
>>       return ret;
> 
> I don't think there is any performance gain with this change. I would
> prefer the original code that is more readable as some people may not
> know rcu_read_lock_sched() will disable preemption if they don't look
> into it.
> 

OK, thanks for comments.

Yanfei

> Cheers,
> Longman
>