Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Sep 2021 13:53:52 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Doug Ledford <dledford@redhat.com>,
        Aharon Landau <aharonl@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Gal Pressman <galpress@amazon.com>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, Maor Gottlieb <maorg@nvidia.com>,
        Mark Zhang <markzhang@nvidia.com>,
        Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
        Mustafa Ismail <mustafa.ismail@intel.com>,
        Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
        netdev@vger.kernel.org, Potnuri Bharat Teja <bharat@chelsio.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Selvin Xavier <selvin.xavier@broadcom.com>,
        Shiraz Saleem <shiraz.saleem@intel.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: Re: [PATCH rdma-next v1 04/11] RDMA/counter: Add an is_disabled
 field in struct rdma_hw_stats
Message-ID: <20210927165352.GA1529966@nvidia.com>
References: <cover.1631660727.git.leonro@nvidia.com>
 <97ef07eab2b56b39f3c93e12364237d5aec2acb6.1631660727.git.leonro@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <97ef07eab2b56b39f3c93e12364237d5aec2acb6.1631660727.git.leonro@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Jvu8T0EZ10+LS+J81aEVMi/E2gHFo/xKu/ND/JkLEMRboij0Cc8zlmVRkYlG?=
 =?us-ascii?Q?ptHKRKp1+he3F76jhKKYvcRQDUQpWj1VCwyDxFnnwQvtXZk5VvDwxgZz9MqL?=
 =?us-ascii?Q?XH1FVmglDga13xQWMtPHkwmeoYXENyLeZYedJWNxkpVEPjVN/cpFeOYWcvxv?=
 =?us-ascii?Q?loccCTjkl2rJu5lf2xPPZ2GjKTkuCWeSrWV3gz1zxXicDfQyGScnC9D9obVB?=
 =?us-ascii?Q?jpzzyRxWmRlsyNWQLyMMciZXh7CvMwcMaSDwXExII5pkd7ztRwm+kwIEmtAP?=
 =?us-ascii?Q?+y5NjZBE7S9VLB9bZ8+uy7edk62wqQeaqRvACKN6y2AP0Vnoc6DDlyR/wcAz?=
 =?us-ascii?Q?d3YDRAymp9uvvBtUw9n31Hmw8/gBwms+s7CfD4Ty3DpGfZ3zro52iaEdtLRM?=
 =?us-ascii?Q?EJmem6wTJ2woMGv/N9TcVWrlbYiR/ZCoTMI3yefMb4V/gwFGsrunLu76zJ08?=
 =?us-ascii?Q?gMXak+LO38mjUxJQ6sJwW3n3X1xOqk/EMGiSl1VJLkPF9p3/p8u4V5oUmIC1?=
 =?us-ascii?Q?XgQKc8nyg8alXHMi7GbH0IeBgFWEzAoy2cds7n1w93H7SMXjR0Xz/BMNCCAf?=
 =?us-ascii?Q?87RdlMUOTC6tbJQ2ym13Xhm1jKFzy7F2kppVs7fQVGs9RLfKXw2f9pTqHijK?=
 =?us-ascii?Q?KmwiS3b+wgYj/Im8fMxPCAt1tQ86K9m+7hJ/kZdHxBDVFXZY8xdYqlVkNsAC?=
 =?us-ascii?Q?Z+eNXRG1RdrbpcStr6TQXax4x6PN+KWZbo+CLGz2Qcc4iL8Sb4PuISx4bC+d?=
 =?us-ascii?Q?N/7Uz5qqNjlHN57GXidtZp1WX2AHYaCWz0WH2M7Ah62giBBHw3ZtMUBOPw7H?=
 =?us-ascii?Q?g9380n7t2Qs8CU02ns9+8c6F5F7j6tDtke/TbMH5xQ/AcmkaJ10aSkYgVmKk?=
 =?us-ascii?Q?I8ftdIgpUAgjlILcmbVz5JaANtbRp7GFZL9gF9+AUl/pEKTSdno57mCZei+u?=
 =?us-ascii?Q?9cHzFVf03Hj4Ua3PdTnn6cnvDt+xiEEL+Y6T8vbkgr2PXycCKn+pRQHXWCHz?=
 =?us-ascii?Q?gDLA+yJ7IFyFUhGtnOLk8EqLG2XjGn2rAVbkzJzqCyomh/GDBTEZszk/ooxA?=
 =?us-ascii?Q?cNLl/1vXDldCAQ6y/nWlfPOb93QSq30Z/Bf+SxTjUBB3FKEag8gWHtKSPxGs?=
 =?us-ascii?Q?Kcvn07JruqO6Mk88w5JAqfMOOlv65SYZeFsheX5uiJhcFNE+P6gdlJMdx3AU?=
 =?us-ascii?Q?pWjDK9922PLYTqootRXUmAmHz1ZV3uhHzTWHmpK68Ge1QZA+WKbI6BXGA4nq?=
 =?us-ascii?Q?XPqXxUtXepx0e/dz2fqjY/GF9DH7CyiYjEb8nDh105kP/IPjaztclSrWStQR?=
 =?us-ascii?Q?NLRAIy+feeo6AcUeAnm2VV9f?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3c0b40d-bdc8-473d-7326-08d981d76315
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 16:53:53.2247
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: egSF3UvrEk/0R3sZG3rMdiXivdbMO1jQwxLJGTn/2kvBc2i8R6xisdK8iZaMm3MR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5176
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 15, 2021 at 02:07:23AM +0300, Leon Romanovsky wrote:

> diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
> index 3f6b98a87566..67519730b1ac 100644
> +++ b/drivers/infiniband/core/nldev.c
> @@ -968,15 +968,21 @@ static int fill_stat_counter_hwcounters(struct sk_buff *msg,
>  	if (!table_attr)
>  		return -EMSGSIZE;
> @@ -601,11 +604,20 @@ static inline struct rdma_hw_stats *rdma_alloc_hw_stats_struct(
>  	if (!stats)
>  		return NULL;
>  
> +	stats->is_disabled = kcalloc(BITS_TO_LONGS(num_counters),
> +				      sizeof(long), GFP_KERNEL);
> +	if (!stats->is_disabled)
> +		goto err;
> +

Please de-inline this function and make a rdma_free_hw_stats_struct()
call to pair with it. The hw_stats_data kfree should be in there. If
you do this as a precursor patch this patch will be much smaller.

Also, the 

        stats = kzalloc(sizeof(*stats) + num_counters * sizeof(u64),
                        GFP_KERNEL);

Should be using array_size

Jason