Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4128544pxb; Mon, 27 Sep 2021 09:58:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrc5FRz4wMEexPmV2SvnyPjTXHXzK0XOTZtifz1SOic5bHkpMTn8H5JGB2pu0ZElSNX8r4 X-Received: by 2002:a05:6402:21d6:: with SMTP id bi22mr1195432edb.40.1632761929910; Mon, 27 Sep 2021 09:58:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632761929; cv=none; d=google.com; s=arc-20160816; b=YJUWI8piNyDLJ+4bqWVOiFY426cxuDmnDoJVrIOt4ZoC/aqkAn9X0TwsT+VxjkW5cA OsJ0qZZbzvoXH9EAmmfSsDaEGARH3XMonMhIxhLTVEjK/KGuyE3Vo1zxm4NopgEe/qhx DvVvqHdG1P+VGb9MtaTyv5C9y2t2gsu/qyY+E3/xSiwDbKHjkmRUEiGD9bzK4btXhk/4 t7ZW0AcHjMQGyI86n5knrusEu1Iq91uTMrdpO6zSl8OziFMnZZmpB5e3mJXaei7j1lr6 m8MAPWRlUcHTRp/6O7gQ9UbetK0PWkKS0gAN2t153otRLIv5XJ7bS4xPbtsWqxas0vPr o+Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=LzV6OOmZa/qvBdae7Jcnof6iK8r853c6tPcY+9ZAt6o=; b=iBTg2xRkDhfGR2dNg3Wn7gePaEVpGLCjSWJw4lg/3ib/axYlDOC5Dmyhp+NO+PznMk isuxMGlOWWJgYT825x6+Z/RFMg64ImRMAYdsFe83mX4qIg6tXt6OXYsdx3xNgLsqCu4L Nvcxll1zG2n2VlTNr3ZAMnwHJYDmL+BMP3JVaPIELlQ9BtWa15H18ihRmZFQjGjNlt5D +TF6FxmEpn57tKXKyG3JMKmG4Xu0bVzuFUuazFlsOxWlPoyKZJWbAr3sgbvHCVwtrgwo qTdwXm0Ri2njArf/QtIGEy3sc1rpiSPC2MscdLZ0+lacYphcWun8J/VBpBlBo7LtOvZr cz+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w20si19456542ejv.231.2021.09.27.09.58.22; Mon, 27 Sep 2021 09:58:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235464AbhI0Qzl (ORCPT + 99 others); Mon, 27 Sep 2021 12:55:41 -0400 Received: from mail-pl1-f180.google.com ([209.85.214.180]:38904 "EHLO mail-pl1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235451AbhI0Qzk (ORCPT ); Mon, 27 Sep 2021 12:55:40 -0400 Received: by mail-pl1-f180.google.com with SMTP id x4so4701153pln.5 for ; Mon, 27 Sep 2021 09:54:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LzV6OOmZa/qvBdae7Jcnof6iK8r853c6tPcY+9ZAt6o=; b=f8yV0W2bGjUXPGpUzGiJ3+JgzZMdFZWqCpG27TCPMLxEdA7u7NmXycTT+d7PDKCzvt z+eWEmuJDpRaBtvmToXAgPN4W32jgqpZap3imwJp43ZXGGhezmq3eswQsKok2BE//rfL bYPFoH8xVQfF8i4UTefccQAdAMoDedrYW4tw7TpPuUePawmq1+SdPqTQcpuSICszvCb2 3aPMdyCKqDvMBDdEpiPyG4x/lrspKhlKECP0L/niAzvUe8O/5586Yzz0JmlBg+uyb+Mi s2Lq8lZrE26PkyMQO4SKfAFJS9O3VTDFkyNG8oxWZWXmDziBCSjwQ19+coDfzE57Hcu6 zC5A== X-Gm-Message-State: AOAM530cz2UrKdcwoB6ESdUeYI5Pg2T/v2xNL/5TQHt1XqQpgnEYf9iZ RmwY3TAn81qqMgZWcXb1Uzc= X-Received: by 2002:a17:90b:4b06:: with SMTP id lx6mr99940pjb.160.1632761642247; Mon, 27 Sep 2021 09:54:02 -0700 (PDT) Received: from sultan-box.localdomain ([204.152.215.247]) by smtp.gmail.com with ESMTPSA id r7sm17568873pff.112.2021.09.27.09.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 09:54:01 -0700 (PDT) Date: Mon, 27 Sep 2021 09:53:59 -0700 From: Sultan Alsawaf To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: Replace shrinker_rwsem trylocks with SRCU protection Message-ID: References: <20210927074823.5825-1-sultan@kerneltoast.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 27, 2021 at 10:36:36AM +0200, Michal Hocko wrote: > Can you be more specific about those scenarios please? I see frequent tmpfs mounts/unmounts in Android which result in lots of superblocks being created and destroyed, and each superblock has its own shrinker. > I have a vague recollection that this approach has been proposed in the > past. Have you checked previous attempts? I wasn't aware that there were previous attempts. Is this [1] the previous attempt you're thinking of? It seems like the thread just died out. Was the main gripe that always enabling CONFIG_SRCU increased the kernel's size too much when tinyfication was desired? Sultan [1] https://lore.kernel.org/all/153365347929.19074.12509495712735843805.stgit@localhost.localdomain/