Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4147560pxb; Mon, 27 Sep 2021 10:21:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcuSVhyTUer628xdF2g6m/h90GeZ1hxHrvyEwgg1KygbunR4a0uZHmWeGWBdrzEKZoxQtL X-Received: by 2002:a17:90b:4a82:: with SMTP id lp2mr223002pjb.57.1632763275519; Mon, 27 Sep 2021 10:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632763275; cv=none; d=google.com; s=arc-20160816; b=P0vsztxzfcXII1ct7AzrYicw64yAL3ul6UBm8wsaVmtb7S2VE/oqITfZifTieyhFKQ W0Bzt5oPC83OUjV9hQYqX31C95Q584AIZMTbMfk7nl5d65jbRKJIJIVSVrmiOdpBtjib jMe6ENKzO7QLpkvEsjdxyqF7c4QCc7Wo8qbqbTvPzu2DNnRcsCJV0A5to+2AZFW/QvwP ErAtkX4v3RkNRoTQ2H6fQZU/2asUnog3KQEKAgVGdjD6rmhcDjRBe0+FxjPGoW9OQ/xb ya+5PBdG1ucsV3VCOoJMy9X9tFxfBLVPHZkRF/jTsUeJGgVO92kcox+97svSal4NYNPj H6wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=A8m05Mvu7xxeIreh5kPdloCu9Q95rf2pb0lZ7s8CcFA=; b=FbrLzcC/pXRt7rjC4lBz+cYK2fMJC+PuHXuKm0523d8EbDJ2nPS6+FXttX3xK6W871 B7hJ0x7QG/lNEkqTXwmEios4qVvSQq99IoqWlc7DH+uWTLkjDPjNrw40zir5EEMuMPiL OZOGjxbky9jrtVKdEu3k8PYRib1IePU3hPxIU/yWtILHU9HIgj1BzfTwDu9QlyENnZHk YiuwNvUDu50/hHZjkXNTjnQPvKyI5xUJStDYHQdEwgQY4OvAeLg6sv9N6VnCNhX7Ba7z YXLD7P9XCllStNyojbHdOTbtTPNhjgP5bqmalwefMvJTbhHP/gm6FxhyyNw1vGBo4xyX RoCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Nqw0kAHo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u15si24928667plg.314.2021.09.27.10.21.01; Mon, 27 Sep 2021 10:21:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Nqw0kAHo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236512AbhI0RUF (ORCPT + 99 others); Mon, 27 Sep 2021 13:20:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:56176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236844AbhI0RPf (ORCPT ); Mon, 27 Sep 2021 13:15:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F0E3D6137E; Mon, 27 Sep 2021 17:11:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632762664; bh=oEZUQg/xVn0SgdN7rNqBHSguMu2bwqsXX/umi3xsmsY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nqw0kAHov6f1FO60SPvxi1WN+DhByY/Fsud0L7TJn8kRJeuB6b+ejK/A6OksxUBfm VeTG4x0Mm0CjtfsGzwSXMhY0MNvEfgLuKxy3TjNTQW+/qwtvV+/cUA3e/3lgurd3hJ CtzKK5lyC8FID2PcIyeEfuxN8G1i9vZ5hu5D8Fmo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sai Krishna Potthuri , Shubhrajyoti Datta , Borislav Petkov Subject: [PATCH 5.10 098/103] EDAC/synopsys: Fix wrong value type assignment for edac_mode Date: Mon, 27 Sep 2021 19:03:10 +0200 Message-Id: <20210927170229.156614462@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210927170225.702078779@linuxfoundation.org> References: <20210927170225.702078779@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sai Krishna Potthuri commit 5297cfa6bdf93e3889f78f9b482e2a595a376083 upstream. dimm->edac_mode contains values of type enum edac_type - not the corresponding capability flags. Fix that. Issue caught by Coverity check "enumerated type mixed with another type." [ bp: Rewrite commit message, add tags. ] Fixes: ae9b56e3996d ("EDAC, synps: Add EDAC support for zynq ddr ecc controller") Signed-off-by: Sai Krishna Potthuri Signed-off-by: Shubhrajyoti Datta Signed-off-by: Borislav Petkov Cc: Link: https://lkml.kernel.org/r/20210818072315.15149-1-shubhrajyoti.datta@xilinx.com Signed-off-by: Greg Kroah-Hartman --- drivers/edac/synopsys_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -782,7 +782,7 @@ static void init_csrows(struct mem_ctl_i for (j = 0; j < csi->nr_channels; j++) { dimm = csi->channels[j]->dimm; - dimm->edac_mode = EDAC_FLAG_SECDED; + dimm->edac_mode = EDAC_SECDED; dimm->mtype = p_data->get_mtype(priv->baseaddr); dimm->nr_pages = (size >> PAGE_SHIFT) / csi->nr_channels; dimm->grain = SYNPS_EDAC_ERR_GRAIN;