Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4154409pxb; Mon, 27 Sep 2021 10:29:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxLmfP29d974ctR0iZJmcXb73UYza+dp/d4+lX/Z6yOw3OqRSmcYCLrfUqmied3RUupSxy X-Received: by 2002:a50:e101:: with SMTP id h1mr1355705edl.245.1632763790437; Mon, 27 Sep 2021 10:29:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632763790; cv=none; d=google.com; s=arc-20160816; b=OExyrTGPz9fVG2/NJV5FfwvFBI5S64SwN/1NvK4eR4h+DGNFPlX0MJeGVQfwzB7+6m 6XctmkKV1jtFcSOYTVdoDc2ZTcqKQyr/xtp1E5nUt9HIE15UrEgHvcs4nlcMMXdRa4CZ D1q1mGki4kqZhl1IUQJCnyBEgHpQgPCVmRa5xVQT1PPShFWIMPSfFxF5KoTykn3F4DnS OU8VoGcyJIMU40Nql3BS8RGtAXKbZcakYtv47iEJbLKL23VmLHHSupxag3Eq2XR8iwm5 Xkv0AnLScy0Tni5Tq115XiXBUpomOrTWkMW9wdXj16Xn2P4ibeDAaYxb/nXadtHxnYCb hjiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3fe9MgmMspdANRBv+IuYqrakuVEN2gaQ9WDTz8bFfqs=; b=E4vanVDODrvCs5RP+yizxMKfSyoXaG+GHt/OTF5qRuvjJAdA7dpL9/65kLzTrBGeZa aVzN31IbDKCRbDs5CvtbYha1GZid16DdmP1aS9vMPCmyRHTrnJa1H9boTzjTrVWHuLqN eRZXNnNuKrbnfwk1hnYEPVRT8sOqpXtv8vn1W+Vj9aNtHz1RtRV4Z2sDlbs0mlLVybcr WiSuLJ7k9f+iN3+rVQvCnQ3skmNm3J9gLQ+tPxG6nFUDgc0Sjc+upNW0Uvq1bR2CZ5Y1 Wm7jL6wCpbp0TReqYdSh1Om04CDCU+TGNpg4Prmz+DRocnJXA+T6qXaI/U4n7yoyVz4L HNNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hHOktnbX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a13si5510752edt.514.2021.09.27.10.29.24; Mon, 27 Sep 2021 10:29:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hHOktnbX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237112AbhI0R1x (ORCPT + 99 others); Mon, 27 Sep 2021 13:27:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:36852 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238012AbhI0RYL (ORCPT ); Mon, 27 Sep 2021 13:24:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E88656137B; Mon, 27 Sep 2021 17:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632762930; bh=KzbuxniTZU/Xpf8v/BqtXJsvj4hDDoghvisbVdmQzKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hHOktnbXcE8WmTojynCfMFcFPKfDoWCgOZPRQMLl9CVBK9txUixVQf9R3AZb9tAI4 hthgyW/FWdAk96y04sBGuDpsv5h96F6e0WsIEiM/rvIxpJCCub/IYke0NZBeZuvRV6 CaGAD5yDMQauRfKy2xY9GpYMoymqW5HDAEFqMeWY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Can Guo , Avri Altman , Bart Van Assche , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.14 105/162] scsi: ufs: core: Unbreak the reset handler Date: Mon, 27 Sep 2021 19:02:31 +0200 Message-Id: <20210927170237.072785112@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210927170233.453060397@linuxfoundation.org> References: <20210927170233.453060397@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bart Van Assche [ Upstream commit d04a968c33684b15d1206e23fc1119ce0f0587fb ] A command tag is passed as the second argument of the __ufshcd_transfer_req_compl() call in ufshcd_eh_device_reset_handler() instead of a bitmask. Fix this by passing a bitmask as argument instead of a command tag. Link: https://lore.kernel.org/r/20210916175408.2260084-1-bvanassche@acm.org Fixes: a45f937110fa ("scsi: ufs: Optimize host lock on transfer requests send/compl paths") Cc: Can Guo Reviewed-by: Avri Altman Signed-off-by: Bart Van Assche Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index a858e7d998a6..3a204324151a 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -6858,7 +6858,7 @@ static int ufshcd_eh_device_reset_handler(struct scsi_cmnd *cmd) err = ufshcd_clear_cmd(hba, pos); if (err) break; - __ufshcd_transfer_req_compl(hba, pos, /*retry_requests=*/true); + __ufshcd_transfer_req_compl(hba, 1U << pos, false); } } -- 2.33.0