Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4156254pxb; Mon, 27 Sep 2021 10:31:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8WY/ZTM19SbayPk6WTLmA3JZLH8lKL2t4DN+Iuy3MMoLhcsL7okYQcsvE+wbrMOj+p+VH X-Received: by 2002:a17:903:31cd:b0:134:5b6f:2ff8 with SMTP id v13-20020a17090331cd00b001345b6f2ff8mr1022730ple.46.1632763916826; Mon, 27 Sep 2021 10:31:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632763916; cv=none; d=google.com; s=arc-20160816; b=r+nYy0/HNE97QxUAg2XZmHLv7dujEkBPILyksXKWVwYbSAzZULlMSV4a1LPoaRwM20 pxciDWYEDAfYPYI0SMdQZ3ELE4UlsNz0yvlwpkId9ZwkMVAu+cJBklRP+fbS1sfIdHN2 XOH3uGd7LfD9PaU2/SeBKbceRjWFIxur69eA+NCF7IeZkuciccyg6T71Ba5kYIWiR7L3 ardOtRjhYcwK8nhPsqZrOdOScOq2T4gHelebieYamILVz+nxnUNVoSshJGDPLCrBmG3H 3P5Xrh2c8D0ocPf2P1ladIk6JVkrl+37b5hAK5+6EptrhAeSu476oqZF9O90/cgGUFqz yszQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=A8m05Mvu7xxeIreh5kPdloCu9Q95rf2pb0lZ7s8CcFA=; b=K3OOg67gBQgGEBjxFpwBao0wpGlPYned3aGUQj2JX/OEVNk97ZVFkxbNYKX2XpcQFx o+b2PkY6KINGBCKLwtjiqG6zpFWk/xjdjMnl7FUf04edn9cVDUCHNvWhGER7/HJvQj6d r6/XO474f5c2y7uR1VVl7U+HOoJiJXU7JXoSQVkH1Ra5CrPlHT5Pd7kakjt6+KFnf9XY 3RbuiicGjpi0jWdAv64ygq9ZDmiL7BvDOh5sE+PyYRI00/Q7+5wkbHNS1jz2sVYz6ZO0 VLTQok/UNwmhLyIyNVXQGQ6mRrbJNpa6JXqfEcvaEFQ3w1bMfeBH4sB8RsHMLrTcOMvQ 7kjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tEwokB2E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q17si22467670pfg.312.2021.09.27.10.31.43; Mon, 27 Sep 2021 10:31:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tEwokB2E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238352AbhI0RcV (ORCPT + 99 others); Mon, 27 Sep 2021 13:32:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:44582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238220AbhI0R2e (ORCPT ); Mon, 27 Sep 2021 13:28:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A448861501; Mon, 27 Sep 2021 17:17:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632763055; bh=oEZUQg/xVn0SgdN7rNqBHSguMu2bwqsXX/umi3xsmsY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tEwokB2EWJo4BoL6Bh1BrzgOJ2T5wNdPIz+bO8RfLLrwrzeOfFWflySIP1prfF/xB jYeCmstm8LNerf616BB5bbRsPzP0fF4haYB1AOxQsHJvtdxzLPwIk6doWL/LxdpSuT 9FkyoHXcphIYlvpSYGQ/KRwn496vd1bU1M89LCpA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sai Krishna Potthuri , Shubhrajyoti Datta , Borislav Petkov Subject: [PATCH 5.14 150/162] EDAC/synopsys: Fix wrong value type assignment for edac_mode Date: Mon, 27 Sep 2021 19:03:16 +0200 Message-Id: <20210927170238.622224817@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210927170233.453060397@linuxfoundation.org> References: <20210927170233.453060397@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sai Krishna Potthuri commit 5297cfa6bdf93e3889f78f9b482e2a595a376083 upstream. dimm->edac_mode contains values of type enum edac_type - not the corresponding capability flags. Fix that. Issue caught by Coverity check "enumerated type mixed with another type." [ bp: Rewrite commit message, add tags. ] Fixes: ae9b56e3996d ("EDAC, synps: Add EDAC support for zynq ddr ecc controller") Signed-off-by: Sai Krishna Potthuri Signed-off-by: Shubhrajyoti Datta Signed-off-by: Borislav Petkov Cc: Link: https://lkml.kernel.org/r/20210818072315.15149-1-shubhrajyoti.datta@xilinx.com Signed-off-by: Greg Kroah-Hartman --- drivers/edac/synopsys_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -782,7 +782,7 @@ static void init_csrows(struct mem_ctl_i for (j = 0; j < csi->nr_channels; j++) { dimm = csi->channels[j]->dimm; - dimm->edac_mode = EDAC_FLAG_SECDED; + dimm->edac_mode = EDAC_SECDED; dimm->mtype = p_data->get_mtype(priv->baseaddr); dimm->nr_pages = (size >> PAGE_SHIFT) / csi->nr_channels; dimm->grain = SYNPS_EDAC_ERR_GRAIN;