Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <7295cafaf6da34e31390fe621198205d18eac525.camel@linux.intel.com>
Subject: Re: [PATCH 2/2] platform/x86: Add Intel Software Defined Silicon
 driver
From:   "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     lee.jones@linaro.org, hdegoede@redhat.com, mgross@linux.intel.com,
        andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        platform-driver-x86@vger.kernel.org
Date:   Mon, 27 Sep 2021 10:27:28 -0700
In-Reply-To: <YVFC0U+wOqbTgDhy@kroah.com>
References: <20210924213157.3584061-1-david.e.box@linux.intel.com>
         <20210924213157.3584061-2-david.e.box@linux.intel.com>
         <YU7BPIH123HUZKhw@kroah.com>
         <3392aea6b112926b063bbe46b1decaad4c9f9e6e.camel@linux.intel.com>
         <YVFC0U+wOqbTgDhy@kroah.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2021-09-27 at 06:04 +0200, Greg KH wrote:
> On Sun, Sep 26, 2021 at 06:15:16PM -0700, David E. Box wrote:
> > > > +static struct platform_driver sdsi_driver = {
> > > > +       .driver = {
> > > > +               .name           = SDSI_DEV_NAME,
> > > > +               .dev_groups     = sdsi_groups,
> > > > +       },
> > > > +       .probe  = sdsi_probe,
> > > > +       .remove = sdsi_remove,
> > > > +};
> > > > +module_platform_driver(sdsi_driver);
> > > 
> > > What causes the platform to know to register, and enable, this platform
> > > driver?  Shouldn't there be some hardware involved that is discoverable
> > > to enable it to load dynamically?
> > 
> > Ah. The patch that adds the SDSi platform device string was added to a series for the intel_pmt
> > MFD
> > driver and it's still waiting review. I see that complicates things. I can combine the two series
> > together.
> 
> Do you have a pointer to the lore.kernel.org location of that series?

https://lore.kernel.org/all/20210922213007.2738388-1-david.e.box@linux.intel.com/

> 
> Your code right here will bind to any system that it is loaded on, a
> very dangerous thing...

It won't. It uses module alias to load against the SDSi specific MFD cell.

> 
> thanks,
> 
> greg k-h