Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4160589pxb; Mon, 27 Sep 2021 10:37:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydAjyFCPqmdj0JcZAa+zj4Gp931O6h394lL1TyWNStpo1071QtKOHS6S8OD/CPZKU2ojCJ X-Received: by 2002:a17:906:7848:: with SMTP id p8mr1406746ejm.212.1632764235745; Mon, 27 Sep 2021 10:37:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632764235; cv=none; d=google.com; s=arc-20160816; b=AmE3hVhpXARsQFJYaTtU7gAcTuW44BD3a50PKmF2LKJj9jKvaKSiX3h2kcbTifKIlb O5NvfJbaWkkONWJK8ugP0J+W0rj1u9g2Vbl2XzNv2EZjY3pruOh8soPjSUOFbk+23njV fVnwMI+jnxXVO1d6lnZX/th2bhFTXm5b3PglApRxK8+aX8dX6v32kQc/PDGEcKkE5Tr9 7XeO6tMXaz9G7SbpJMvSfSeCSvlxNoXQ8KBmv3Q7taHQ3zhmD0a0HziBkOCM/pUchMNL qw6HwpV14OCoP+MypXHtiwwMYfFT6Rsl5sW2Fdh7ve8qKza1Mdj5H6Xrg0FfBebxI29c wBMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=sWthEd8thvF+XGkVYUkeFMxlWcXd1BhPEpZoeT80pWI=; b=hDMwfTjy2gYCNMmJGkmIcMDmWsCjmdiEAMK+I9gd1jrs15GdTUwJp6AX37ftC9TnIZ NQFS5iG1uhOaeLUfdRDOcgs1ogzf9HMXKL8yRkBW2B10b4ynMjYKtNxk/FfkR8XyILJ3 BKPD0zqanTg/S50+bjI9otKcn/T7Fb3V2NinkQbg9JoPbNbX3IYjT/pPO5hs8LfciM8z 9u0cHiHrmmdHBdild4uoUFA8UX53UNXWXmG2kml/vVx3CEo16fcfFHEyx9+rJILIWQGJ BJcBtb0qC7Micn7s9l/2sJAC2TlDaJ1uzaxLGe0Y/xLrzoCc8lOAr9zkVhIs8MuyCu+7 cjqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Yj9QDrwh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w18si19385062ejv.669.2021.09.27.10.36.50; Mon, 27 Sep 2021 10:37:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Yj9QDrwh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238284AbhI0Rgy (ORCPT + 99 others); Mon, 27 Sep 2021 13:36:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:45914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238301AbhI0RcJ (ORCPT ); Mon, 27 Sep 2021 13:32:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1077460FC2; Mon, 27 Sep 2021 17:30:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632763828; bh=sWthEd8thvF+XGkVYUkeFMxlWcXd1BhPEpZoeT80pWI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yj9QDrwhkQBZSYAsOsJBGq9Bs62/LBNlL9bIz12/+OpRqNgkiDGQddJVl34MckGmw hetcjddDSGIMNkUTFPku0iGvxUApsEkE0V3M9lJ6WsGiRc5qo3b0GPHJKl64xZjc77 Q6QbQzt8/j7qLWs7gF7CLXfGsObT0BCH2dJpjcy2BQbNQ4f3F7s2bDYAoVC1FP8t6K sWsI32VaGlnB23kxsY/ODXVkEyGTbOob1WGekA+v4+KpsA0IMnb/SBp1Mtx5L6OCrm MRONKGJ9ANY8FQ9hbtnyXxMY+wO+w+P63c2JDPkIWG095BvGfWMDpoX/Fu2kcM3l4t 9/wHzy6aCAysw== Date: Mon, 27 Sep 2021 18:29:40 +0100 From: Mark Brown To: Pierre-Louis Bossart Cc: "guennadi.liakhovetski@linux.intel.com" , "alsa-devel@alsa-project.org" , "ryan.lee.maxim@gmail.com" , Ryan Lee , "linux-kernel@vger.kernel.org" , "tiwai@suse.com" , "lgirdwood@gmail.com" , "sathya.prakash.m.r@intel.com" , "yung-chuan.liao@linux.intel.com" Subject: Re: [EXTERNAL] Re: [PATCH] ASoC: max98373: Mark cache dirty before entering sleep Message-ID: <20210927172940.GH4199@sirena.org.uk> References: <20210924221305.17886-1-ryans.lee@maximintegrated.com> <1b21bbf1-12c7-726d-bff8-76ec88ff8635@linux.intel.com> <20210927160622.GE4199@sirena.org.uk> <7b8c3875-3f12-f3cb-7da8-4e850e59ee2b@linux.intel.com> <20210927171033.GF4199@sirena.org.uk> <0af258d4-e33c-15ec-5dcc-a1c9961c0740@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xHbokkKX1kTiQeDC" Content-Disposition: inline In-Reply-To: <0af258d4-e33c-15ec-5dcc-a1c9961c0740@linux.intel.com> X-Cookie: 98% lean. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xHbokkKX1kTiQeDC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 27, 2021 at 12:23:06PM -0500, Pierre-Louis Bossart wrote: > On 9/27/21 12:10 PM, Mark Brown wrote: > > A quick survey of other drivers suggests that this pattern should be > > factored out into some helpers as it looks like there's several ways of > > implementing it that look very similar but not quite the same... > No disagreement here, we tried really hard to enforce a common pattern > for suspend-resume, but i just noticed that the maxim amp driver is > different on suspend (resume is consistent with the rest). There seem to be several slightly different ways of writing what I think is supposed to be the same thing in _io_init() too. --xHbokkKX1kTiQeDC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFR/4MACgkQJNaLcl1U h9CnLQf+I7rNZH7/UAxm+ygPqR5wyC07ln6SF8HTbd4RVPRcbgoUpr/zRLV0AdET WF6koeLuHvqZ4HyJhvBcPNacTCBldtRTa/cWQzhV85mVLHWIeHfTBk6ySO860z4o S9cjLuFi9upjkRBL7L1P40vl1Ti9gq7vUltipE4AVNfea697+lSy9C/H3Dyvlgig 8hKLejhr3ZcM5l8eQSZ1E878xyCNGRP3M4K5OoHydJeKBBAO3OiOyaNjlhgetsb/ 8dELrjAtM9NsedKLfNBm6jAqcJ3zFJsjoMKfVB54FOBOdfMFoYPC1PoNWnj8vZQQ Dw/6qpGr4yVYpZNqUqVNCtzlsHm5VQ== =Q6Xg -----END PGP SIGNATURE----- --xHbokkKX1kTiQeDC--