Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Sep 2021 14:30:01 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Doug Ledford <dledford@redhat.com>,
        Aharon Landau <aharonl@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Gal Pressman <galpress@amazon.com>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, Maor Gottlieb <maorg@nvidia.com>,
        Mark Zhang <markzhang@nvidia.com>,
        Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
        Mustafa Ismail <mustafa.ismail@intel.com>,
        Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
        Neta Ostrovsky <netao@nvidia.com>, netdev@vger.kernel.org,
        Potnuri Bharat Teja <bharat@chelsio.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Selvin Xavier <selvin.xavier@broadcom.com>,
        Shiraz Saleem <shiraz.saleem@intel.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: Re: [PATCH rdma-next v1 06/11] RDMA/nldev: Add support to get status
 of all counters
Message-ID: <20210927173001.GD1529966@nvidia.com>
References: <cover.1631660727.git.leonro@nvidia.com>
 <86b8a508d7e782b003d60acb06536681f0d4c721.1631660727.git.leonro@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <86b8a508d7e782b003d60acb06536681f0d4c721.1631660727.git.leonro@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?H6FIcy5phxSRaMMK9E8tGYNMGWaxivxyOksRk1NyAL5QTpqAVeB392raURdo?=
 =?us-ascii?Q?7Q0LHRX2sEbZVxGIrmCsfuqGsm32hLhVHd5XBhfL9I13Y60o5krZPpzfWhH9?=
 =?us-ascii?Q?6VAjLBb8/dQ9nP1R3B1rVoG2w6GdVdkGP7EP7tcT74HEzgC3v2Uql5XyG226?=
 =?us-ascii?Q?keWXnNNwfbB8wqj+cfm4sI2pkOyIATLY2igHD8Oa8CEGmGrn+2U5ts3jz/YH?=
 =?us-ascii?Q?KLDisoUAp1YIGITMqVIJnMhmlhBM7dLxmd1w6FsYL9W2pcZ3agBz5kKKMGsj?=
 =?us-ascii?Q?nJVa5gPDiSv+49x1kNKo0+VcP8wdVELa+dsiQqpGZtpaikLqdSPn6nKB4/U7?=
 =?us-ascii?Q?cG7hLQjq86br6i4oA/dIwwGqHtbuRSpG6G3NnmH4CaoadgShF5hBR/SXfnwp?=
 =?us-ascii?Q?ycvs0SOqfvyPG4LpkSHBck0Yp/PPEMoyoMSJwNflrBsiqI+KQFdZRXUVQI5B?=
 =?us-ascii?Q?nbPgxZ2ao5dsWNJQfwx1LxTaP4IveBKHnnFxbBuSZVEXgc44flTOZPZYUvDn?=
 =?us-ascii?Q?kIHoUQCrqGFF7qrS7Q8HsHUF7MLKpzmgA8fOwn2nJdosW1magM4P1xFKnH3Z?=
 =?us-ascii?Q?Qt+zi2OSwS8R7NCm3xYKJdTkA4jflldMv9KJNmKqYhfhAvYPrL7sXZEiuvWB?=
 =?us-ascii?Q?IBF9b4UaD1IXrQvi8VLg/rn/1C015AztACufGu0oimJTMd6FmQd/2SiHRANT?=
 =?us-ascii?Q?but4xBLF3psWG8B7NFNKh6FQXU8jAyWCJmgzxglWbFc9ywf5hr92W0DWclLf?=
 =?us-ascii?Q?GeVViDYa1D6rVOb1gW4eL6v7fU4A8DbVcUKs2exAid3YLHy6AhoXBK9blaUQ?=
 =?us-ascii?Q?48mzTRlelzHYees6s7zbmPHazpmgannaDXa+4yhiP8tolyoJhByx0EEvRx46?=
 =?us-ascii?Q?8mr63QBqPvpnmEZqoqnadloCJM4W5OB0i/YuOFUq5Ga/2O8VuKFYPcYyzV9/?=
 =?us-ascii?Q?3JepXoh88VFA5f7lIsYB3dL8f7cYvQmOSmAj27uM7+hJYTyVU1sPp8Qp2mTw?=
 =?us-ascii?Q?PlXdua+VBOcHxzNXMlZzOz+RynGPRjbs4Z5bsbc1wXhwLFnzrgM9OQCPpMws?=
 =?us-ascii?Q?cJzzRDRoI+I9L3Jzcdi7LmUWdrneHLlOlF1zOxRR1OFe8593g//Zx+bi8vQ1?=
 =?us-ascii?Q?PkIzjJFmh7Ug3+mXHKb5V6Vgfuf2ycwQXv4ZHM93pTpjxM/3CvBONYFDC3M8?=
 =?us-ascii?Q?JZrOct2G2lWTXCv6T0gGeCxTFueiurpZ4Ymr4XKwKTtrm/frsPFxOrn8kJbk?=
 =?us-ascii?Q?o72L6tIXeUz+0q5S8ATpLwYog3ejy1So/5Dzgb0l7aCanrskkJKxC3UG1bsh?=
 =?us-ascii?Q?O2FPOSUGplwnDcBFlKumAw8F?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78f542da-83ad-4b1f-5ce0-08d981dc7046
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 17:30:02.9438
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fObAo0aN5h/BsqdWO4eIm+X4QfoFd4a0DVMps/zyw67ptWTdSj+A4rAT1omHY9Z6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5144
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 15, 2021 at 02:07:25AM +0300, Leon Romanovsky wrote:
> +static int stat_get_doit_default_counter(struct sk_buff *skb,
> +					 struct nlmsghdr *nlh,
> +					 struct netlink_ext_ack *extack,
> +					 struct nlattr *tb[])
> +{
> +	struct rdma_hw_stats *stats;
> +	struct ib_device *device;
> +	u32 index, port;
> +	int ret;
> +
> +	if (!tb[RDMA_NLDEV_ATTR_DEV_INDEX] || !tb[RDMA_NLDEV_ATTR_PORT_INDEX])
> +		return -EINVAL;
> +
> +	index = nla_get_u32(tb[RDMA_NLDEV_ATTR_DEV_INDEX]);
> +	device = ib_device_get_by_index(sock_net(skb->sk), index);
> +	if (!device)
> +		return -EINVAL;
> +
> +	port = nla_get_u32(tb[RDMA_NLDEV_ATTR_PORT_INDEX]);
> +	if (!rdma_is_port_valid(device, port)) {
> +		ret = -EINVAL;
> +		goto end;
> +	}
> +
> +	stats = ib_get_hw_stats_port(device, port);
> +	if (!stats) {
> +		ret = -EINVAL;
> +		goto end;
> +	}
> +
> +	if (tb[RDMA_NLDEV_ATTR_STAT_HWCOUNTER_DYNAMIC])
> +		ret = stat_get_doit_stats_list(skb, nlh, extack, tb,
> +					       device, port, stats);
> +	else
> +		ret = stat_get_doit_stats_values(skb, nlh, extack, tb, device,
> +						 port, stats);

This seems strange, why is the output of a get contingent on a ignored
input attribute? Shouldn't the HWCOUNTER_DYNAMIC just always be
emitted?

Jason