Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Sep 2021 13:39:15 -0400
From:   Peter Xu <peterx@redhat.com>
To:     Axel Rasmussen <axelrasmussen@google.com>
Cc:     Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Nadav Amit <nadav.amit@gmail.com>, Li Wang <liwan@redhat.com>
Subject: Re: [PATCH] mm/userfaultfd: selftests: Fix memory corruption with
 thp enabled
Message-ID: <YVIBw8ATbCIAbd2d@t490s>
References: <20210923232512.210092-1-peterx@redhat.com>
 <CAJHvVci8ig4WCY2aK-GvmHP=Uw3s8DrGahk-Yh37GX2kR35kww@mail.gmail.com>
 <YU4uJLJHsHLVsS2w@t490s>
 <CAJHvVcjniq3TS=69O2tkAVD02tRCnRtw1Xf5Hu2Me4deQbq9sQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAJHvVcjniq3TS=69O2tkAVD02tRCnRtw1Xf5Hu2Me4deQbq9sQ@mail.gmail.com>
Precedence: bulk

On Mon, Sep 27, 2021 at 10:34:06AM -0700, Axel Rasmussen wrote:
> One possibility would be to MADV_NOHUGEPAGE the regions, which at
> least would fix the immediate flakiness. Then we could spend some time
> adding a test case which specifically targets THP interactions? (I do
> think we want test coverage of that in the end, but with the current
> tests it's kind of "accidental".)

If we can't reproduce it with khugepaged yet, I'd think we can also consider
keep torturing thp with this patch and at the meantime look for a clean
approach?

Now it's only the event test failing, if we apply NOHUGEPAGE we give up thp for
all.

-- 
Peter Xu