Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Sep 2021 19:12:19 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Kent Overstreet <kent.overstreet@gmail.com>
Cc:     Vlastimil Babka <vbabka@suse.cz>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Johannes Weiner <hannes@cmpxchg.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Darrick J. Wong" <djwong@kernel.org>,
        Christoph Hellwig <hch@infradead.org>,
        David Howells <dhowells@redhat.com>
Subject: Re: Struct page proposal
Message-ID: <YVIJg+kNqqbrBZFW@casper.infradead.org>
References: <YUvWm6G16+ib+Wnb@moria.home.lan>
 <bc22b4d0-ba63-4559-88d9-a510da233cad@suse.cz>
 <YVIH5j5xkPafvNds@casper.infradead.org>
 <YVII7eM7P42riwoI@moria.home.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YVII7eM7P42riwoI@moria.home.lan>
Precedence: bulk

On Mon, Sep 27, 2021 at 02:09:49PM -0400, Kent Overstreet wrote:
> On Mon, Sep 27, 2021 at 07:05:26PM +0100, Matthew Wilcox wrote:
> > On Mon, Sep 27, 2021 at 07:48:15PM +0200, Vlastimil Babka wrote:
> > > On 9/23/21 03:21, Kent Overstreet wrote:
> > > > So if we have this:
> > > > 
> > > > struct page {
> > > > 	unsigned long	allocator;
> > > > 	unsigned long	allocatee;
> > > > };
> > > > 
> > > > The allocator field would be used for either a pointer to slab/slub's state, if
> > > > it's a slab page, or if it's a buddy allocator page it'd encode the order of the
> > > > allocation - like compound order today, and probably whether or not the
> > > > (compound group of) pages is free.
> > > 
> > > The "free page in buddy allocator" case will be interesting to implement.
> > > What the buddy allocator uses today is:
> > > 
> > > - PageBuddy - determine if page is free; a page_type (part of mapcount
> > > field) today, could be a bit in "allocator" field that would have to be 0 in
> > > all other "page is allocated" contexts.
> > > - nid/zid - to prevent merging accross node/zone boundaries, now part of
> > > page flags
> > > - buddy order
> > > - a list_head (reusing the "lru") to hold the struct page on the appropriate
> > > free list, which has to be double-linked so page can be taken from the
> > > middle of the list instantly
> > > 
> > > Won't be easy to cram all that into two unsigned long's, or even a single
> > > one. We should avoid storing anything in the free page itself. Allocating
> > > some external structures to track free pages is going to have funny
> > > bootstrap problems. Probably a major redesign would be needed...
> > 
> > Wait, why do we want to avoid using the memory that we're allocating?
> 
> The issue is where to stick the state for free pages. If that doesn't fit in two
> ulongs, then we'd need a separate allocation, which means slab needs to be up
> and running before free pages are initialized.

But the thing we're allocating is at least PAGE_SIZE bytes in size.
Why is "We should avoid storing anything in the free page itself" true?