Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/5] x86/mce/inject: Check if a bank is unpopulated before
 error simulation
To:     Borislav Petkov <bp@alien8.de>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Cc:     x86@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>, yazen.ghannam@amd.com
References: <20210915232739.6367-1-Smita.KoralahalliChannabasappa@amd.com>
 <20210915232739.6367-2-Smita.KoralahalliChannabasappa@amd.com>
 <YU2Lm+11Pqg/RBK3@zn.tnic>
From:   Smita Koralahalli Channabasappa <skoralah@amd.com>
Message-ID: <60d4f6be-76f7-e4b6-6fb5-2af78b01d32d@amd.com>
Date:   Mon, 27 Sep 2021 14:51:56 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.1
In-Reply-To: <YU2Lm+11Pqg/RBK3@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXhaYldvN09ZZG5MUTVvM09RWk04elRQS3hXTmtPdWE5WFBrd1puQUVPVGJ5?=
 =?utf-8?B?R1ZheTVuVUpJTFhEK3dINWFnRFo2U3ZLL2pMV0h2UllLSUpMWlcwL3hyVTlP?=
 =?utf-8?B?bVFrTS9XZ09NSFZ5cnlUYmk4Z0I2RVU5YkNSK1VjY0lXSjhabmtTYStSY01z?=
 =?utf-8?B?UkN2Y3ZrVGYwR1diT0ttMGxzQXZyNzJ4S2lQS0hpOGtEelZTUzVhK3hjdEtl?=
 =?utf-8?B?S3l0NmdEaGxUVHZwakd3dlE0b3JVYURuQmlqK0RXd2VYRmxCOUJ6WTdONlVT?=
 =?utf-8?B?OVZuNGRQYWVNc0VuUGdxbktQVmtvR1laN3BXK2hTb080eW1HbEs1Mi8za0kr?=
 =?utf-8?B?eG9xWDM2THFlRXFxSkpKOXp0dG5KbC9YTWRaSlk1YlliOU5TM0Z4ME5EUERx?=
 =?utf-8?B?ODZ2NVpTb2U5SjVoTG0vVFZLK0tkY2JBbm5BeHRiTlhBbHJtczFQdnRqVlVW?=
 =?utf-8?B?K2svc0hxNEw1d1NTNy9wemdjZzlhcGM5cG9ETEZXVmwxYkh5aVRraG9xY3ZY?=
 =?utf-8?B?eTJ3Ry9GVW1QeXBzbDkwdWlOS3hydi9Db1IraERNOEp3ZllzV2JaSUN2Wit4?=
 =?utf-8?B?Slg1QXhSVTZWd2VEZ0I3WkRZaWcwRU52YUN1TytHZ3ZrNGpMQ0w0UkNKY1hi?=
 =?utf-8?B?V1JVckptZXJKS002MUphUWk3VmpMWUUxWVlmelMxYVZzamdCbWhLSlNrM1Er?=
 =?utf-8?B?Q1c5cWY2Mk5wZzF6ODhTZTJDSFFMajMzUUR6NUZVbXZkZ205WVZlSG5hUitP?=
 =?utf-8?B?ejY3WUpnY3JzZHpOekJXblpvTFRYL1NGU1k3VzJUd1VyazAwN1VPZW9hVGJw?=
 =?utf-8?B?WFQxN1ZpaEZEZnpBZFozaElJNGNGdWVCb01IQUhYeWI0L1FGSnBFdmJUMEVV?=
 =?utf-8?B?V2xlanN1ZjRnb3gwaUJrTXVmQml6WWdyb25yL2dJcGFDWFh0LzdyT3d4MkRT?=
 =?utf-8?B?TmVOdHUxU2hhUlNYa01BT3VzS3p1dVEzNHp6QmpxMkRhaE1UODRlN3Z3UDM3?=
 =?utf-8?B?WFFCWFk3WDB5dkxyM2g1Tm4yVW5sMnpGM2FHVHViLzNNQXorRER1MzA2UG1y?=
 =?utf-8?B?VExQbVVGRUhEby9IM2xoRkVYSFJ2NlRaYyttWlhVNVdWT1pYeE5vUFF4ejl3?=
 =?utf-8?B?V0tIZU1XYnpNMUdLSmpsR2RXRk5SMFJ3MGZGL2RMank1TW9weDVWcFpVVTFz?=
 =?utf-8?B?TFJwZkJ0NHlsancrcGZjYldlT05mNmtWejVBRU9RKzQ5dWdJNFNkLzZyRkR2?=
 =?utf-8?B?OUo5TlNNeVpVMWVKNjZEajVDMncxMktwZkFxdTdhNHdCUnhlbVgwekgraVZO?=
 =?utf-8?B?SEV5OUFSRUNsdEJuNURKbktQQlEvYkhtYVdlRlhHRFMxV003akd5QVJWOUlU?=
 =?utf-8?B?Ry83c2VJOWZnbTlnWW1lZXJ6UjBWTU1uUFdKbHF5R1Nwc2p5TTRZSlc5aUsv?=
 =?utf-8?B?VGpWdHhzY29Cb2dNQVlzZ1IzM1h4alV6cEpjVEJkbXpQaE96QkNhRWI2ckNk?=
 =?utf-8?B?VWVpRTQ0eUU4M1poUlNoVFJrSzRzOTVEZ0t5T29Xb1NscmVyNGRHTGg5QmZK?=
 =?utf-8?B?L2ZNUFpSL0pXR2VmYVBrdTFWWjk5UXhLVDJVMG42NGFUQ2JXaW52endsSlRB?=
 =?utf-8?B?R05uNTVrcmxSSnJrZ0dUVGhzTkhGSWkzOGgyZHJWY0lleWIzYS9jMmFPWTZj?=
 =?utf-8?B?NkV0d2xqZWRzQk9vNjdFM2FmSEpTcXE5QU5VSDlybm9wblJKaFRvZVJudGFW?=
 =?utf-8?B?cVJwVG00SW9KbEQ0ak1nNStnREQ4TWJPbVl5OWxhMzQ3c1FGUnVmdlliNDIx?=
 =?utf-8?B?S3ZCZCtsaWdiZER5dTJSb0xiZmxiSmlDSWNkRTR2OVVSL1Z3TTdNZk9wcVZs?=
 =?utf-8?Q?bsrlfyrC9LCJF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a827c3ca-1022-4cb5-6fec-08d981f043d8
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 19:51:58.1337
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O7iXb6BNndzWvLO/CgKY6MZrKrNPfgA4tgEtoEsG2bj8KpD5W/gZHA/K1aP3UXyIvN6zz1FBnOkbNIy9/cQujQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3317
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Boris,

On 9/24/21 3:26 AM, Borislav Petkov wrote:

> On Wed, Sep 15, 2021 at 06:27:35PM -0500, Smita Koralahalli wrote:
>> The MCA_IPID register uniquely identifies a bank's type on Scalable MCA
>> (SMCA) systems. When an MCA bank is not populated, the MCA_IPID register
>> will read as zero and writes to it will be ignored. Check the value of
>> this register before trying to simulate the error.
>>
>> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
>> ---
>>   arch/x86/kernel/cpu/mce/inject.c | 18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/x86/kernel/cpu/mce/inject.c b/arch/x86/kernel/cpu/mce/inject.c
>> index 0bfc14041bbb..51ac575c4605 100644
>> --- a/arch/x86/kernel/cpu/mce/inject.c
>> +++ b/arch/x86/kernel/cpu/mce/inject.c
>> @@ -577,6 +577,24 @@ static int inj_bank_set(void *data, u64 val)
>>   	}
>>
>> +	if (boot_cpu_has(X86_FEATURE_SMCA)) {
> This whole thing belongs into inj_ipid_set() where you should verify
> whether the bank is set when you try to set the IPID for that bank.

Can you please elaborate on this? I'm not sure if I understood this
right. Should I read the ipid file to verify that the user has input
proper ipid? If ipid file reads zero then do rdmsrl_on_cpu?

Thanks,
Smita

>
> +			if (!m->ipid) {
> +				pr_err("Error simulation not possible: Bank %llu unpopulated\n",
>> +
>> +		/* Check for user provided IPID value. */
>> +		if (!m->ipid) {
>> +			rdmsrl_on_cpu(m->extcpu, MSR_AMD64_SMCA_MCx_IPID(val),
>> +				      &m->ipid);
> Oh well, one IPI per ipid write. We're doing injection so we can't be on
> a production machine so who cares about IPIs there.
>