Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Sep 2021 17:58:22 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Chris Down <chris@chrisdown.name>, Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Jessica Yu <jeyu@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        John Ogness <john.ogness@linutronix.de>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        YueHaibing <yuehaibing@huawei.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        llvm@lists.linux.dev
Subject: Re: [PATCH] printk: avoid -Wsometimes-uninitialized warning
Message-ID: <20210927175822.6c928128@oasis.local.home>
In-Reply-To: <CAK8P3a264UGrqV648i3v_z_MciRO+eYN8f9RhJL9ksDuKVdAkg@mail.gmail.com>
References: <20210927125007.1581919-1-arnd@kernel.org>
        <YVHE1qclD6ZyjvvD@chrisdown.name>
        <20210927122138.56cb1d8e@oasis.local.home>
        <CAK8P3a264UGrqV648i3v_z_MciRO+eYN8f9RhJL9ksDuKVdAkg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 27 Sep 2021 20:32:12 +0200
Arnd Bergmann <arnd@kernel.org> wrote:

> On Mon, Sep 27, 2021 at 6:21 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Mon, 27 Sep 2021 14:19:18 +0100
> > Chris Down <chris@chrisdown.name> wrote:
> >  
> > > Having IS_ENABLED and then an #ifdef seems to hurt code readability to me.  
> >
> > I agree.
> >
> > Would this be a better solution?  
> 
> Sounds good, I'll follow up with that version after the next round of randconfig
> builds.

OK, but can you remove the extra line that's between the brace and the
text. I should have deleted it in that patch.

-- Steve