Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
In-Reply-To: 
To:     y.oudjana@protonmail.com
Cc:     agross@kernel.org, bjorn.andersson@linaro.org,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        gpiccoli@igalia.com, kernel@gpiccoli.net, loic.poulain@linaro.org,
        konrad.dybcio@somainline.org
From:   "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Subject: Re: [PATCH] arm64: dts: qcom: msm8996: Add CPU cooling suppor,t
Message-ID: <5ccc4ea8-e000-b6b9-0781-dcde814eda96@igalia.com>
Date:   Mon, 27 Sep 2021 18:45:29 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Yassine, thanks for the patch! I was doing some experiments with a
dragonboard 820-based board, and without your patch, a CPU benchmark can
quickly cause overheating - throttling mechanism doesn't start and we
get a FW reset to a bad state (likely a HW protection mechanism).

I noticed that a similar patch including cooling maps is present in
Linaro's qcom tree [0], and it was submitted upstream [1], but there was
a re-submission [2] by Konrad that was merged and dropped the thermals
part. Based on some threads I read, it seems a FW lockup was detected
with the complete patch?

I'm not sure, so I'm looping Konrad / Loic / Bjorn here, to understand
better what made this portion of the patch to be dropped.
Anyway, I think worth to mention this in your commit message Yassine,
including perhaps a fixes tag like:

Fixes: 90173a954a22 ("arm64: dts: qcom: msm8996: Add CPU opps").

Also, I'm not sure why there was no response here or why it wasn't
merged, but if it helps, please have my:

Tested-by: Guilherme G. Piccoli <gpiccoli@igalia.com>

Thanks,


Guilherme


[0]
https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/commit/?h=release/qcomlt-4.14&id=2274c48c671

[1]
https://patchwork.kernel.org/project/linux-arm-msm/patch/1595253740-29466-6-git-send-email-loic.poulain@linaro.org/

[2]
https://lore.kernel.org/linux-arm-msm/20210527194455.782108-2-konrad.dybcio@somainline.org/