Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4346047pxb; Mon, 27 Sep 2021 15:07:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjUkyKDN4qlbu3lF76ITHNhcIggsqjN5vP3OHkKLXylGhzKU6BTcuRIE3zxG9/31YtyCXv X-Received: by 2002:a17:906:280f:: with SMTP id r15mr2681248ejc.559.1632780474769; Mon, 27 Sep 2021 15:07:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632780474; cv=none; d=google.com; s=arc-20160816; b=p8ILG3y6QXrVlUr7KXXW0IjkDJs/YS1zaPe7dN7Aqa5/LQ1tjObqB9d79tBQ+Ny5OY FvxYBRvMKT1T3vWTWKQGBcZWJwnTDt2Tidv6WTfIertvaXmVi36xHMvqk506Ad6qY5zk K1faYvxirZnm+t5pNIUChVXTdADHtOLGgACx7JoZhIc83+xAbV1i5DPhXoIjGK9Cq1cv C9aMibKuUswhY76s09HpmQ2AqCLLBYbFJTwXtz++4X/oqE6y7RvJ5zWOiebr6W5whSYy gzvCw3pvZ3RJa/kDZcQG4vvMtvOFWCcRhVPIdbbPqwmg95/DDygqJ6ORvej29XwwdRZe LS+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xF9PVD7Ak7b7GuU3fNOPsWCRtdNWIk6mhEkq/XYjRic=; b=IehK3UR/eWady0jopyOfqV3iWadUJejjZW488Az/zUh2j3bAq/B06it9JZpSiZ7T/r FwFUdKvDwkfGW5smR6JYW94Au/BswajksN+DuQxmdtylQNInTNvy9aupaYg+NUvx8zx5 2aJ5VY1XDzi72cS1OwChAdzGb8xBNu+/WLiA+swvG5eOMHYaTVBE/S8TeIJsj5cTE63P SmmnFpFAG7nUMrC/g8x4S+lE0p6b6vSXfZgF8HPFo/mB+2d0CwFmEmQ66fO7gMHCEyXz wb2LO6N9SBpIdtglnBrl6xeb3MtmJCCXZvCKPqF2fXJDOuGePGKZdysFQXA1eLOqhZ2i KNCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=FxboHMaY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kx11si19570063ejc.554.2021.09.27.15.07.31; Mon, 27 Sep 2021 15:07:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=FxboHMaY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238221AbhI0WFz (ORCPT + 99 others); Mon, 27 Sep 2021 18:05:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237829AbhI0WFU (ORCPT ); Mon, 27 Sep 2021 18:05:20 -0400 Received: from bombadil.infradead.org (unknown [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32E77C0613EB; Mon, 27 Sep 2021 15:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=xF9PVD7Ak7b7GuU3fNOPsWCRtdNWIk6mhEkq/XYjRic=; b=FxboHMaYTcRPE6zSL8vDgOO6A1 ZCQ+svz3/6fefs2Lhugt0Op+bLzO9Ihpq6RVFUUrAOCcQdsbZUPyuJFe8Hr+/aGTgEvWmXWEM8QT5 OC81f0y4y/mjk8iXsaLmjmQ+Mfv4eXQW+8+dpCL33TiCeFDnVbQM1Hd8+8Vu4EHTYfnXjz79LEhC8 FqHYGalj4UbkZE4F+apAdWMA+9bon9LkH0kzB8T1olRMvIYY3ye1qnjFAjWuHd6d+jk2lC8m8puJi C70TU3J3wPHgJS8n735wS9nVwvZnGKnwBALAkYCePhdYPwyD7z9L7nHiSxJpGZfHklm1In1nORh98 xdgDNseQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUyhC-004UJr-N6; Mon, 27 Sep 2021 22:01:58 +0000 From: Luis Chamberlain To: axboe@kernel.dk, bhelgaas@google.com, liushixin2@huawei.com, thunder.leizhen@huawei.com, lee.jones@linaro.org, geoff@infradead.org, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, jim@jtan.com, haris.iqbal@ionos.com, jinpu.wang@ionos.com, josh.h.morris@us.ibm.com, pjk1939@linux.ibm.com, tim@cyberelk.net, richard@nod.at, miquel.raynal@bootlin.com, vigneshr@ti.com Cc: linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain Subject: [PATCH v2 09/10] pf: add error handling support for add_disk() Date: Mon, 27 Sep 2021 15:01:56 -0700 Message-Id: <20210927220157.1069658-10-mcgrof@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210927220157.1069658-1-mcgrof@kernel.org> References: <20210927220157.1069658-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. Signed-off-by: Luis Chamberlain --- drivers/block/paride/pf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/paride/pf.c b/drivers/block/paride/pf.c index f471d48a87bc..380d80e507c7 100644 --- a/drivers/block/paride/pf.c +++ b/drivers/block/paride/pf.c @@ -962,7 +962,9 @@ static int __init pf_init_unit(struct pf_unit *pf, bool autoprobe, int port, if (pf_probe(pf)) goto out_pi_release; - add_disk(disk); + ret = add_disk(disk); + if (ret) + goto out_pi_release; pf->present = 1; return 0; -- 2.30.2