Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4346304pxb; Mon, 27 Sep 2021 15:08:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzN+qAJyucOGsz89iNK8PVocr8Ur0Bt1/+dVAGZzFszwQNrQp8jn0IcjAYN7DJaAj1GGOOL X-Received: by 2002:a17:906:3a4d:: with SMTP id a13mr2882494ejf.220.1632780494356; Mon, 27 Sep 2021 15:08:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632780494; cv=none; d=google.com; s=arc-20160816; b=G2o1nxkT0YnjkAGdo8nmnVWYO9jj1xU9xu350cM/tIQueGXOUTiiA9Ow+iWBWYOZi/ bYj8/7lAEXDZ1rPGHFbgdzkkzdAfa1xLVju3kzjZgZsmIkcBuWpmKLSGsCt0occdsB9i PGLHb8Tc+IAAeYNdUi5lXarXzvAaiehT4/4a+4H7BE6j38qKLoIGr08oZJFz4JVykTfU iixIxhoceSmuTh6fc4rIyffkg7hXcdQ8tcqhKPNHmul8gB4NDf7Qx9cRi/+BmGed+vIL Q7oDiqvILyEqhXqWAxm/0yx6rUff0W62Ht85iXMivmdoMuHzTcaYJe6OMwJ4Rc56O2BG m1cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=12aNYf4JHxFW0Gi214P/st+WALXaltwzcvDZhKyLh8I=; b=O1Df/3XMWa96MyeDuzwj7JW1qt2vi+XVh9/jFcWVR1xHpKILeaPvQgcMoFlhmAxdXQ HKNKEqzKRiUU/A2XBSs/XJ4/2/bzdjKa7H8Bni8mkoNgtt2xDvSCStCm0cf/t0R1av5n V2iQ0IwHWrFPvOThZ9GGMTa8gahgGeOup439Ua7YHCEClKPxg5Oy03i086RLrDc+429J S1B28BtfIBcbyBwqeoYZo86pinjLMXJGgeM2MAtWmNxG8Yj5kPzgr72zdi+B1xsFEi9E 1NHRT+09XcZA9FQV3yFcTMLa1r5uiqxe49Pn2HuAL55sNgHynZSyqEtAvprKVwkRMKnb 1XUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=eMCejdfA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e22si6873613ejl.449.2021.09.27.15.07.51; Mon, 27 Sep 2021 15:08:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=eMCejdfA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237511AbhI0WHR (ORCPT + 99 others); Mon, 27 Sep 2021 18:07:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238257AbhI0WGe (ORCPT ); Mon, 27 Sep 2021 18:06:34 -0400 Received: from bombadil.infradead.org (unknown [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AE54C051745; Mon, 27 Sep 2021 15:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=12aNYf4JHxFW0Gi214P/st+WALXaltwzcvDZhKyLh8I=; b=eMCejdfAb0OnOB6/IaIv32IYTO lZf95UD2Ein1I+q88HO/mWKNgHacbiOD76ESwgJtxQ2wiLPEL/GQO8iqmM6elSNfkp0jXg2xZzBti jtuNdVzwokFJVENq8jSnNdJXt58hPXbQ6PAys9og0Hy59KiBBEFFvSY3Ie19Lp62OriwTA5KmA+Cf KzHdl260QVtcXNu5s4RR/C7na5xsSgYNSHqfPMQ1V1iCjzrfAwdUjK2sXF9ZnZIBBlAZrQ1/wHOf0 yujstVQ7lm0oGgElD15PmYfMVmkynSsXUAplPkX71848og/8Z+Hr5asxybAWzGCT2uzN4kCTp44Yv zXFZtIUQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUyiF-004VIL-M8; Mon, 27 Sep 2021 22:03:03 +0000 From: Luis Chamberlain To: axboe@kernel.dk, efremov@linux.com, hch@lst.de Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain Subject: [PATCH v2 07/14] swim: simplify using blk_cleanup_disk() on swim_remove() Date: Mon, 27 Sep 2021 15:02:55 -0700 Message-Id: <20210927220302.1073499-8-mcgrof@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210927220302.1073499-1-mcgrof@kernel.org> References: <20210927220302.1073499-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We can simplify swim_remove() by using one call instead of two, just as other drivers do. Use that pattern. Signed-off-by: Luis Chamberlain --- drivers/block/swim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/swim.c b/drivers/block/swim.c index 7ccc8d2a41bc..f085ea982bb7 100644 --- a/drivers/block/swim.c +++ b/drivers/block/swim.c @@ -911,9 +911,8 @@ static int swim_remove(struct platform_device *dev) for (drive = 0; drive < swd->floppy_count; drive++) { del_gendisk(swd->unit[drive].disk); - blk_cleanup_queue(swd->unit[drive].disk->queue); + blk_cleanup_disk(swd->unit[drive].disk); blk_mq_free_tag_set(&swd->unit[drive].tag_set); - put_disk(swd->unit[drive].disk); } unregister_blkdev(FLOPPY_MAJOR, "fd"); -- 2.30.2