Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH 04/13] x86/fpu/xstate: Enumerate User Interrupts
 supervisor state
To:     Thomas Gleixner <tglx@linutronix.de>, <x86@kernel.org>
CC:     Tony Luck <tony.luck@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>,
        Jens Axboe <axboe@kernel.dk>,
        Christian Brauner <christian@brauner.io>,
        Peter Zijlstra <peterz@infradead.org>,
        Shuah Khan <shuah@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Jonathan Corbet <corbet@lwn.net>,
        Ashok Raj <ashok.raj@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "Gayatri Kammela" <gayatri.kammela@intel.com>,
        Zeng Guang <guang.zeng@intel.com>,
        "Dan Williams" <dan.j.williams@intel.com>,
        Randy E Witt <randy.e.witt@intel.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Ramesh Thomas <ramesh.thomas@intel.com>,
        <linux-api@vger.kernel.org>, <linux-arch@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20210913200132.3396598-1-sohil.mehta@intel.com>
 <20210913200132.3396598-5-sohil.mehta@intel.com> <87ilyqgbvn.ffs@tglx>
From:   Sohil Mehta <sohil.mehta@intel.com>
Message-ID: <c364342a-833d-0c68-c496-97a843e512a5@intel.com>
Date:   Mon, 27 Sep 2021 15:25:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.14.0
In-Reply-To: <87ilyqgbvn.ffs@tglx>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmxZajIzbjc4eTJUcGkrNDlnbno3U2U4SFAwNnJNM0k3QWp5TlhiZ20xc2Vw?=
 =?utf-8?B?d0pGcmNUSWMyOEpZVTkrMkJFU01HemFVdmtJNFNOdmtJNDQ2eThpVkNaTUFh?=
 =?utf-8?B?TmhPZEt4Y0JxVmFWSnM0TXR4eERobXVKak5IZndJQ21XZisyZzA0cGxpdkNS?=
 =?utf-8?B?UHJENVFtTDRPQVQ1UHdxTFJXRTNESC82dXhVQjNOei9NN0x2bHBUSkVXdWY2?=
 =?utf-8?B?Nk16eGVpa3N5SldpVloxTkliTURBek1LU0JiTitQejM1ZjVhd29rMWs3M1M4?=
 =?utf-8?B?UUdsWFIxVXV3eUJSZElFVEtSNEp4N0xWek5SNlFZVnlnRld5MFdtRjJzZnZ1?=
 =?utf-8?B?Y0RiNG9xb2loNlhPeUlOMGlpOFZrRVpFNSt2cHN6ZU9jSnRvdFBDd0xKODl2?=
 =?utf-8?B?WERtRW12MjdhSVlSWFVxWlNSeWhUK09MN0VQcG9PVWEzT0tOOVJOYXZiZE1i?=
 =?utf-8?B?amJSV1NxU1pXMk9lZXNQTmZvSjM0Q29PRU9hV214ZTRBUTRreUYvZnB3SVho?=
 =?utf-8?B?OWtUaktub1BTU2hYQTUzN0VqaC9sT29VM28veDNqTmR5UzlKaC80SnBkaTdM?=
 =?utf-8?B?bWtUOGt2N0llWWIrM1FabTBYZE5taVFFZU5DMC9rRzd1ZldpdDJUeC9reEwx?=
 =?utf-8?B?b0RsY0U3Mk9zeWxJbmxQTTI3N29sVm9EMFZ6elJaZjJ1VjdiVjU4cWNRbUhE?=
 =?utf-8?B?ZFlYQVJ3VG0yWUgvV2g5a1NEZGZRZVpYWThrZXMwQktjSyt5WlNWOWVJVkZI?=
 =?utf-8?B?VDBRUnk5YmVIVmhQajNwT0NHNEpBcnpUNHVrTVVYWDg0SWFaQnM4WXNzWXYx?=
 =?utf-8?B?N0huZEZBQnFjU3YvYS96b013cFlzb0hjYXF4UXp0ZHN6N08vSGY3WlpPTlpH?=
 =?utf-8?B?eHhleGUwTVlxMnhlMU5qZ29YNForR0R0YWZuaUoyWHR0d1FONGpxSXU0ajFr?=
 =?utf-8?B?U3B3NWlLZXY0aWxBZTZyaExLdFhpSHROdjJPaHJ0MkxXVnRVbktzMWEwRXJE?=
 =?utf-8?B?ZndycS9VY3I1Mk9JaHM3MUNCRitLWXBpaW9UbDNaY1FmZUZhblpiR2NaS29O?=
 =?utf-8?B?bVU5NnBrS0R0NjhLWDFyb083ZFBScEkvdDlKSXduTytFUDlsd2hkRW12OEtJ?=
 =?utf-8?B?aEo2VjBrZmhkbUoyRTlsZmZuandDQVJETVFxZGZMcmdCWCtDNGFZTXMwKzVB?=
 =?utf-8?B?K3FyMVFzbmRJd1JQNHI5WGEybDQ1eGM0Uzg3WlQ3ekZIWGdmejJjUGNMWVRq?=
 =?utf-8?B?d3FhS0RMVGgrMTI2NmpGL3lNenFLVVdLTGxsRDNQY3IvSmJiUEJwbmxsSGxG?=
 =?utf-8?B?OGVpeGFTYnN2QW90TjYvS1M1VXB5VzJWVlpDTEJJdlVnK0hPRmc2QkJqZy9w?=
 =?utf-8?B?TVlvTFgrbHJBS01xQUw3OTBUK3RrOUo2V0NZb0JvVWpvRXE5Q05LNVh1dFZS?=
 =?utf-8?B?MjBOMmkzaGFTTldSZTZxc2pCZmVISDhDQnRxVDR6RFBkRjA0bmpXS2pXY01p?=
 =?utf-8?B?d3RDa24xMzIvUDJDN2dHNjlUN2UrMHFEZW1HeisxWTFBbDExek1JOXFzZ3p3?=
 =?utf-8?B?M2gzTFJwTE5RTFdNcFh4L2VHZ2JHOGdFb3d5RTYrMG9TSlFOWE41eUFNNjFa?=
 =?utf-8?B?SWJKVXBRNVNCVnBKU3RJRm02ZnRNWWJ3ZU1pdmNSZ0dsWDNkRXNjcEpCYysw?=
 =?utf-8?B?UTB4cnJJSVl5YTczU0lMWUxnUkQ3WXVIeHpMeUlVbFhLYVg1UTdzTndtY3Fw?=
 =?utf-8?Q?eZGJnQaqjSXFjM+Cxeu/w8TWwrXzk53Va/kAU0R?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 43639e69-4f41-49dd-8515-08d98205ba42
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 22:25:36.3513
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ri+v75fpmOlxHFjtxpypDXDapNNYBrDhjJuXbBs45a/nN7Zhe7xAxpZTeEnzklN3oUjW8t6sgArxm2cbUxRaPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5214
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/23/2021 3:34 PM, Thomas Gleixner wrote:
> On Mon, Sep 13 2021 at 13:01, Sohil Mehta wrote:
>> Enable xstate supervisor support for User Interrupts by default.
> What means enabled by default? It's enabled when available and not
> disabled on the command line.

I'll remove it.

>> The user interrupt state for a task consists of the MSR state and the
>> User Interrupt Flag (UIF) value. XSAVES and XRSTORS handle saving and
>> restoring both of these states.
>>
>> <The supervisor XSTATE code might be reworked based on issues reported
>> in the past. The Uintr context switching code would also need rework and
>> additional testing in that regard.>
> What? Which issues were reported and if they have been reported then how
> is the provided code correct?


I apologize for causing this confusion. This comment was added a few 
months back when the PKRU and FPU code was being reworked. This comment 
is no longer valid.

>> +/*
>> + * State component 14 is supervisor state used for User Interrupts state.
>> + * The size of this state is 48 bytes
>> + */
>> +struct uintr_state {
>> +	u64 handler;
>> +	u64 stack_adjust;
>> +	u32 uitt_size;
>> +	u8  uinv;
>> +	u8  pad1;
>> +	u8  pad2;
>> +	u8  uif_pad3;		/* bit 7 - UIF, bits 6:0 - reserved */
> Please do not use tail comments. Also what kind of name is uif_pad3?
> Bitfields exist for a reason.


An internal version of this used bitfields. I was suggested that use of 
bitfields is not recommended for x86 code.

The name uif_pad3 is really ugly though. I'll change it to a bitfield 
next time.


Thanks,

Sohil