Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4360939pxb; Mon, 27 Sep 2021 15:31:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpg6wvT12SJG3LVlaHR/46ePvnSsrh17SR00OV3eAOhUuuzsRUS36qL852IVrNwoUyWcXr X-Received: by 2002:a17:90b:1e47:: with SMTP id pi7mr1590801pjb.135.1632781899290; Mon, 27 Sep 2021 15:31:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632781899; cv=none; d=google.com; s=arc-20160816; b=GoeU1uhPsU5+Et8E+Yqmwzo/FtT6LuiLpOABfbuuCSWSWXzQl5hBfT9wSk5xCyxnD0 PJ2tRkf9oeonIerk5yq68iL2vWigFrdGXUYiDDZ6ma0ZoHRbhzQL8DBXZ8oOIex45hXu i8+lQ62dNNrTn8ijLTBCKea22s6i3ff4zsDnjY95oWY/CJmHAo759V9x9dN8TxlBJjfx FswxU1gi2MGGrVHDjg3EKDIJzHuq2NiAoekJ9nQbO6SFViMtGDfv/ptZ6Hm+pp9XCszJ LF1rnL6+lAscZqYqvlCEi8jHEeE8iBfx7tY7hplDxxNgKACGEniANLzsI8ogHRIyWOcR +YJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=w9ezsQ1UkQZeC53NkFhy7B+1aNQW9TNDf1kl1c4M4R4=; b=ZWAjDx/UMx5j8/McIyLwsyIr2n8Dtd2nede2/t9rzrUkQ5b2GvEVNxAcK61oTTq6xp g4a3m2qTpgiXr4H3DQcH0LuW9WCdFr2FtS06Kdi9Mze5X05vgO65ZwLwQPENcLaAtJBo 54CQlpGDXw7EqGq/DGWSsLqn9Zwhykx8AgDzxtgrq8jVLEkSYUoX96Ssd095l06cVvRX fCpUDkfN3XKVKsjpWPkUvH4lNrSA0AguwDFODuc4wlZ7eedaM6qcANJXA6q5JQfu0eSK NWAmsmqjd/fFCSOboUFuG8ePVZL/Ad2D/Pzmk3yF/QFkpomjxF8uGXmXwYSp+I2ZSDh6 7mtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=Ffjc9XDV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lr2si1225787pjb.12.2021.09.27.15.31.27; Mon, 27 Sep 2021 15:31:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=Ffjc9XDV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237716AbhI0Wak (ORCPT + 99 others); Mon, 27 Sep 2021 18:30:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237679AbhI0Waj (ORCPT ); Mon, 27 Sep 2021 18:30:39 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D196EC061740 for ; Mon, 27 Sep 2021 15:29:00 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id d11so21021922ilc.8 for ; Mon, 27 Sep 2021 15:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=w9ezsQ1UkQZeC53NkFhy7B+1aNQW9TNDf1kl1c4M4R4=; b=Ffjc9XDV39XVuLIm8DJDvOIHuyWwHa/JDveqkJIq4EPQcwwF6i2IwXvqTayH1Zs+J0 zBBIHTdeujFBpyTsi7j+hLC6dG1lmzreXcsCJibD0ZHuJdAABtpVv3xmIelWiJg4Kiwx y74YiDFOoIziOuEp0bFDeka+WbUijbofv2enBSkOGJFIlEwWIxbA3L0TdOIDNHbvW4s3 UX5WZ/WNqYbm3RB9OdDLcEyEdxxaBYh8+Ce09lqPv5Y/yeoNEYf2H8gl9ZQ2Gx73QUuz bK1mNwQj3yvOA8l/cfkBNHF9G4YJ0ALLNw+vW7N07eAC0HlFOVJ1jxEY1tUin9ivF4Jg GOjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w9ezsQ1UkQZeC53NkFhy7B+1aNQW9TNDf1kl1c4M4R4=; b=rFrK/QPeXhQKO95NZnKqlmZjn/xIP0Fl0uwcpdq06M8wFaixU5AoTHihQsWymCBoyU yqiswe59Im2mBwCbrlUDBDiFbOag5pmM54Mz8sBhErnHGwdtWYiazVTzfQYlLA9zKrz/ yvqkvU4r3WgXGL/OIg22f9mfa8rG1o89EhLJD7uqGDBQff12UDgBz5LO23gWcNwzabyh BWe4OBpPXlhH2alZfCoRhnRepFRTiyyU+iq3xc786Lid9xKFHpYoGJ8Z0F9jEzCS0g87 7kgxmBvkjBvBuYUw1MlbjyrgybRnLHG0aUK6iouVgr/X6MYB+2nofecHpCwszojJLLPQ HMVA== X-Gm-Message-State: AOAM533cFHrclJYjK4sNOIuriVumX1mfREMb00fs4aJmqoFnXLwh4DrY 6fRj9lzBdiu6mlCW/fgdAZcthQ== X-Received: by 2002:a05:6e02:661:: with SMTP id l1mr1855976ilt.122.1632781740297; Mon, 27 Sep 2021 15:29:00 -0700 (PDT) Received: from [192.168.1.116] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id z25sm7614559iow.20.2021.09.27.15.28.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 15:28:59 -0700 (PDT) Subject: Re: [PATCH v4 6/6] nbd: add error handling support for add_disk() To: Luis Chamberlain , martin.petersen@oracle.com, jejb@linux.ibm.com, kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com, josef@toxicpanda.com Cc: hch@infradead.org, hare@suse.de, bvanassche@acm.org, ming.lei@redhat.com, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org, dm-devel@redhat.com, nbd@other.debian.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig References: <20210927215958.1062466-1-mcgrof@kernel.org> <20210927215958.1062466-7-mcgrof@kernel.org> From: Jens Axboe Message-ID: Date: Mon, 27 Sep 2021 16:28:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210927215958.1062466-7-mcgrof@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/27/21 3:59 PM, Luis Chamberlain wrote: > We never checked for errors on add_disk() as this function > returned void. Now that this is fixed, use the shiny new > error handling. Applied, thanks. -- Jens Axboe