Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210927015759.30855-1-xiongx18@fudan.edu.cn>
In-Reply-To: <20210927015759.30855-1-xiongx18@fudan.edu.cn>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Tue, 28 Sep 2021 00:32:27 +0200
Message-ID: <CAPDyKFoeA01fy6pAcSu2qaqs9U2VcgTLSvhzvNObhhprPdDT9g@mail.gmail.com>
Subject: Re: [PATCH v2] drivers/mmc: fix reference count leaks in moxart_probe
To:     Xin Xiong <xiongx18@fudan.edu.cn>
Cc:     linux-mmc <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        yuanxzhang@fudan.edu.cn, Xiyu Yang <xiyuyang19@fudan.edu.cn>,
        Xin Tan <tanxin.ctf@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 27 Sept 2021 at 04:00, Xin Xiong <xiongx18@fudan.edu.cn> wrote:
>
> The issue happens in several error handling paths on two refcounted
> object related to the object "host" (dma_chan_rx, dma_chan_tx). In
> these paths, the function forgets to decrement one or both objects'
> reference count increased earlier by dma_request_chan(), causing
> reference count leaks.
>
> Fix it by balancing the refcounts of both objects in some error
> handling paths.
>
> Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
> Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>

The code looks good to me! However, checkpatch is complaining about
the format. Please run it and fixup the reported warnings/errors.

Kind regards
=C3=9Cffe


> ---
>  drivers/mmc/host/moxart-mmc.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.=
c
> index 6c9d38132..e27ab3446 100644
> --- a/drivers/mmc/host/moxart-mmc.c
> +++ b/drivers/mmc/host/moxart-mmc.c
> @@ -621,6 +621,14 @@ static int moxart_probe(struct platform_device *pdev=
)
>                         ret =3D -EPROBE_DEFER;
>                         goto out;
>                 }
> +        if (!IS_ERR(host->dma_chan_tx)) {
> +            dma_release_channel(host->dma_chan_tx);
> +            host->dma_chan_tx =3D NULL;
> +        }
> +        if (!IS_ERR(host->dma_chan_rx)) {
> +            dma_release_channel(host->dma_chan_rx);
> +            host->dma_chan_rx =3D NULL;
> +        }
>                 dev_dbg(dev, "PIO mode transfer enabled\n");
>                 host->have_dma =3D false;
>         } else {
> @@ -675,6 +683,10 @@ static int moxart_probe(struct platform_device *pdev=
)
>         return 0;
>
>  out:
> +    if (!IS_ERR_OR_NULL(host->dma_chan_tx))
> +        dma_release_channel(host->dma_chan_tx);
> +    if (!IS_ERR_OR_NULL(host->dma_chan_rx))
> +        dma_release_channel(host->dma_chan_rx);
>         if (mmc)
>                 mmc_free_host(mmc);
>         return ret;
> --
> 2.25.1
>