Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        "Saleem, Shiraz" <shiraz.saleem@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        "Ertman, David M" <david.m.ertman@intel.com>,
        Shannon Nelson <snelson@pensando.io>,
        "Richard Cochran" <richardcochran@gmail.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] igc: fix PTP dependency
Thread-Topic: [PATCH] igc: fix PTP dependency
Thread-Index: AQHXs6IOGDZvzKltAUSzD1rjhyQtZ6u4eKPA
Date:   Mon, 27 Sep 2021 22:35:34 +0000
Message-ID: <CO1PR11MB5089ACD68BA016202174D9A2D6A79@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20210927131730.1587671-1-arnd@kernel.org>
In-Reply-To: <20210927131730.1587671-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7P6lBvBt9Alxa0X8TO9t25/TGKzxN/YZQNFy6WmHwC3fCZQb29yBR+GAvKJk?=
 =?us-ascii?Q?fTd+1JKfjc/VonIefx8ap3YTkKnWKAFRLWvE386xGbLRp7vdIWQbTtiNtDJG?=
 =?us-ascii?Q?QqBBa1rnHpSbvq+YsFoA+UeVOQPulnZrkIFV5CDG0NWvvNLS8V8nUuqCvtX0?=
 =?us-ascii?Q?pHIpLB1Hh6vWABS85qYK2jgQzIqNR3ojhVl9rqnBeG01Q7EWt+VLc6mTc+j/?=
 =?us-ascii?Q?8bNdjgAxILz9siolUhpVnoxsuNA8zFmhfDlFml/DgtWRvgsEAST/6e/EmgDF?=
 =?us-ascii?Q?F7Ti7gmYr5w5cZSOmx8u+mSL3fed4VOfIR+igenWVgwq6jKXGFo8kEKpx+lz?=
 =?us-ascii?Q?/hxJrtscL8ZSNV/K9nZZbKWXvio19YytrcDfCOBM2XiTKK9CU/PYbEjNPiZY?=
 =?us-ascii?Q?KHpM1HR6sfDcE+UhvbdfZRaWoByMh5BgWjWyG9d2Nt3l+q1qdf1lFk9P/Fot?=
 =?us-ascii?Q?Fax/vWC39hZigXP6Vfpwboy4GU7pxOtL4cJC2hFPaUsflSg97YOuxbNO7d9O?=
 =?us-ascii?Q?W1ACGL7bUn4aOf+9dbuAr8Tiv6poZRRFCjK7dLiaY99RiiV6hZqrxcQlkoX0?=
 =?us-ascii?Q?8JLj991yDdQcvzfecceYbO3hD49yI0ayBP2EAazJbdFmoDsIq2Mia6Bof9XX?=
 =?us-ascii?Q?j1yoX5+W45U2PksQaXjkOPhEdDZ80m57aQ9xDzTX+ZSkyueS8IqAcylA4bhl?=
 =?us-ascii?Q?1jOZXEyIpRpyviJP89aGhTpzFrRn+AjF7az5WAfsJnmA6PbVL3sBJE+47SBw?=
 =?us-ascii?Q?39hFiJ7Uo+OR0Ump27z07FIAmQOlEMi3t20XlQduxYzgqFvv8Q4dHyI/6JD0?=
 =?us-ascii?Q?rxXM3dSJWb4qmR4PgvFMsfQQVZTQxmWbaj/RE/3s+w8Vai77HFmslwwkCdSV?=
 =?us-ascii?Q?MG02esQpO+Ql2zF1uYgNPCqrzHeCnf5Yz+Y9v2U6sQwGF43RftGKQ62UrZBb?=
 =?us-ascii?Q?mVp+bRDzYlNo3GJcGKabGZJIadsNcA8jm1MkCzBjR9uNPwa3dGNbhXah1U0Y?=
 =?us-ascii?Q?91BEJUikL7ecVUSgRD/gDapKKnUtmFwn2yi2xo6v3XoHSOX2bN/ahtogehaU?=
 =?us-ascii?Q?oBfDWeIGqFs8UKLpGBwFeVMbSnzo2Dek2nq6aBcqIqp1tAoJWEILX6marK0R?=
 =?us-ascii?Q?99S3V3+fJtjiULnb+87q5M98qFWA78K/u+1kqKbGGRTJrYiWaxL6UZNiPf5Y?=
 =?us-ascii?Q?sO4p+UUvUZNItt0/6RqDRU/mYTUzZ2yYh4BK4KJ7cd9TUlNEsDIUB9R/G8eg?=
 =?us-ascii?Q?gONnJfoLdCCLm6CGpjHltllwTPeJbqguwtQ/OOZQv96R40Ck5OyVWvLdJZBM?=
 =?us-ascii?Q?bZk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e3dff11-120f-4f47-b58b-08d982071f03
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2021 22:35:34.4373
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eapbzNw1hEy/lO+GmuI4e0Vhm6uKI4+BxrPGL1bH5Y/ozK1dJKJlSTqHK9LyUInbcZEhEAZXHaMCgYqLiCohYKfFjwScGe5CSVeS8AM4XQg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4633
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Monday, September 27, 2021 6:17 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Jaku=
b
> Kicinski <kuba@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>; Keller, Jacob E
> <jacob.e.keller@intel.com>; Saleem, Shiraz <shiraz.saleem@intel.com>; Kur=
t
> Kanzenbach <kurt@linutronix.de>; Ertman, David M
> <david.m.ertman@intel.com>; Shannon Nelson <snelson@pensando.io>;
> Richard Cochran <richardcochran@gmail.com>; Vladimir Oltean
> <vladimir.oltean@nxp.com>; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] igc: fix PTP dependency
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> The igc driver was accidentally left out of the Kconfig rework for PTP,
> it needs the same dependency as the others:
>=20
> arm-linux-gnueabi-ld: drivers/net/ethernet/intel/igc/igc_main.o: in funct=
ion
> `igc_tsync_interrupt':
> igc_main.c:(.text+0x1b288): undefined reference to `ptp_clock_event'
> arm-linux-gnueabi-ld: igc_main.c:(.text+0x1b308): undefined reference to
> `ptp_clock_event'
> arm-linux-gnueabi-ld: igc_main.c:(.text+0x1b8cc): undefined reference to
> `ptp_clock_event'
> arm-linux-gnueabi-ld: drivers/net/ethernet/intel/igc/igc_ethtool.o: in fu=
nction
> `igc_ethtool_get_ts_info':
>=20
> Fixes: e5f31552674e ("ethernet: fix PTP_1588_CLOCK dependencies")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks!

-Jake

> ---
>  drivers/net/ethernet/intel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/net/ethernet/intel/Kconfig
> b/drivers/net/ethernet/intel/Kconfig
> index b0b6f90deb7d..ed8ea63bb172 100644
> --- a/drivers/net/ethernet/intel/Kconfig
> +++ b/drivers/net/ethernet/intel/Kconfig
> @@ -335,6 +335,7 @@ config IGC
>  	tristate "Intel(R) Ethernet Controller I225-LM/I225-V support"
>  	default n
>  	depends on PCI
> +	depends on PTP_1588_CLOCK_OPTIONAL
>  	help
>  	  This driver supports Intel(R) Ethernet Controller I225-LM/I225-V
>  	  family of adapters.
> --
> 2.29.2