Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4375417pxb; Mon, 27 Sep 2021 15:57:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBBnE3tde0f6MDcL8Id1UcVTZHtTjQex8O7KwqP91oXZB9x2PilNzOpFrXG8xXCcud+Rzq X-Received: by 2002:a17:906:fa90:: with SMTP id lt16mr3049353ejb.567.1632783420948; Mon, 27 Sep 2021 15:57:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632783420; cv=none; d=google.com; s=arc-20160816; b=ik4dwAR/brZjGEPMKy8QVm4rBAPDcpYvRmexZTNZtCD8kuMTiIrqgVV4vHM+fiLJCK yWeOjA0lSZNTpdDqSV4P/B05FVhmdRq8rk59JS2n3vWLOYQG0P3l3PeTXorQa1pGOYqi Mu0NU4R/xrcwYawDjZHJkSImis/NR6WBPkQIksceBx7mnZN5vk7Fd0/clxFuEcGYFDY9 vo8pa+rWLLbYrE+DcmelLdFmWp5L7SYWnVI17GtzvSVL4eG1DQQ9DuF8eK3IObN4UfJj +iuaBMaY2yxP/xJiUVY5Pbaz3pSW7c76gPc0T/iMp6YY+ecTSK8aGcOO0oyAYN6pPAte 2lXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=lbtHxjRemmXiBIhG0GW8nlURXNpwyPs370Xxo7AeQQk=; b=L+Br0+bNxL2dQMiU65PAYBHnNaAmaB0GMBHGFzrw/RmRb0Gjy1nSGVX0d/T6SHaET6 k0KE0NaMMkH5A/iAtp7uOeKzyooljZXMK+cThX6r+18TACQzyKraY77FxjLp1dvI9UQP p3Rd+gB4ka2ZgthFVPQUWuMUyBAqA8iHNllSXTWsdnXyrzlDBDOjJT/CXr0HC0igJhpB CVXBz+TIxzTi42xUHY1oAFk4bopqad93vrlRlBmkTqP5oSfy/RsklFwAmxyjP/gxU4/Q vytAv0chCiJBgYb1RuLjUP+pi7V1jIjXNfSluWGS/f22KQJtXWgUO40/ptlK098eYGeE ys2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YZ2VTmSC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l13si3264945eji.536.2021.09.27.15.56.27; Mon, 27 Sep 2021 15:57:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YZ2VTmSC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238027AbhI0Ww3 (ORCPT + 99 others); Mon, 27 Sep 2021 18:52:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237887AbhI0Ww2 (ORCPT ); Mon, 27 Sep 2021 18:52:28 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 664D0C061604; Mon, 27 Sep 2021 15:50:49 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id l8so27872768edw.2; Mon, 27 Sep 2021 15:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lbtHxjRemmXiBIhG0GW8nlURXNpwyPs370Xxo7AeQQk=; b=YZ2VTmSCUUUwt9GaX+TF009NFPIKAVOBMPTgS3jayY1GsTxjk0eyD6zyo3KSDp2ffd 15/G6kf8ngNImvfP+WO3GwmQFWGvbVqsojWS5PsZGnhvbMFfwNf8hSswllXfjJWH5bOE iuZL52rFsekbaWI4lIXdwtbN7zFzDlTDgpjQpSXSpN15NE9HDPayoVqneLYjbtMi9s4X ps/Z9ps2NUVxdYW6SyynTklGHbpuzsS5CawTlfWbAl6o8ozZlHhvGY0lDmYlvpfHfCUs GD4OE0hwIQQOcnCDaiwMPQ95SiG9tHFH0M56s31hXESkpNn5z5fJT/O3fmOeyg3xh3Pb IunQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lbtHxjRemmXiBIhG0GW8nlURXNpwyPs370Xxo7AeQQk=; b=5XKaGDkvcoVJlL9pe3UVR14KU1IbdbEqhoa2oXQb8YbzBmP/uHfSlLrss1J+KnyQaN QiSbvFt/kc2xkXE+rFV/Fkq6j7km1NXTOWm/+jZRciq7/X8ofqwnF3pSHNnofBclieLL lgqde1932/1h0ObLfD3ckb79qj2JeDiPB7vGTciW/Q8CPhfFN5H7w8N3ioEeI09LpkJo x7LfCmfhOjDZGYeH1bqEKlknECJVJ5kA2gvvm04hm6QGe9+bNLjoCDnTwvB/hc/9qXJK AY/NCYnsAlrQR/vSa+6B8fMVBPYl9zyLMnHbIxNQHGpSnXmQ6U3VWOV8ivIkLcVxMknZ 4BwQ== X-Gm-Message-State: AOAM533e0WmKIMXdRejW6+kRdES6HJmsBpTPy7fVrLEbYjlrJ7sBxIbg b5eAu9JD0RrwHjpANgIHL1pRImmKJBiraOkjycM= X-Received: by 2002:aa7:d592:: with SMTP id r18mr3465274edq.172.1632783048036; Mon, 27 Sep 2021 15:50:48 -0700 (PDT) MIME-Version: 1.0 References: <20210927220110.1066271-1-mcgrof@kernel.org> <20210927220110.1066271-7-mcgrof@kernel.org> In-Reply-To: <20210927220110.1066271-7-mcgrof@kernel.org> From: Max Filippov Date: Mon, 27 Sep 2021 15:50:36 -0700 Message-ID: Subject: Re: [PATCH v2 06/15] xtensa/platforms/iss/simdisk: add error handling support for add_disk() To: Luis Chamberlain Cc: Jens Axboe , justin@coraid.com, Geert Uytterhoeven , Ulf Hansson , hare@suse.de, Tejun Heo , philipp.reisner@linbit.com, lars.ellenberg@linbit.com, Jeff Dike , Richard Weinberger , Anton Ivanov , johannes.berg@intel.com, chris.obbard@collabora.com, krisman@collabora.com, zhuyifei1999@gmail.com, thehajime@gmail.com, Chris Zankel , tim@cyberelk.net, "open list:TENSILICA XTENSA PORT (xtensa)" , linux-um@lists.infradead.org, "open list:M68K ARCHITECTURE" , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 27, 2021 at 3:01 PM Luis Chamberlain wrote: > > We never checked for errors on add_disk() as this function > returned void. Now that this is fixed, use the shiny new > error handling. > > Signed-off-by: Luis Chamberlain > --- > arch/xtensa/platforms/iss/simdisk.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) Acked-by: Max Filippov -- Thanks. -- Max