Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 02:54:49 +0200
From:   Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     kishon@ti.com, tjoseph@cadence.com, lorenzo.pieralisi@arm.com,
        robh@kernel.org, bhelgaas@google.com, linux-omap@vger.kernel.org,
        linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PCI: j721e: Fix an error handling path in
 'j721e_pcie_probe()'
Message-ID: <YVJn2SHvRcTO2tY5@rocinante>
References: <db477b0cb444891a17c4bb424467667dc30d0bab.1624794264.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <db477b0cb444891a17c4bb424467667dc30d0bab.1624794264.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk

Hi Christophe,

Thank you for sending the patch over!

Just a tiny nit-pick: there is no need to surround function names in single
quotes in the subject and in the commit message.

> If an error occurs after a successful 'cdns_pcie_init_phy()' call, it must
> be undone by a 'cdns_pcie_disable_phy()' call, as already done above and
> below.

Here, in the above sentence, you could simply mention that this is needed
for the device to be correctly powered down should there be an error, and
reference to the "above" and "below" code.

> Update the 'goto' to branch at the correct place of the error handling
> path.
> 
> Fixes: 49e0efdce791 ("PCI: j721e: Add support to provide refclk to PCIe connector")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/pci/controller/cadence/pci-j721e.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
> index 35e61048e133..8933db6ab1af 100644
> --- a/drivers/pci/controller/cadence/pci-j721e.c
> +++ b/drivers/pci/controller/cadence/pci-j721e.c
> @@ -424,7 +424,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
>  		ret = clk_prepare_enable(clk);
>  		if (ret) {
>  			dev_err(dev, "failed to enable pcie_refclk\n");
> -			goto err_get_sync;
> +			goto err_pcie_setup;
>  		}
>  		pcie->refclk = clk;

Thank you!

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

	Krzysztof