Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] memory: tegra186-emc: Fix error return code in
 tegra186_emc_probe()
To:     Mikko Perttunen <cyndis@kapsi.fi>, <linux-kernel@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>
CC:     <krzysztof.kozlowski@canonical.com>, <mperttunen@nvidia.com>
References: <20210927075107.2882569-1-yangyingliang@huawei.com>
 <09e28d31-881f-acd0-33d0-565bdc9475ae@kapsi.fi>
From:   Yang Yingliang <yangyingliang@huawei.com>
Message-ID: <19c2733a-7393-8a65-e188-65c4d750eaa7@huawei.com>
Date:   Tue, 28 Sep 2021 08:59:02 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <09e28d31-881f-acd0-33d0-565bdc9475ae@kapsi.fi>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hi,

On 2021/9/27 16:52, Mikko Perttunen wrote:
> On 9/27/21 10:51 AM, Yang Yingliang wrote:
>> Return the error code when command fails.
>>
>> Fixes: 13324edbe926 ("memory: tegra186-emc: Handle errors in BPMP 
>> response")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>>   drivers/memory/tegra/tegra186-emc.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/memory/tegra/tegra186-emc.c 
>> b/drivers/memory/tegra/tegra186-emc.c
>> index abc0c2eeaab7..16351840b187 100644
>> --- a/drivers/memory/tegra/tegra186-emc.c
>> +++ b/drivers/memory/tegra/tegra186-emc.c
>> @@ -198,6 +198,7 @@ static int tegra186_emc_probe(struct 
>> platform_device *pdev)
>>           goto put_bpmp;
>>       }
>>       if (msg.rx.ret < 0) {
>> +        err = msg.rx.ret;
>>           dev_err(&pdev->dev, "EMC DVFS MRQ failed: %d (BPMP error 
>> code)\n", msg.rx.ret);
>>           goto put_bpmp;
>>       }
>>
>
> Good catch, but we shouldn't return msg.rx.ret since it is a BPMP 
> error code that doesn't necessarily map directly to a Linux error 
> code. So we should set err to something like -EINVAL instead. Please 
> update, or if you'd prefer, I can fix it.
I can send a v2 later.
>
> Mikko
> .