Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4539113pxb; Mon, 27 Sep 2021 20:48:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxy3amaX2ERv4j+0084FuL0qT3mDKTDwFJueGkA6Qz9jEUFL0HHquWW1bXBKIzQ+a+y4goZ X-Received: by 2002:a17:906:2bc3:: with SMTP id n3mr4154679ejg.548.1632800906011; Mon, 27 Sep 2021 20:48:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632800906; cv=none; d=google.com; s=arc-20160816; b=0g9YuwJk9YStfw7y5A+CgMYIs5Ew/904IHNZSZ6Let3ZHmaUippvLIZBKB+G5ZuHOk YlYGSouKwaE4qNhr5HOnlHGMnlbzHfHgBPhWELAcHLcQSbOCTRv3TFOxBEmfCu8HsaUt iZwsbZt5NwgwtXbR2Kcu7LLGARy6txQxTx2CxskJP8Wx1qXUAVhRNGe7riYhrkBtl1vp r7EE6N0PBV0hwEOmX1b/caCgsfZHgMcJKmTTC3AAKkwEIoBOeOV78l3MNW3MEhOgahRy cm0UoAdMZFoDroK/pUyVP/nKHkaHu/1y9qMckcS6zi19NxwcTvuhED17CM+bWiOdJyFz YcLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=z3bAoCya8Y7Dh6QkxEXxat/NHosu9KdF5sqakVDClzs=; b=B1yPbsJ8QUOXnrqIanAbdAlA2GfYBCDR4sEBfA5+k9YyA7f5FnHsc4GDSVcPqJfBfN 0M1dW5lVEifgXHnXP2fmmy4bq4bcJQisEbacsEKGC3DCCk5GWHHtBcKmzp2OqlX8WihC IkwaWvffClB2Rupx5X9t3uS4g15H5MqLC0lv8BTfmh+aC1yEcGmacDgKZgr7YumeGYlp PMc5POdIOwK910SG/Al0/wdvGUKUL8oya4JrDREhYevGLD3ayRdvlXAj7GKEiZMOAOge Ga/P9WCJKSu46iiC/3w2MmhYJGwwQE3nZbdrCjDI+LKH6FkBiB6+Vey5TdtfcfFR/lwz TTDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=iXG2vit4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z29si21879542edl.497.2021.09.27.20.48.02; Mon, 27 Sep 2021 20:48:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=iXG2vit4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238875AbhI1DsU (ORCPT + 99 others); Mon, 27 Sep 2021 23:48:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238849AbhI1DsT (ORCPT ); Mon, 27 Sep 2021 23:48:19 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D92EEC061575 for ; Mon, 27 Sep 2021 20:46:40 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id 203so17716246pfy.13 for ; Mon, 27 Sep 2021 20:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=z3bAoCya8Y7Dh6QkxEXxat/NHosu9KdF5sqakVDClzs=; b=iXG2vit4ZhMA5CWRsWzZE095T5xH65GnTeu1OKkTXELLzVC3OS/Qwv0vuI546RGMOv KjdQ6beOQZH881Hj17lcsBIHeVX9SrB4UgK5WANszpWjaQRnk6X0SbgHBV9FSrpVVKtQ 8O8msarkOX2cdb+YgQ4/rG0nA4w65Qxm4Z5Rs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=z3bAoCya8Y7Dh6QkxEXxat/NHosu9KdF5sqakVDClzs=; b=IAKPAOjPv4OXsqS2SW1AOI1Huteadev4ilLHC4otDBsuKpB3AKpWxggTlUodHWwbXb g9AwdSfVd6wv7G3pzYVMKITvRi+zvzZeFBJIoxbd5qLf1n5J70jHkVqvSynuwXGuYIKW vAjoBL67iQsF/Ky3hcRoEO06ccM05kXAlANmBOvlI/JS5x/Byecx0Y9FOfQVIZ+9ArfG 6Yg6kj3as/XJr8xw4G7UIhNcDMOUP2kxA6iG9oE5BVlgzdrJVABpEUfouqLqv5D9ZtWM zhzyCsz5JKGnQTIktYlOXGSOggqnOBlsM7BmjrW5R2U32P12GmnJDEKlTgG4nHXKVEtK 3pmw== X-Gm-Message-State: AOAM531F9NxRshgnNt5u3ag4m+c8ldBls7JFb7rtB9rpDFMVQqrAc89c 3O9gZL+MagUL+Bvk2BmTuODo6A== X-Received: by 2002:a62:dd94:0:b0:442:bb03:9663 with SMTP id w142-20020a62dd94000000b00442bb039663mr3197190pff.0.1632800800438; Mon, 27 Sep 2021 20:46:40 -0700 (PDT) Received: from senozhatsky.flets-east.jp ([2409:10:2e40:5100:481c:a10e:b908:28fe]) by smtp.gmail.com with ESMTPSA id f205sm19411980pfa.92.2021.09.27.20.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 20:46:40 -0700 (PDT) From: Sergey Senozhatsky To: Tomasz Figa , Hans Verkuil Cc: Marek Szyprowski , Mauro Carvalho Chehab , Ricardo Ribalda , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: [PATCH] media: videobuf2: always set buffer vb2 pointer Date: Tue, 28 Sep 2021 12:46:34 +0900 Message-Id: <20210928034634.333785-1-senozhatsky@chromium.org> X-Mailer: git-send-email 2.33.0.685.g46640cef36-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We need to always link allocated vb2_dc_buf back to vb2_buffer because we dereference vb2 in prepare() and finish() callbacks. Signed-off-by: Sergey Senozhatsky --- drivers/media/common/videobuf2/videobuf2-dma-contig.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/common/videobuf2/videobuf2-dma-contig.c b/drivers/media/common/videobuf2/videobuf2-dma-contig.c index b052a4e36961..38767791955d 100644 --- a/drivers/media/common/videobuf2/videobuf2-dma-contig.c +++ b/drivers/media/common/videobuf2/videobuf2-dma-contig.c @@ -600,6 +600,7 @@ static void *vb2_dc_get_userptr(struct vb2_buffer *vb, struct device *dev, buf->dev = dev; buf->dma_dir = vb->vb2_queue->dma_dir; + buf->vb = vb; offset = lower_32_bits(offset_in_page(vaddr)); vec = vb2_create_framevec(vaddr, size); @@ -788,6 +789,8 @@ static void *vb2_dc_attach_dmabuf(struct vb2_buffer *vb, struct device *dev, return ERR_PTR(-ENOMEM); buf->dev = dev; + buf->vb = vb; + /* create attachment for the dmabuf with the user device */ dba = dma_buf_attach(dbuf, buf->dev); if (IS_ERR(dba)) { -- 2.33.0.685.g46640cef36-goog