Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 03:55:48 +0000
To:     Keith Busch <kbusch@kernel.org>, linux-nvme@lists.infradead.org,
        sagi@grimberg.me, hch@lst.de
From:   Orlando Chamberlain <redecorating@protonmail.com>
Cc:     linux-kernel@vger.kernel.org, axboe@kernel.dk,
        Sven Peter <sven@svenpeter.dev>,
        Aditya Garg <gargaditya08@live.com>
Reply-To: Orlando Chamberlain <redecorating@protonmail.com>
Subject: Re: [PATCHv2] nvme: add command id quirk for apple controllers
Message-ID: <38101793-e0b9-ecf4-d235-465cb8e334b3@protonmail.com>
In-Reply-To: <20210927154306.387437-1-kbusch@kernel.org>
References: <20210927154306.387437-1-kbusch@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 28/9/21 01:43, Keith Busch wrote:
> Some apple controllers use the command id as an index to implementation
> specific data structures and will fail if the value is out of bounds.
> The nvme driver's recently introduced command sequence number breaks
> this controller.
>=20
> Provide a quirk so these spec incompliant controllers can function as
> before. The driver will not have the ability to detect bad completions
> when this quirk is used, but we weren't previously checking this anyway.
>=20
> The quirk bit was selected so that it can readily apply to stable.
>=20
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D214509
> Cc: Sven Peter <sven@svenpeter.dev>
> Reported-by: Orlando Chamberlain <redecorating@protonmail.com>
> Reported-by: Aditya Garg <gargaditya08@live.com>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
> v1->v2: fixed logical bug checking the quirk setting
>=20
>  drivers/nvme/host/core.c | 4 +++-
>  drivers/nvme/host/nvme.h | 6 ++++++
>  drivers/nvme/host/pci.c  | 3 ++-
>  3 files changed, 11 insertions(+), 2 deletions(-)

Works on my MacBookPro16,1.

Tested-by: Orlando Chamberlain <redecorating@protonmail.com>