Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 08:49:10 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        linuxarm@huawei.com, mauro.chehab@huawei.com,
        Arnd Bergmann <arnd@arndb.de>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: hi6421-spmi-pmic: cleanup drvdata
Message-ID: <YVLI9sXN2R/IHSzq@google.com>
References: <YUsuZaMJoEMHkxgG@google.com>
 <0cc63f19506ea78d3a1c111774c97bbbc1a9a292.1632812219.git.mchehab+huawei@kernel.org>
 <YVLA14jbwqXjNM2f@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YVLA14jbwqXjNM2f@kroah.com>
Precedence: bulk

On Tue, 28 Sep 2021, Greg Kroah-Hartman wrote:

> On Tue, Sep 28, 2021 at 08:58:19AM +0200, Mauro Carvalho Chehab wrote:
> > There are lots of fields in struct hi6421_spmi_pmic that aren't
> > used. As a matter of fact, only regmap is needed.
> > 
> > So, drop the struct as a whole, and just set the regmap as
> > the drvdata.
> > 
> > Acked-by: Mark Brown <broonie@kernel.org>
> > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> 
> As everyone else acked this, any objection for me to just take this in
> my char-misc tree?
> 
> Otherwise, whoever else want to take it:
> 
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

If you do end up taking it, you'll have to convert my Ack.

Although, I'm probably in a better position to take it TBH.

Happy with either.  You decide.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog