Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 10:57:46 +0300
From:   Pekka Paalanen <ppaalanen@gmail.com>
To:     Rob Clark <robdclark@gmail.com>
Cc:     dri-devel <dri-devel@lists.freedesktop.org>,
        "moderated list:DMA BUFFER SHARING FRAMEWORK" 
        <linaro-mm-sig@lists.linaro.org>, Daniel Vetter <daniel@ffwll.ch>,
        Christian =?UTF-8?B?S8O2bmln?= <ckoenig.leichtzumerken@gmail.com>,
        Michel =?UTF-8?B?RMOkbnplcg==?= <michel@daenzer.net>,
        Rob Clark <robdclark@chromium.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Gustavo Padovan <gustavo@padovan.org>,
        Christian =?UTF-8?B?S8O2bmln?= <christian.koenig@amd.com>,
        "open list:SYNC FILE FRAMEWORK" <linux-media@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 8/9] dma-buf/sync_file: Add SET_DEADLINE ioctl
Message-ID: <20210928105746.02304ece@eldfell>
In-Reply-To: <CAF6AEGudjfgN+x_KxyED+1XBod7yNqLN43or7vs8h7UKQmzK7Q@mail.gmail.com>
References: <20210903184806.1680887-1-robdclark@gmail.com>
        <20210903184806.1680887-9-robdclark@gmail.com>
        <20210927114201.1f8fdc17@eldfell>
        <CAF6AEGudjfgN+x_KxyED+1XBod7yNqLN43or7vs8h7UKQmzK7Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/Rs768WPBICg6UtwLCHHF1rS";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/Rs768WPBICg6UtwLCHHF1rS
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Mon, 27 Sep 2021 07:36:05 -0700
Rob Clark <robdclark@gmail.com> wrote:

> On Mon, Sep 27, 2021 at 1:42 AM Pekka Paalanen <ppaalanen@gmail.com> wrot=
e:
> >
> > On Fri,  3 Sep 2021 11:47:59 -0700
> > Rob Clark <robdclark@gmail.com> wrote:
> > =20
> > > From: Rob Clark <robdclark@chromium.org>
> > >
> > > The initial purpose is for igt tests, but this would also be useful f=
or
> > > compositors that wait until close to vblank deadline to make decisions
> > > about which frame to show.
> > >
> > > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > > ---
> > >  drivers/dma-buf/sync_file.c    | 19 +++++++++++++++++++
> > >  include/uapi/linux/sync_file.h | 20 ++++++++++++++++++++
> > >  2 files changed, 39 insertions(+)

...

> > > diff --git a/include/uapi/linux/sync_file.h b/include/uapi/linux/sync=
_file.h
> > > index ee2dcfb3d660..f67d4ffe7566 100644
> > > --- a/include/uapi/linux/sync_file.h
> > > +++ b/include/uapi/linux/sync_file.h
> > > @@ -67,6 +67,18 @@ struct sync_file_info {
> > >       __u64   sync_fence_info;
> > >  };
> > >
> > > +/**
> > > + * struct sync_set_deadline - set a deadline on a fence
> > > + * @tv_sec:  seconds elapsed since epoch
> > > + * @tv_nsec: nanoseconds elapsed since the time given by the tv_sec
> > > + * @pad:     must be zero =20
> >
> > Hi Rob,
> >
> > I think you need to specify which clock this timestamp must be in.
> >
> > Which epoch? Sounds a bit like CLOCK_REALTIME to me which would not
> > make sense. =20
>=20
> It should be monotonic.. same clock as is used for vblank timestamps,
> which I assume that would be the most straightforward thing for
> compositors to use

Yes, it would. Just need to document that. :-)


Thanks,
pq

--Sig_/Rs768WPBICg6UtwLCHHF1rS
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAmFSyvoACgkQI1/ltBGq
qqeyDg//TgGFseKo6XsdPl96lErZgm+vJZuY8rYpdTY7P6E0EsQ9Vtq3/++8mAIT
7t6mRK8jHVBS/bGQdEtBVnhMW2A63qSZTCPTjNmaAyhFfc0L866fU+QV7MJViv3U
h6G9sbm3dDiMo76ZdWjSTTLSmNcEiH1gk9mUSbRUZjDBC+uRcnyKy3scGAgrfV1H
9vllcGoKzjIiDnN1sAh9iNOj43bVOkMa4tyIUm26AQn72PJ3OH8EZDJrPmUdkt6P
gJl4Xp5p48igf7J4uJG1zUEKGfP9zEw7q8RBJluKTRKqh/dW9k+GXaeJbpmfwzS9
1mVm0NXvvXGSM8jrhZudaBzxY2QBrdQGk96OCzqO3sl92HD2H6FnYfNZekKrsY0t
ILXLeDGHTTEwzgtMHUTjdQS9lgSJvR6M0fC8oPytuxcObdBZFAxjXLoFNslyd6SH
WhP10nfpzFc3Rt4LOocO9XBJxGGuH6ZktfCKyrSkjN99dcAvHNnCTaNcPSjYcVqp
ViWPGJnsY5ggoItTL3aQBuTDA7AVtz/q7CJDMS5/cOzjg2Ro7JJSjs/q8ViUlIQ+
XUDYGHsJXrhrXQCp0EiySoAtWgcZuNO+K4wC6cPz9Umm/Lq6WD/C75XNYohrgE2c
pAT2Sit3CbAfa5Y4P3p1OObimLtUJo29BVLbT/D2CZ+gpKjZw5Q=
=g9NP
-----END PGP SIGNATURE-----

--Sig_/Rs768WPBICg6UtwLCHHF1rS--