Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4691572pxb; Tue, 28 Sep 2021 01:40:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhQbfm/AXIFz1cJPzi6YOOgdeDDRJXWK13j74kS3DKnM9FRznCdaQsT0rSPq1OKGPLO1JM X-Received: by 2002:a62:7b0e:0:b0:43d:dbad:a09 with SMTP id w14-20020a627b0e000000b0043ddbad0a09mr4162436pfc.51.1632818426761; Tue, 28 Sep 2021 01:40:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632818426; cv=none; d=google.com; s=arc-20160816; b=EaJxSNtwWIJaxyX8hx2C9SdvCLRZkApCOz1AK7G2RLY9m78wQgDYP+1REEA5pLfoiQ FRzRaW6MqwyzVP44Wh81M4PofpwZ9ibIgh97MQ+fOq7fDXbpUw4g5wH37pzRHOvZQjI/ zhELgDthYXbegXzLsClWvDIx9G6KbZDjJ3x335cVCSVA2e5+zWFFQqlvHPU1o+oQ/OuQ xDMz3Za+i0efUwlpaQp0xGG1OaAt6eHxzHsaFsYCar6JbIQ5e5qjVMR4fXI7CmiTcQUJ QsbxHl9C+jYFMULjXAf1pIxKL7pxOOIY09vQ8q1YzW/oagO37WN67fYErVrbslgcC+41 dn0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iIu3XHeX/2hWPbmTYoP9PzSWuyoc+CNO+138wXnL4b8=; b=hJXlMtH/dPeYareS4Pj/iVOG8vRg8T08KTJ1BvTWzBVDxpiLEv3+DUq0v30WI1mKoE yuJdRAyc4iX5EFpUj75aBFBWVWxzvGteer8eDWp92jlD5gsM2QfRUp4BJ/PmZZDGE3NF 1t/Cp3J5PhEnAMU+7SVSu36Uv3fYgqdlfSSlKbMucu1OM7qkIBAUKhwYTrC2dgSVxjbh fTK5gV0MpNZSxQTgpJf3u7uIsmQFvn40XZgWllarP+rGKJTxzeN22ZhTaokDJNiKrkrw Okisg1XUjgjz+oYRliSFSa7OVViqpYQawseUbGdIc0Kw0WGuNCp2tOwwsSyhv8TjT+Hx enTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PTdYdx0n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t10si25720828pgu.140.2021.09.28.01.40.13; Tue, 28 Sep 2021 01:40:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PTdYdx0n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239667AbhI1Ik6 (ORCPT + 99 others); Tue, 28 Sep 2021 04:40:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52458 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239615AbhI1Ikx (ORCPT ); Tue, 28 Sep 2021 04:40:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632818353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=iIu3XHeX/2hWPbmTYoP9PzSWuyoc+CNO+138wXnL4b8=; b=PTdYdx0nL4Mg6h8DpamL9MIIB0yfr9CNtk0X3VcK4j/6CtfeTs4djksUaTf08wxrIolBXb QJABPFT+fvF6pk/WN2JVk/V18g3EWB02Rj/2h/x1Uw8cbu3zdZOct3DcWmn2KR4FtzlAmM Z9tcDROyOWTArd9GNJMJAMJfzs6SFuE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-183-5nP1mBXyM42AGk-wkXXyHA-1; Tue, 28 Sep 2021 04:39:11 -0400 X-MC-Unique: 5nP1mBXyM42AGk-wkXXyHA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7AC4F802921; Tue, 28 Sep 2021 08:39:10 +0000 (UTC) Received: from xps-13.redhat.com (unknown [10.39.195.86]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF28A5D9D5; Tue, 28 Sep 2021 08:39:08 +0000 (UTC) From: Benjamin Tissoires To: Jiri Kosina , =?UTF-8?q?Michal=20Mal=C3=BD?= Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires Subject: [PATCH 0/2] HID: lg: fix init of devices when FF is off Date: Tue, 28 Sep 2021 10:39:04 +0200 Message-Id: <20210928083906.43983-1-benjamin.tissoires@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, foreword: this was only compiled tested and would greatly benefit from some testing with real hardware. This was discovered in RHEL 8. There, we disable most of the FF bits and it appears returning -1 when the bits are disabled just make the device disappear. Cheers, Benjamin Benjamin Tissoires (2): HID: lg: do not return an error when FF is disabled HID: lg4ff: do not return a value for deinit drivers/hid/hid-lg.h | 6 +++--- drivers/hid/hid-lg4ff.c | 5 ++--- drivers/hid/hid-lg4ff.h | 6 +++--- 3 files changed, 8 insertions(+), 9 deletions(-) -- 2.26.3