Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210927095006.868305-1-arnd@kernel.org> <bd4871e4-62e6-2cb2-26be-34bda8dcb7dd@huawei.com>
In-Reply-To: <bd4871e4-62e6-2cb2-26be-34bda8dcb7dd@huawei.com>
From:   Arnd Bergmann <arnd@kernel.org>
Date:   Tue, 28 Sep 2021 10:58:14 +0200
Message-ID: <CAK8P3a22NhkuWLvFh2+UYEcvzVOf_9m_GdLREqfCCK-+=Q9tug@mail.gmail.com>
Subject: Re: [PATCH] net: hns3: fix hclge_dbg_dump_tm_pg() stack usage
To:     "huangguangbin (A)" <huangguangbin2@huawei.com>
Cc:     Yisen Zhuang <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Huazhong Tan <tanhuazhong@huawei.com>,
        Yufeng Mo <moyufeng@huawei.com>,
        Jiaran Zhang <zhangjiaran@huawei.com>,
        Jian Shen <shenjian15@huawei.com>,
        Networking <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Sep 28, 2021 at 10:34 AM huangguangbin (A)
<huangguangbin2@huawei.com> wrote:
> On 2021/9/27 17:49, Arnd Bergmann wrote: From: Arnd Bergmann <arnd@arndb.de>

> > +static int hclge_dbg_dump_tm_pg(struct hclge_dev *hdev, char *buf, int len)
> > +{
> > +     int ret;
> > +     char *data_str = kcalloc(ARRAY_SIZE(tm_pg_items),
> > +                              HCLGE_DBG_DATA_STR_LEN, GFP_KERNEL);
> > +
> Hi Arnd, thanks your modification, according to linux code style, should the code be written as follow?
>
>         char *data_str;
>         int ret;
>
>         data_str = kcalloc(ARRAY_SIZE(tm_pg_items),
>                            HCLGE_DBG_DATA_STR_LEN, GFP_KERNEL);

That's actually one of the versions I tried, but I didn't really like
any of them, so
I went with the shorter version.

Sending a v2 now with that changed black.

        Arnd