Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4707790pxb; Tue, 28 Sep 2021 02:10:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyR7uuCgSgmkKNb9Tm5kbwA+klAC+1VYs2Lc2k7PPEhn60BXGFpiIRVr24YpclXQMbtZPbR X-Received: by 2002:a17:90b:224b:: with SMTP id hk11mr4229403pjb.231.1632820220081; Tue, 28 Sep 2021 02:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632820220; cv=none; d=google.com; s=arc-20160816; b=GIz2ihBxT/kQk1bh0o0tglJp7vUWzGTEO9of+gU4K769sb3s3fKW3cM3Vo4jF6sVw+ fYfGscacOG5vqbb1QIIV/OISLdZqvXVioGF/Q6IV7Rc5mka+ABUNS4zGroE4cztkRCu/ WY6EewpaTcVIwdRZ77PK2hgQdAwNg0o//pDgcDmR+5wtzBAjDIG8bu7Z9mJykTF37OMw 6nC73mAN/rgxZIkBsUKrfcRGAYaJWtVD1xVBWEMhGlvhrbqQACEmVBStiK/a8TJwYjKY A99wCF2LadiRFH02UdHANoPN81LmTf9TAEHwTjCsF5KYNwFn1jKdhbvnY09zBXs6oijZ 594A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fuN87VcPxDWtklC3neHOgXhlaEeEeQdmiWesEVjS5/o=; b=egwK8qx2Crak5iVuG3XAktnhV3HNlJZ7vKo3WZn7BrQyZLY4FXK6rmxfryx6K5SIt9 DgA3vEimBauhO/w/zmatjzfuziYnM8WnOzTjDc7UDJdtHFuj/X5wIZ60slTvFbIxBXF5 3+5ahfC5yFFrXppfKwHSzmTzVagSHX084FkBVRS72bLXIHAqGAxeAdIla+l06R5aiM9J V9x64nnvcY9Zg1ayXhSobWhVTdqISB7olaMYHkcuf4gCs3l8oC173aOJREpMJQaPadMb RLlit45sxh80jqNm7soXTaf2JoNpqt4bbCJMn/00ZFLrONZfGB/BTTNlE8b5u6+j8qUK i4qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RiqHZJ56; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s13si22857958plq.286.2021.09.28.02.10.07; Tue, 28 Sep 2021 02:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RiqHZJ56; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239817AbhI1JKz (ORCPT + 99 others); Tue, 28 Sep 2021 05:10:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:48212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239795AbhI1JKy (ORCPT ); Tue, 28 Sep 2021 05:10:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DEEAC60FC2; Tue, 28 Sep 2021 09:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632820155; bh=1Vhte9Ro5QwLvH3RD7I8NX1g4Y5GHjQOuHyXqDB5SP4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RiqHZJ56Bc8xwKRyjWd2VRc6QiAa7sRjm1CkEUTVcMIHDKRWw2iszX6r6mRPogcBB uqkRyMbgkovNzgH4FSOxKKyZClW+DdlTPv+9/naHJ98JmDFbA1i4q6YKDOzoj/FX16 FjgQvZ2xYhMalZlnB8jA/gLoDbHapX/dw6zJVZ7w= Date: Tue, 28 Sep 2021 11:09:12 +0200 From: Greg Kroah-Hartman To: Lee Jones Cc: Mauro Carvalho Chehab , linuxarm@huawei.com, mauro.chehab@huawei.com, Arnd Bergmann , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mfd: hi6421-spmi-pmic: cleanup drvdata Message-ID: References: <0cc63f19506ea78d3a1c111774c97bbbc1a9a292.1632812219.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 28, 2021 at 08:49:10AM +0100, Lee Jones wrote: > On Tue, 28 Sep 2021, Greg Kroah-Hartman wrote: > > > On Tue, Sep 28, 2021 at 08:58:19AM +0200, Mauro Carvalho Chehab wrote: > > > There are lots of fields in struct hi6421_spmi_pmic that aren't > > > used. As a matter of fact, only regmap is needed. > > > > > > So, drop the struct as a whole, and just set the regmap as > > > the drvdata. > > > > > > Acked-by: Mark Brown > > > Acked-for-MFD-by: Lee Jones > > > Signed-off-by: Mauro Carvalho Chehab > > > > As everyone else acked this, any objection for me to just take this in > > my char-misc tree? > > > > Otherwise, whoever else want to take it: > > > > Acked-by: Greg Kroah-Hartman > > If you do end up taking it, you'll have to convert my Ack. > > Although, I'm probably in a better position to take it TBH. > > Happy with either. You decide. You can take it, thanks! greg k-h