Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e50923c01c77ee84141eba071c009ff4b59982be.camel@collabora.com>
Subject: Re: [PATCH] misc: gehc: Add SPI ID table
From:   Martyn Welch <martyn.welch@collabora.com>
To:     Mark Brown <broonie@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     linux-kernel@vger.kernel.org
Date:   Tue, 28 Sep 2021 10:27:33 +0100
In-Reply-To: <20210923194609.52647-1-broonie@kernel.org>
References: <20210923194609.52647-1-broonie@kernel.org>
Organization: Collabora Ltd.
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2021-09-23 at 20:46 +0100, Mark Brown wrote:
> Currently autoloading for SPI devices does not use the DT ID table,
> it uses
> SPI modalises. Supporting OF modalises is going to be difficult if
> not
> impractical, an attempt was made but has been reverted, so ensure
> that
> module autoloading works for this driver by adding a SPI ID table
> entry
> for the device name part of the compatible - currently only the full
> compatible is listed which isn't very idiomatic and won't match the
> modalias that is generated.
> 
> Fixes: 96c8395e2166 ("spi: Revert modalias changes")
> Signed-off-by: Mark Brown <broonie@kernel.org>

Tested-by: Martyn Welch <martyn.welch@collabora.com>

> ---
>  drivers/misc/gehc-achc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/misc/gehc-achc.c b/drivers/misc/gehc-achc.c
> index 02f33bc60c56..4c9c5394da6f 100644
> --- a/drivers/misc/gehc-achc.c
> +++ b/drivers/misc/gehc-achc.c
> @@ -539,6 +539,7 @@ static int gehc_achc_probe(struct spi_device
> *spi)
>  
>  static const struct spi_device_id gehc_achc_id[] = {
>         { "ge,achc", 0 },
> +       { "achc", 0 },
>         { }
>  };
>  MODULE_DEVICE_TABLE(spi, gehc_achc_id);