Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 12:26:57 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Yanfei Xu <yanfei.xu@windriver.com>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc:     andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, kuba@kernel.org, p.zabel@pengutronix.de,
        syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Pavel Skripkin <paskripkin@gmail.com>,
        Dongliang Mu <mudongliangabcd@gmail.com>
Subject: Re: [PATCH] net: mdiobus: Fix memory leak in __mdiobus_register
Message-ID: <20210928092657.GI2048@kadam>
References: <20210926045313.2267655-1-yanfei.xu@windriver.com>
 <20210928085549.GA6559@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210928085549.GA6559@kili>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VTc3AQrX68ZPSzG8gzuPxGXj3JDOEqIkg0yZUxBBvP1s+G1DBDHrMVW8DsZh?=
 =?us-ascii?Q?8j5kuyUMKCpfC5ZRer/KPQTNFL8KdaRQVcjLeQ+va8Ry5R7w4KAGfkKVRHEr?=
 =?us-ascii?Q?Uoal4sfNQq+dsJ6Izs8IDE+CJ8dtIrzISxUA2UafjOzpEiZPEpnhMAHK0afx?=
 =?us-ascii?Q?1k1LGkWhRDmCVjrFDmkGfO6+4p8J8gyrQGdbR/TyIriJisOCXfsF+5WejnET?=
 =?us-ascii?Q?qyf35iY72SzD7XWy2dQPZdkfkl+DZIKZJFk35Rf9o3nEtwUDOhoWt2GvYQyr?=
 =?us-ascii?Q?9WoNjG6icaedVV/V9+ODFOV7kQL6eqIMY5F8aZSP9206a+kulx5la2XRUWtH?=
 =?us-ascii?Q?bszDBze7AkO8ZpRtFsqrPH9gCcJe6HL+hyDPB3elEHVnY6d1F8Rrus5eKoFw?=
 =?us-ascii?Q?OiAgiQ8ir2LAHPrJYVeDscslzwxp7iKCOrJaWx0eQ0EM2sDU6Gi8pmgOq5v4?=
 =?us-ascii?Q?3ShOzP8RIQe1UO7zfV3700Ii7sf326Tmx2pBYQD8G00Pxq5H0u6PSlUP+NHB?=
 =?us-ascii?Q?WeABEl7rIjRVyDUWxFJmXol5u+SQ40QXWdNJbxMyC9JHairzwHCRqbq5fZsV?=
 =?us-ascii?Q?LaAYHjbCclk8N/rvfms8TPBvdy3yZ+5MJhfuH7Y+wpDzlG5t8MAS0rAVWltX?=
 =?us-ascii?Q?uOyyavFPtiBIr/Nn6uAUXXuQ66b7hi7WBEiu2lunA5RPxbi1GQhHkJPen5fQ?=
 =?us-ascii?Q?hrXKjMqz3jNi0okrkIoNnAV04n2yA+qYI7K9XjrwATk6N70R57gtT0Iy1ufL?=
 =?us-ascii?Q?4klnwf9PHYSUQymffNZvge9Zr39wWLVDcybXqQVmNeOguTRytkMxDtiYrHs9?=
 =?us-ascii?Q?97kbmPfFDcRDhpHBytAdyt+i0WPnCuPyUYIuKpKfupnM7gpW9oPrQtMl2gj9?=
 =?us-ascii?Q?SNUzaRej/hzr68rawsXO2ApYG2saQWsJSd/lO+nBAi9/xo/p4q9yjMafMJoU?=
 =?us-ascii?Q?5pjl+0BbySYAXFdQ/sUyJjN8FZoKSH1ADxvmHrOsi17ooX7cZEgzdgMSV2jU?=
 =?us-ascii?Q?dkpETB1ZZqJXiDuQaYF2fr1Au1ITTEjdbnW+kkChnQbsocNs55u/WN+TkadJ?=
 =?us-ascii?Q?7K1chmTtCoksg5FiOKOWdVrLQuXu1GaO+9f5Bb6AhirDY9bsuipHa0TPPlmk?=
 =?us-ascii?Q?142hlp3nRR1KeJV2uGs7FW0YK6w3QkLk5QrwVwwdjWovlpuFlaHSVdHFmzCB?=
 =?us-ascii?Q?cYfyO5+kTpoXkYB0V/9b607trqLwsmptRbOhD+eJbuftEiEU3AAR39WVPeHb?=
 =?us-ascii?Q?F79xwwmlxkiJMjhiyrwIyfRzl9lbF7f6Ysk6ww1azfV/mgF8nYqLyqbjK/So?=
 =?us-ascii?Q?XRXH9NpqB/rRWSG1ZZk/9Jtg?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7cfb3e1-1953-44fe-5f17-08d98262298d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 09:27:16.9639
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kxUf0sipM+ZRCAVu7llL6DiaBy4P1mFsS+R+I68Kj3ao6nHV3lmZfq1jolEjKC8siSJEtHhZbxAyut7So85qNCyEFvNw/rgWRQnvetzHTqA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4705
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10120 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0
 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 mlxscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2109280055
X-Proofpoint-ORIG-GUID: COAh17DTEOkbP0lCAGmGyPvy7jgjNpwG
X-Proofpoint-GUID: COAh17DTEOkbP0lCAGmGyPvy7jgjNpwG
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 28, 2021 at 11:55:49AM +0300, Dan Carpenter wrote:
> I don't have a solution.  I have commented before that I hate kobjects
> for this reason because they lead to unfixable memory leaks during
> probe.  But this leak will only happen with fault injection and so it
> doesn't affect real life.  And even if it did, a leak it preferable to a
> crash.

The fix for this should have gone in devm_of_mdiobus_register() but it's
quite tricky.

drivers/net/phy/mdio_devres.c
   106  int devm_of_mdiobus_register(struct device *dev, struct mii_bus *mdio,
   107                               struct device_node *np)
   108  {
   109          struct mdiobus_devres *dr;
   110          int ret;
   111  
   112          if (WARN_ON(!devres_find(dev, devm_mdiobus_free,
   113                                   mdiobus_devres_match, mdio)))
   114                  return -EINVAL;

This leaks the bus.  Fix this leak by calling mdiobus_release(mdio);

   115  
   116          dr = devres_alloc(devm_mdiobus_unregister, sizeof(*dr), GFP_KERNEL);
   117          if (!dr)
   118                  return -ENOMEM;

Fix this path by calling mdiobus_release(mdio);

   119  
   120          ret = of_mdiobus_register(mdio, np);
   121          if (ret) {

Ideally here we can could call device_put(mdio), but that won't work for
the one error path that occurs before device_initialize(). /* Do not
continue if the node is disabled */.

Maybe the code could be modified to call device_initialize() on the
error path?  Sort of ugly but it would work.

   122                  devres_free(dr);
   123                  return ret;
   124          }
   125  
   126          dr->mii = mdio;
   127          devres_add(dev, dr);
   128          return 0;
   129  }

Then audit the callers, and there is only one which references the
mdio_bus after devm_of_mdiobus_register() fails.  It's
realtek_smi_setup_mdio().  Modify that debug statement.

regards,
dan carpenter